Re: [edk2] Line endings: Was "Re: [edk2-test][Patch] uefi-sct/SctPkg:Correct macro name style in HwErrRecVariable Test"

2018-12-17 Thread Laszlo Ersek
On 12/15/18 04:59, Jin, Eric wrote: > Currently, the git am fail with " --ignore-space-change" switch on/off. It is > better if we can solve it with "core.whitespace", "am.keepcr" and > "core.autocrlf" in the meantime. > > Should all existing patches hold until the conversion done or the convers

Re: [edk2] Line endings: Was "Re: [edk2-test][Patch] uefi-sct/SctPkg:Correct macro name style in HwErrRecVariable Test"

2018-12-14 Thread Jin, Eric
Currently, the git am fail with " --ignore-space-change" switch on/off. It is better if we can solve it with "core.whitespace", "am.keepcr" and "core.autocrlf" in the meantime. Should all existing patches hold until the conversion done or the conversion is tried on the branch until it is valida

Re: [edk2] Line endings: Was "Re: [edk2-test][Patch] uefi-sct/SctPkg:Correct macro name style in HwErrRecVariable Test"

2018-12-14 Thread Supreeth Venkatesh
On Fri, 2018-12-14 at 20:57 +0100, Laszlo Ersek wrote: > On 12/14/18 18:12, Supreeth Venkatesh wrote: > > On Fri, 2018-12-14 at 14:24 +0100, Laszlo Ersek wrote: > > > On 12/14/18 11:59, Leif Lindholm wrote: > > > > Hmm, this gets me thinking... > > > > > > > > We were discussing before about doing

Re: [edk2] Line endings: Was "Re: [edk2-test][Patch] uefi-sct/SctPkg:Correct macro name style in HwErrRecVariable Test"

2018-12-14 Thread Laszlo Ersek
On 12/14/18 18:12, Supreeth Venkatesh wrote: > On Fri, 2018-12-14 at 14:24 +0100, Laszlo Ersek wrote: >> On 12/14/18 11:59, Leif Lindholm wrote: >>> Hmm, this gets me thinking... >>> >>> We were discussing before about doing a line ending conversion in >>> edk2, and let the git gools provide native

Re: [edk2] Line endings: Was "Re: [edk2-test][Patch] uefi-sct/SctPkg:Correct macro name style in HwErrRecVariable Test"

2018-12-14 Thread Supreeth Venkatesh
On Fri, 2018-12-14 at 14:24 +0100, Laszlo Ersek wrote: > On 12/14/18 11:59, Leif Lindholm wrote: > > Hmm, this gets me thinking... > > > > We were discussing before about doing a line ending conversion in > > edk2, and let the git gools provide native line endings (as > > designed). > > > > Is th

Re: [edk2] Line endings: Was "Re: [edk2-test][Patch] uefi-sct/SctPkg:Correct macro name style in HwErrRecVariable Test"

2018-12-14 Thread Laszlo Ersek
On 12/14/18 11:59, Leif Lindholm wrote: > Hmm, this gets me thinking... > > We were discussing before about doing a line ending conversion in > edk2, and let the git gools provide native line endings (as designed). > > Is this a good opportunity to run a pilot with edk2-test, where much > less hi

[edk2] Line endings: Was "Re: [edk2-test][Patch] uefi-sct/SctPkg:Correct macro name style in HwErrRecVariable Test"

2018-12-14 Thread Leif Lindholm
Hmm, this gets me thinking... We were discussing before about doing a line ending conversion in edk2, and let the git gools provide native line endings (as designed). Is this a good opportunity to run a pilot with edk2-test, where much less history will be lost? Regards, Leif On Fri, Dec 14, 2