Re: [edk2] memory protection crash in PiSmmCpuDxeSmm, Ia32 build with RAM above 4GB

2017-07-16 Thread Yao, Jiewen
Thanks Laszlo. I agree with you that we can support Base = 0, Length = MAX_ADDR+1. The last page is MAX_ADDR+1-PAGE_SIZE, which is a valid value. I do not think it is necessary to support Base=MAX_ADDR+1, Length=0. It does not match any entry in the page table. Thank you Yao Jiewen From: Lasz

Re: [edk2] memory protection crash in PiSmmCpuDxeSmm, Ia32 build with RAM above 4GB

2017-07-08 Thread Laszlo Ersek
On 07/08/17 15:38, Yao, Jiewen wrote: > Thanks Laszlo. I think this is a special case we did not test before. And it > is a bug we need fix. > > Unfortunately, I am out of office these days with limited email access. I > just saw the email today. > > > I have a quick look at the code. Thank y

Re: [edk2] memory protection crash in PiSmmCpuDxeSmm, Ia32 build with RAM above 4GB

2017-07-08 Thread Yao, Jiewen
Thanks Laszlo. I think this is a special case we did not test before. And it is a bug we need fix. Unfortunately, I am out of office these days with limited email access. I just saw the email today. I have a quick look at the code. I believe we need add below check in UefiCpuPkg\PiSmmCpuDxeSm

[edk2] memory protection crash in PiSmmCpuDxeSmm, Ia32 build with RAM above 4GB

2017-07-07 Thread Laszlo Ersek
Hi Jiewen, I just noticed that building OvmfIa32.dsc with -D SMM_REQUIRE, and then running the 32-bit guest with 4G RAM (of which 2GB are placed in 64-bit address pace), the guest crashes when PiSmmCpuDxeSmm tries to protect the memory range at 4GB. Please find the log attached (it ends with the c