Re: [edk2] [Patch] BaseTools: Fix one crash bug in the report for Fixed structure Pcd

2018-10-18 Thread Zhu, Yonghong
Yes. Thanks for the comment. I will update it when push it. Best Regards, Zhu Yonghong -Original Message- From: Carsey, Jaben Sent: Thursday, October 18, 2018 10:36 PM To: Zhu, Yonghong ; edk2-devel@lists.01.org Subject: RE: [edk2] [Patch] BaseTools: Fix one crash bug in the report

Re: [edk2] [Patch] BaseTools: Fix one crash bug in the report for Fixed structure Pcd

2018-10-18 Thread Carsey, Jaben
Reviewed-by: Jaben Carsey Note that you could change your first 2 lines (of the new content in both places) to: for Data in OverrideValues.values(): since you don't ever use the key later on... -Jaben > -Original Message- > From: edk2-devel