Re: [edk2] OVMF: cross-filesystem copy broken? ("The source and destination are the same")

2016-12-14 Thread Gao, Liming
This should be root cause. edk2\MdePkg\Library\BaseLib\String.c line 554 to implement InternalCharToUpper() with EFIAPI. CHAR16 EFIAPI InternalCharToUpper ( IN CHAR16Char ) edk2\ShellPkg\Library\UefiShellLevel2CommandsLib\UefiShellLevel2CommandsLib.c line 271

Re: [edk2] OVMF: cross-filesystem copy broken? ("The source and destination are the same")

2016-12-14 Thread Palmer, Thomas
Laszlo, et al~ I recently encountered a "cp" failure on OVMF whereby cp always thought my source and destination file paths were equivalent. Turns out that StrniCmp function was broken b/c the InternalCharToUpper declaration in UefiShellLevel2CommandsLib.c was missing the EFIAPI token. Once

Re: [edk2] OVMF: cross-filesystem copy broken? ("The source and destination are the same")

2016-11-17 Thread Laszlo Ersek
On 11/17/16 16:24, Bruce Cran wrote: > On 11/17/2016 2:35 AM, Laszlo Ersek wrote: > >> There's a patch on the list for said BZ: >> [edk2] [PATCH v2] API PathRemoveLastItem not handle root paths properly >> >> so if the BZ is indeed what you're encountering, then the patch should >> fix it for

Re: [edk2] OVMF: cross-filesystem copy broken? ("The source and destination are the same")

2016-11-17 Thread Bruce Cran
On 11/17/2016 2:35 AM, Laszlo Ersek wrote: There's a patch on the list for said BZ: [edk2] [PATCH v2] API PathRemoveLastItem not handle root paths properly so if the BZ is indeed what you're encountering, then the patch should fix it for you. Can you please test it and report back in that

Re: [edk2] OVMF: cross-filesystem copy broken? ("The source and destination are the same")

2016-11-17 Thread Laszlo Ersek
On 11/17/16 04:11, Bruce Cran wrote: > I don't know if this is a known issue, but it appears that > cross-filesystem copies no longer work. I'm running OVMF X64 built from > git commit a0426207c133bdf40c42561f26c20c4b3114d8f9. I've tried copying > between filesystems in various ways - with the