[edk2] [patch 3/5] MdeModulePkg/BMMUI: Make the BmmFakeNvData and BmmOldFakeNVData consistent

2016-10-17 Thread Dandan Bi
related fields in BmmOldFakeNVData, or it will result in incorrect comparison in BootMaintRouteConfig function, then resulting in incorrect UI behaviors. Cc: Laszlo Ersek Cc: Liming Gao Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi

[edk2] [patch 4/5] MdeModulePkg/BMMUI: Show "Change Boot/Driver order" page correctly

2016-10-17 Thread Dandan Bi
sult in incorrect UI behaviors. When the BootOptionOrder has not been saved, we should use the BootOptionOrder in current BmmFakeNvData. Cc: Laszlo Ersek Cc: Liming Gao Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- .../Library/BootMai

[edk2] [patch 2/5] MdeModulePkg/BMMUI: Remove the incorrect and useless codes

2016-10-17 Thread Dandan Bi
the logic here. Cc: Laszlo Ersek Cc: Liming Gao Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- .../Library/BootMaintenanceManagerUiLib/UpdatePage.c | 12 1 file changed, 12 deletions(-) diff --git a/MdeModuleP

[edk2] [patch] IntelFrameworkModulePkg/BootMaint: Show "Change Boot order" page correctly

2016-10-27 Thread Dandan Bi
anoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- .../Universal/BdsDxe/BootMaint/UpdatePage.c| 22 +++--- 1 file changed, 19 insertions(+), 3 deletions(-) diff --git a/IntelFrameworkModulePkg/Universal/BdsDxe/BootMaint/UpdatePage.c b/IntelFrameworkModule

[edk2] [patch] ArmVirPkg: Add FileExplorerLib.inf to the dsc file

2016-02-24 Thread Dandan Bi
: Dandan Bi --- ArmVirtPkg/ArmVirtQemuKernel.dsc | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/ArmVirtPkg/ArmVirtQemuKernel.dsc b/ArmVirtPkg/ArmVirtQemuKernel.dsc index 3bd0cbd..bfa4dbe 100644 --- a/ArmVirtPkg/ArmVirtQemuKernel.dsc +++ b/ArmVirtPkg/ArmVirtQemuKernel.dsc @@ -1,9

[edk2] [patch] MdeModulePkg: Add ASSERT to make sure pointer 'OptionalData' not be NULL

2016-02-25 Thread Dandan Bi
Cc: Liming Gao Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- MdeModulePkg/Library/BootMaintenanceManagerUiLib/Variable.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MdeModulePkg/Library/BootMaintenanceManagerUiLib/Variable.c b

[edk2] [PATCH v4 1/5] ArmVirPkg: Add FileExplorerLib.inf to the QEMU dsc files

2016-02-25 Thread Dandan Bi
: Laszlo Ersek Cc: Ard Biesheuvel Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- ArmVirtPkg/ArmVirtQemu.dsc | 5 - ArmVirtPkg/ArmVirtQemuKernel.dsc | 5 - 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/ArmVirtPkg

[edk2] [PATCH v4 2/5] OvmfPkg: Add FileExplorerLib.inf to the dsc file

2016-02-25 Thread Dandan Bi
Because SecureBootConfigDxe use FileExplorerLib now, but FileExplorerLib is not in the dsc file of the package that use SecureBootConfigDxe. Now add it to pass build. Cc: Jordan Justen Cc: Laszlo Ersek Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan

[edk2] [PATCH v4 0/5] Use FileExplorerLib in SecureBootConfigDxe

2016-02-25 Thread Dandan Bi
x27;t need previous patch. - ArmVirtPkg/ArmVirtQemuKernel.dsc has been added, so add FileExplorerLib.inf to it. Cc: Laszlo Ersek Cc: Ard Biesheuvel Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi Dandan Bi (5): ArmVirPkg: Add FileExplorerLib.i

[edk2] [PATCH v4 3/5] Vlv2TbltDevicePkg: Add FileExplorerLib.inf to the dsc file

2016-02-25 Thread Dandan Bi
Because SecureBootConfigDxe use FileExplorerLib now, but FileExplorerLib is not in the dsc file of the package that use SecureBootConfigDxe. Now add it to pass build. Cc: David Wei Cc: Tim He Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi

[edk2] [PATCH v4 4/5] SecurityPkg: Add FileExplorerLib.inf to the dsc file

2016-02-25 Thread Dandan Bi
Because SecureBootConfigDxe use FileExplorerLib now, but FileExplorerLib is not in the dsc file of the package that use SecureBootConfigDxe. Now add it to pass build. Cc: Chao Zhang Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi Reviewed-by: Eric

[edk2] [PATCH v4 5/5] SecurityPkg: Use FileExplorerLib in SecureBootConfigDxe

2016-02-25 Thread Dandan Bi
Agreement 1.0 Signed-off-by: Dandan Bi Acked-by: Laszlo Ersek Reviewed-by: Eric Dong Reviewed-by: Chao Zhang --- .../SecureBootConfigDxe/SecureBootConfig.vfr | 109 +- .../SecureBootConfigDxe/SecureBootConfigDxe.inf|3 +- .../SecureBootConfigFileExplorer.c | 1127

[edk2] [patch] MdeModulePkg: FileExplorerLib: Add check when to call FreePool function

2016-02-29 Thread Dandan Bi
when free up resource allocated for a MenuEntry, there exists the case that the DevicePath and DisplayString are NULL, so before calling FreePool function, need to check. Cc: Liming Gao Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi

[edk2] [patch] MdeModulePkg: Add ASSERT to make sure pointers are not NULL

2016-02-29 Thread Dandan Bi
Cc: Qiu Shumin Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- MdeModulePkg/Library/FileExplorerLib/FileExplorer.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MdeModulePkg/Library/FileExplorerLib/FileExplorer.c b/MdeModulePkg

[edk2] [patch] MdeModulePkg: FileExplorerLib: Modify the EFI_FILE_EXPLORE_FORMSET_GUID

2016-02-29 Thread Dandan Bi
Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- MdeModulePkg/Library/FileExplorerLib/FormGuid.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MdeModulePkg/Library/FileExplorerLib/FormGuid.h b/MdeModulePkg/Library/FileExplorerLib/FormGuid.h index 011ae22..d0a43a9

[edk2] [patch] SecurityPkg: SecureBootConfigDxe: Enhance the code logic

2016-03-01 Thread Dandan Bi
The function AllocateCopyPool may return NULL, so need to do check after calling it. This patch is to enhance the related logic. Cc: Chao Zhang Cc: Qiu Shumin Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- .../SecureBootConfigDxe

[edk2] [PATCH v2] SecurityPkg: SecureBootConfigDxe: Enhance the code logic

2016-03-01 Thread Dandan Bi
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- .../SecureBootConfigFileExplorer.c | 30 +++--- 1 file changed, 21 insertions(+), 9 deletions(-) diff --git a/SecurityPkg/VariableAuthenticated/SecureBootConfigDxe

[edk2] [PATCH v2] MdeModulePkg: Make HII configuration settings available to OS runtime

2016-03-01 Thread Dandan Bi
previous version: - Add a Pcd to control this feature, default is enabled. - Export the date after ReadyToBoot. Cc: Liming Gao Cc: Eric Dong Cc: Brian J. Johnson Cc: Andrew Fish Cc: El-Haj-Mahmoud, Samer Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi

[edk2] [PATCH v3] MdeModulePkg: Make HII configuration settings available to OS runtime

2016-03-02 Thread Dandan Bi
: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- MdeModulePkg/MdeModulePkg.dec | 8 ++ MdeModulePkg/Universal/HiiDatabaseDxe/Database.c | 144 - .../Universal/HiiDatabaseDxe/HiiDatabase.h | 30 + .../Universal

[edk2] [patch] MdeModulePkg/DisplayEngineDxe: Refine the coding style

2016-03-03 Thread Dandan Bi
Remove the empty line to conform with current coding style. Cc: Qiu Shumin Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- MdeModulePkg/Universal/DisplayEngineDxe/FormDisplay.c | 1 - 1 file changed, 1 deletion(-) diff --git a/MdeModulePkg

[edk2] [patch] MdeModulePkg: Add missing pcd description to MdeModulePkg.uni

2016-03-08 Thread Dandan Bi
Since PcdHiiOsRuntimeSupport has added in the MdeModulePkg.dec file, now add the usage information in the uni file. Cc: Qiu Shumin Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- MdeModulePkg/MdeModulePkg.uni | 8 1 file changed, 8

[edk2] [patch] IntelFrameworkModulePkg/LegacyBootMaintUiLib: Refine the code

2016-03-14 Thread Dandan Bi
Remove the ASSERT code that may be triggered in LegacyBootMaintUiLib. Cc: Liming Gao Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- .../LegacyBootMaintUiLib/LegacyBootMaintUi.c | 30 ++ 1 file changed, 25 insertions

[edk2] [patch] MdeModulePkg: Refine the UI code

2016-03-14 Thread Dandan Bi
Remove the ASSERT in UI code that may be triggered, and clean up the useless code. Cc: Liming Gao Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- MdeModulePkg/Application/UiApp/FrontPage.c | 7 ++- .../BootMaintenanceManagerUiLib

[edk2] [patch] MdeModulePkg/DriverSampleDxe: Uninstall the ConfigAccess protocol

2016-03-14 Thread Dandan Bi
In DriverSampleInit, has installed the configAccess protocol to the DriverHandle[1], but don't uninstall it in DriverSampleUnload. Now uninstall the configAccess protocol. Cc: Liming Gao Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dand

[edk2] [patch 2/2] MdeModulePkg/BootMaintenanceManagerUiLib: Remove type casting in ChooseFile

2016-03-21 Thread Dandan Bi
The type casting is not necessary and now remove it. Cc: Liming Gao Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootMaintenance.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions

[edk2] [patch 1/2] MdeModulePkg/BootMaintManagerUiLib: Declare EFIAPI for ChooseFile handler

2016-03-21 Thread Dandan Bi
handlers: CreateBootOptionFromFile, CreateDriverOptionFromFile, BootFromFile. Now specifies the calling convention for those functions. Cc: Liming Gao Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- .../Library/BootMaintenanceManagerUiLib

[edk2] [patch] MdeModulePkg/HiiDatabaseDxe: Correct the ReallocatePool size

2016-04-12 Thread Dandan Bi
Cc: Liming Gao Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c b

[edk2] [patch] MdeModulePkg/HiiDatabaseDxe: Support EfiVarStore to get AltCfg from Driver

2016-04-12 Thread Dandan Bi
under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- .../Universal/HiiDatabaseDxe/ConfigRouting.c | 517 + 1 file changed, 517 insertions(+) diff --git a/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c b/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRout

[edk2] [PATCH v2] MdeModulePkg/HiiDatabaseDxe: Support EfiVarStore to get AltCfg from Driver

2016-04-13 Thread Dandan Bi
. Cc: Liming Gao Cc: Eric Dong Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- .../Universal/HiiDatabaseDxe/ConfigRouting.c | 534 + 1 file changed, 534 insertions(+) diff --git a/MdeModulePkg/Universal/HiiDataba

[edk2] [patch 0/2] Get default value from CallBack function for OrderedList

2016-04-15 Thread Dandan Bi
SetupBrowser to fix the issue described above. Patch 2 is to add a sample case for orderedlist to get default value through Callback() function. Cc: Liming Gao Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi Dandan Bi (2): MdeModulePkg

[edk2] [patch 2/2] MdeModulePkg/DriverSampleDxe: Add a sample case

2016-04-15 Thread Dandan Bi
Add the sample case for orderedlist to get standard default value from Callback function. Cc: Liming Gao Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- .../Universal/DriverSampleDxe/DriverSample.c | 53

[edk2] [patch 1/2] MdeModulePkg/SetupBrowserDxe: Get default from callback for orderedList

2016-04-15 Thread Dandan Bi
1.0 Signed-off-by: Dandan Bi --- MdeModulePkg/Universal/SetupBrowserDxe/Setup.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c b/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c index b357e29..c36588e 100644 --- a

[edk2] [PATCH v2 0/2] Get default value from CallBack function for OrderedList

2016-04-18 Thread Dandan Bi
: Dandan Bi Dandan Bi (2): MdeModulePkg/SetupBrowserDxe: Get default from callback for orderedList MdeModulePkg/DriverSampleDxe: Add a sample case .../Universal/DriverSampleDxe/DriverSample.c | 53 +- .../Universal/DriverSampleDxe/NVDataStruc.h| 1

[edk2] [PATCH v2 1/2] MdeModulePkg/SetupBrowserDxe: Get default from callback for orderedList

2016-04-18 Thread Dandan Bi
1.0 Signed-off-by: Dandan Bi --- MdeModulePkg/Universal/SetupBrowserDxe/Setup.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c b/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c index b357e29..c36588e 100644 --- a

[edk2] [PATCH v2 2/2] MdeModulePkg/DriverSampleDxe: Add a sample case

2016-04-18 Thread Dandan Bi
Add the sample case for orderedlist to get standard default value from Callback function. Notes: V2: - Refine the sample case. Cc: Liming Gao Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- .../Universal/DriverSampleDxe/DriverSample.c

[edk2] [PATCH v3] MdeModulePkg/HiiDatabaseDxe: Support EfiVarStore to get AltCfg from Driver

2016-04-18 Thread Dandan Bi
ction FindSameBlockElement (). Cc: Liming Gao Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- .../Universal/HiiDatabaseDxe/ConfigRouting.c | 541 + 1 file changed, 541 insertions(+) diff --git a/MdeModulePkg/Universal/HiiDataba

[edk2] [patch] MdeModulePkg/HiiDatabaseDxe: Add ASSERT before using the pointer 'String'

2016-06-23 Thread Dandan Bi
odes. Cc: Eric Dong Cc: Hao Wu Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- MdeModulePkg/Universal/HiiDatabaseDxe/ConfigKeywordHandler.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/MdeModulePkg/Universal/HiiDatabaseDxe/Confi

[edk2] [patch 0/2] MdeModulePkg/Ui: Remove the implicit dependency for libraries

2016-07-04 Thread Dandan Bi
: Dandan Bi Dandan Bi (2): MdeModulePkg/BootMaintUiLib: Update menus when open BMM form IntelFrameworkModulePkg/LegacyUi: Get legacy options when open legacy form .../LegacyBootMaintUiLib/LegacyBootMaintUi.c | 42 ++ .../BootMaintenanceManagerUiLib

[edk2] [patch 1/2] MdeModulePkg/BootMaintUiLib: Update menus when open BMM form

2016-07-04 Thread Dandan Bi
option) when opening the BMM form. When opening BMM form, the LeagcyBootMaintUiLib must have been initialized. Cc: Liming Gao Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi Reviewed-by: Eric Dong --- .../BootMaintenanceManagerUiLib

[edk2] [patch 2/2] IntelFrameworkModulePkg/LegacyUi: Get legacy options when open legacy form

2016-07-04 Thread Dandan Bi
legacy forminstead in its the constructor function. Because when opening the legacy form, the LegacyBootManagerLib must have been initialized. Cc: Liming Gao Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi Reviewed-by: Eric Dong

[edk2] [patch 0/2]MdeModulePkg: Add error handling codes in function HiiGetFormSetFromHiiHandle

2016-07-04 Thread Dandan Bi
Patch 1 is to enhance the error handling codes in function HiiGetFormSetFromHiiHandle Patch 2 is enhance the logic in the caller functions of HiiGetFormSetFromHiiHandle. Cc: Eric Dong Cc: Hao Wu Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi Dandan Bi (2

[edk2] [patch 1/2] MdeModulePkg/UefiHiiLib: Add error handling codes when AllocatePool fail

2016-07-04 Thread Dandan Bi
Cc: Eric Dong Cc: Hao Wu Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- MdeModulePkg/Library/UefiHiiLib/HiiLib.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/MdeModulePkg/Library/UefiHiiLib/HiiLib.c b/MdeModulePkg

[edk2] [patch 2/2] MdeModulePkg/Ui: Add ASSERT before using the pointer "Buffer"

2016-07-04 Thread Dandan Bi
Pointer "Buffer" is returned by function HiiGetFormSetFromHiiHandle, when the function HiiGetFormSetFromHiiHandle return success, the "Buffer" can not be NULL, so we add the ASSET codes. Cc: Eric Dong Cc: Hao Wu Contributed-under: TianoCore Contribution Agreement 1.0 Sign

[edk2] [patch] MdeModulePkg/HiiDB: Record fail info if fail to save data for EfiVarStore

2016-07-05 Thread Dandan Bi
w the reason of failure. Cc: Liming Gao Cc: Eric Dong Cc: Chao Zhang Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi Reviewed-by: Eric Dong --- MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/MdeModu

[edk2] [patch] MdeModulePkg/BootMaintUi: Add error handling codes when AllocatePool fail

2016-07-05 Thread Dandan Bi
Agreement 1.0 Signed-off-by: Dandan Bi Reviewed-by: Eric Dong --- .../BootMaintenanceManagerUiLib/BootMaintenance.c | 5 ++- .../BootMaintenanceManagerUiLib/BootOption.c | 42 -- .../BootMaintenanceManagerUiLib/UpdatePage.c | 14 3 files changed, 35 insertions

[edk2] [PATCH v2 1/2] MdeModulePkg/BootMaintUiLib: Update menus when open BMM form

2016-07-06 Thread Dandan Bi
option) when opening the BMM form. We think when opening BMM form, the LeagcyBootMaintUiLib must have been initialized. Cc: Liming Gao Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi Reviewed-by: Eric Dong --- .../BootMaintenanceManagerUiLib

[edk2] [PATCH v2 0/2] MdeModulePkg/Ui: Remove the implicit dependency for libraries

2016-07-06 Thread Dandan Bi
orm is open in the callback function. -Patch 2:compare the question id when the form is open in the callback function. Cc: Liming Gao Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi Dandan Bi (2): MdeModulePkg/BootMaintUiLib: Update menus when o

[edk2] [PATCH v2 2/2] IntelFrameworkModulePkg/LegacyUi: Get legacy options when open legacy form

2016-07-06 Thread Dandan Bi
forminstead in its the constructor function. Because when opening the legacy form, the LegacyBootManagerLib must have been initialized. Cc: Liming Gao Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi Reviewed-by: Eric Dong

[edk2] [patch] MdePkg/HiiImageEx: Fix incorrect parameter type in GetImageInfo()

2016-07-15 Thread Dandan Bi
ted-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- MdePkg/Include/Protocol/HiiImageEx.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MdePkg/Include/Protocol/HiiImageEx.h b/MdePkg/Include/Protocol/HiiImageEx.h index 9905ecd..b92fc3a 100644 --- a/Mde

[edk2] [patch 0/2] BaseTools/VfrCompile: Add two new option for VfrCompile

2016-08-01 Thread Dandan Bi
patch 1 is to fix a bug in current code. patch 2 is to add two compile option for VfrCompile. Cc: Liming Gao Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi Dandan Bi (2): BaseTool/VfrCompile: Add missing question opcode BaseTools/VfrCompile

[edk2] [patch 1/2] BaseTool/VfrCompile: Add missing question opcode

2016-08-01 Thread Dandan Bi
The function CheckQuestionOpCode is to check whether the opcode is question opcode, but it misses two question opcodes: 'EFI_IFR_REF_OP' and 'EFI_IFR_RESET_BUTTON'. Now add them. Cc: Liming Gao Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.0 Sign

[edk2] [patch 2/2] BaseTools/VfrCompile: Add two new option for VfrCompile

2016-08-01 Thread Dandan Bi
default. Cc: Liming Gao Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi Reviewed-by: Eric Dong --- BaseTools/Source/C/VfrCompile/VfrCompiler.cpp | 56 +- BaseTools/Source/C/VfrCompile/VfrCompiler.h | 3 +- BaseTools/Source/C/VfrCompile

[edk2] [patch 0/2] Share default value if some default value are not specified

2016-08-04 Thread Dandan Bi
m the existing defaults, and share its value to other default id which has no default value. Cc: Liming Gao Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi Dandan Bi (2): MdeModulePkg/HiiDB: Share default if some default value are not spec

[edk2] [patch 1/2] MdeModulePkg/HiiDB: Share default if some default value are not specified

2016-08-04 Thread Dandan Bi
share its value to other default id which has no default value. Cc: Liming Gao Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi Reviewed-by: Eric Dong --- .../Universal/HiiDatabaseDxe/ConfigRouting.c | 115 ++--- .../Univ

[edk2] [patch 2/2] MdeModulePkg/Browser: Share default if some default value are not specified

2016-08-04 Thread Dandan Bi
share its value to other default id which has no default value. Cc: Liming Gao Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi Reviewed-by: Eric Dong --- MdeModulePkg/Universal/SetupBrowserDxe/Setup.c | 66 +- MdeModu

[edk2] [PATCH v2 2/2] MdeModulePkg/Browser: Share default if some default value are not specified

2016-08-08 Thread Dandan Bi
, and share its value to other default id which has no default value. Notes: v1->V2: Generate DefaultStoreList as ascending order directly instead of using function GetDefaultIdArray(). Cc: Liming Gao Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: D

[edk2] [PATCH v2 1/2] MdeModulePkg/HiiDB: Share default if some default value are not specified

2016-08-08 Thread Dandan Bi
, and share its value to other default id which has no default value. Notes: v1->V2: Clarify that when the type of DefaultValueData is DefaultValueFromOtherDefault,it can be overrode by itself. Cc: Liming Gao Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: D

[edk2] [PATCH v2 0/2] Share default value if some default value are not specified

2016-08-08 Thread Dandan Bi
f using function GetDefaultIdArray(). Cc: Liming Gao Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi Dandan Bi (2): MdeModulePkg/HiiDB: Share default if some default value are not specified MdeModulePkg/Browser: Share default if some defau

[edk2] [patch] MdeModulePkg/DriverSample: Skip the character "&" before "OFFSET="

2016-08-09 Thread Dandan Bi
When comparing the L"OFFSET=" with the ConfigResp string to find all the "OFFSET=" in ConfigResp, should skip the character "&" before "OFFSET=" in ConfigResp string. Cc: Liming Gao Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.0

[edk2] [patch] MdeModulePkg/Browser: Enhance the logic when getting value from AltResp

2016-08-09 Thread Dandan Bi
StorageWidth of the question. Cc: Liming Gao Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi Reviewed-by: Eric Dong --- MdeModulePkg/Universal/SetupBrowserDxe/Setup.c | 54 +- 1 file changed, 28 insertions(+), 26 deletions

[edk2] [patch] BaseTool/VfrCompile: Remove reset button opcode in CheckQuestionOpCode

2016-08-10 Thread Dandan Bi
"EFI_IFR_RESET_BUTTON_OP" is a statement, not a question, so remove it from function CheckQuestionOpCode. Cc: Liming Gao Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- BaseTools/Source/C/VfrCompile/VfrFormPkg.cpp | 1 - 1 file

[edk2] [PATCH v2] MdeModulePkg/Browser: Enhance the logic when getting value from AltResp

2016-08-11 Thread Dandan Bi
StorageWidth of the question. Notes: V2: - Add some comments to make the logic clear. Cc: Liming Gao Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi Reviewed-by: Eric Dong --- MdeModulePkg/Universal/SetupBrowserDxe/Setup.c | 61

[edk2] [patch] MdeModulePkg/Browser: Fix conflicting policy in getting default of checkbox

2016-08-18 Thread Dandan Bi
checkbox conflicts with the new added policy, so now we move this behavior to the end of getting default form other default id. Cc: Liming Gao Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- MdeModulePkg/Universal/SetupBrowserDxe/Setup.c | 7

[edk2] [patch] ShellPkg: Fix the incorrect return status in function FindFiles()

2016-08-23 Thread Dandan Bi
ff-by: Dandan Bi --- ShellPkg/Application/Shell/ShellProtocol.c | 4 1 file changed, 4 insertions(+) diff --git a/ShellPkg/Application/Shell/ShellProtocol.c b/ShellPkg/Application/Shell/ShellProtocol.c index 0e5d954..6f29250 100644 --- a/ShellPkg/Application/Shell/ShellProtocol.c +++ b/She

[edk2] [patch] ShellPkg: Add check for "dump" parameter in "bcfg" command

2016-08-30 Thread Dandan Bi
ution Agreement 1.0 Signed-off-by: Dandan Bi --- ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.c | 4 ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.uni | 3 ++- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/ShellPkg/Library/UefiShel

[edk2] [patch] ShellPkg: Add the check of parameter number in "DrvCfg" command

2016-08-30 Thread Dandan Bi
tly. Cc: Ruiyu Ni Cc: Jaben Carsey Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- ShellPkg/Library/UefiShellDriver1CommandsLib/DrvCfg.c | 5 + 1 file changed, 5 insertions(+) diff --git a/ShellPkg/Library/UefiShellDriver1CommandsLib/DrvCfg.c b/S

[edk2] [patch] MdeModulePkg:Correct the parameter order in match2 sample opcode

2015-07-20 Thread Dandan Bi
The first parameter of match2 opcode should be the pattern and the second one should be the string. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- MdeModulePkg/Universal/DriverSampleDxe/Vfr.vfr | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[edk2] [patch] MdeModulePkg:Check the case caused by mismatch

2015-07-20 Thread Dandan Bi
When mismatch happens,there exists one case that exit current form and display last form.Assert code don't cover this case. Now add check to handle this situation. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- MdeModulePkg/Universal/DisplayEngi

[edk2] [patch] MdeModulePkg:Add ESC key support in setup browser pop-up message box

2015-07-23 Thread Dandan Bi
to ignore." Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- .../Universal/DisplayEngineDxe/FormDisplay.c| 3 ++- .../Universal/DisplayEngineDxe/FormDisplayStr.uni | Bin 17032 -> 17048 bytes 2 files changed, 2 insertions(+), 1 deletion(-) di

[edk2] [patch] MdeModulePkg:SetupBrowser output debug message when DisplayEngineDxe is not installed

2015-07-23 Thread Dandan Bi
Enhance the setupbrowserdxe to output debug message when DisplayEngineDxe is not installed and this will be easy for user to find the reason why can not enter Setup page. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- MdeModulePkg/Universal/SetupBrowserDxe

[edk2] [PATCH v2] MdeModulePkg:Add ESC key support in setup browser pop-up message box

2015-07-26 Thread Dandan Bi
;ESC' to ignore." Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- .../Universal/DisplayEngineDxe/FormDisplay.c| 3 ++- .../Universal/DisplayEngineDxe/FormDisplayStr.uni | Bin 17032 -> 17056 bytes 2 files changed, 2 insertions(+

[edk2] [patch] MdeModulePkg:Fix the issue FindQuestionFromProgress in SetupBrowserDxe is broken

2015-07-30 Thread Dandan Bi
the configuration string in SetupBrowserDxe to lowercase to fix this issue. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- MdeModulePkg/Universal/SetupBrowserDxe/IfrParse.c | 1 + MdeModulePkg/Universal/SetupBrowserDxe/Setup.h| 13 + 2

[edk2] [patch 2/2] MdeModulePkg:Refine the code comments in UiApp

2015-08-03 Thread Dandan Bi
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- .../Application/UiApp/BootMaint/BootMaint.c| 1 - .../Application/UiApp/DeviceMngr/DeviceManager.h | 4 +- MdeModulePkg/Application/UiApp/FrontPage.c | 4 ++ MdeModulePkg/Application/UiApp

[edk2] [patch 1/2] IntelFrameworkModulePkg:Refine the code comments in LegacyBootMaintUiLib

2015-08-03 Thread Dandan Bi
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- .../Library/LegacyBootMaintUiLib/LegacyBootMaintUi.c | 4 +--- .../Library/LegacyBootMaintUiLib/LegacyBootMaintUiLib.inf| 12 ++-- 2 files changed, 7 insertions(+), 9 deletions(-) diff

[edk2] [patch] MdeModulePkg:Fix the issue that refresh the question fail in DriverSample

2015-08-03 Thread Dandan Bi
Once the question is refreshed,the processing should happen in the callback function of EFI_BROWSER_ACTION_RETRIEVE case,rather than EFI_BROWSER_ACTION_CHANGING in DriverSample. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- .../Universal/DriverSampleDxe

[edk2] [patch 1/2] IntelFrameworkModulePkg:Refine the code in LegacyBootMaintUiLib

2015-08-10 Thread Dandan Bi
Refine the code in LegacyBootMaintUiLib to prevent the potential risk. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- .../Library/LegacyBootMaintUiLib/LegacyBootMaintUi.c| 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git

[edk2] [patch 2/2] MdeModulePkg: Refine the code in UiApp

2015-08-10 Thread Dandan Bi
Refine the code in UiApp to prevent the potential risk. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- MdeModulePkg/Application/UiApp/BootMaint/FileExplorer.c | 1 - MdeModulePkg/Application/UiApp/BootMaint/Variable.c | 12 ++-- 2 files changed

[edk2] [patch] MdeModulePkg:Use safe string functions in UiApp.

2015-08-10 Thread Dandan Bi
Replace the unsafe string functions with the safe one in UiApp. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- .../Application/UiApp/BootMaint/BootOption.c | 30 ++ .../Application/UiApp/BootMaint/FormGuid.h | 2

[edk2] [patch] MdeModulePkg:Fix the issue that Commit changes and Exit fail when add driver option

2015-08-13 Thread Dandan Bi
TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- MdeModulePkg/Application/UiApp/BootMaint/Variable.c | 20 1 file changed, 8 insertions(+), 12 deletions(-) diff --git a/MdeModulePkg/Application/UiApp/BootMaint/Variable.c b/MdeModulePkg/Application/UiApp/BootMaint/

[edk2] [patch] MdeModulePkg:Full support F10 hot key in UiApp.

2015-08-17 Thread Dandan Bi
In current UiApp/Boot Maintenance manager,some pages don't support F10, they use Commit Changes and Exit menu to save changes.Now support F10 in these pages. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- .../Application/UiApp/BootMaint/Bmstrin

[edk2] [PATCH v2] MdeModulePkg:Full support F10 hot key in UiApp.

2015-08-19 Thread Dandan Bi
In current UiApp/Boot Maintenance manager,some pages don't support F10, they use Commit Changes and Exit menu to save changes.Now support F10 in these pages.Compared with previous patch,mainly update the console page. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: D

[edk2] [patch] MdeModulePkg:Refine the code in HiiDatabaseDxe

2015-08-23 Thread Dandan Bi
Check the local variable 'NameSpace' before use it. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- MdeModulePkg/Universal/HiiDatabaseDxe/ConfigKeywordHandler.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/Md

[edk2] [patch 1/2] BaseTools:To generate string default type correctly in VfrCompiler

2015-08-26 Thread Dandan Bi
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- BaseTools/Source/C/VfrCompile/VfrFormPkg.h | 1 + BaseTools/Source/C/VfrCompile/VfrSyntax.g | 6 -- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/BaseTools/Source/C/VfrCompile/VfrFormPkg.h

[edk2] [patch 2/2] MdeModulePkg:Set default string value

2015-08-26 Thread Dandan Bi
Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- MdeModulePkg/Universal/DriverSampleDxe/Vfr.vfr | 1 + .../Universal/DriverSampleDxe/VfrStrings.uni | Bin 63554 -> 63834 bytes .../Universal/HiiDatabaseDxe/ConfigRouting.c | 23 ++--- 3 files changed,

[edk2] [patch] MdeModulePkg:Support orderedList with default value

2015-09-01 Thread Dandan Bi
Our tool can support OrderedList which has default value,but doesn't update the source code in HiiDatabase when parse the ifr data.Now update the code and add test case in DriverSample. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- MdeModulePkg/Univ

[edk2] [patch] MdeModulePkg:Refine the code comments in RegularExpressionDxe.

2015-09-10 Thread Dandan Bi
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- .../RegularExpressionDxe/RegularExpressionDxe.c| 146 + .../RegularExpressionDxe/RegularExpressionDxe.h| 108 +++ .../RegularExpressionDxe/RegularExpressionDxe.inf | 10

[edk2] [patch] MdeModulePkg:Fix the bug the incorrect change of StrCpyS function

2015-09-16 Thread Dandan Bi
The pointer to the destination string changed,the max length also changed.Previous change neglect this point. And base on the code logic,we can use StrCatS to replace StrCpyS.Now this patch is to fix this bug. Signed-off-by: Dandan Bi --- MdeModulePkg/Library/UefiHiiLib/HiiLib.c

[edk2] [patch] BaseTools/VfrCompile: report error for Integer overflow

2018-12-28 Thread Dandan Bi
1.1 Signed-off-by: Dandan Bi --- BaseTools/Source/C/VfrCompile/VfrError.cpp | 2 +- BaseTools/Source/C/VfrCompile/VfrError.h | 2 +- BaseTools/Source/C/VfrCompile/VfrSyntax.g | 10 +- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/BaseTools/Source/C/VfrCompile

[edk2] [patch] MdeModulePkg/NonDiscoverable: Use compare operator for comparison

2018-12-28 Thread Dandan Bi
Contribution Agreement 1.1 Signed-off-by: Dandan Bi --- .../NonDiscoverablePciDeviceDxe/NonDiscoverablePciDeviceIo.c| 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverablePciDeviceIo.c b/MdeModulePkg/Bus/Pci

[edk2] [patch] MdeModulePkg/NonDiscoverablePciDevice: Remove the redundant check

2019-01-01 Thread Dandan Bi
e not 0. So we can remove the redundant check "if (Attributes)". Cc: Vladimir Olovyannikov Cc: Jian J Wang Cc: Hao Wu Cc: Ard Biesheuvel Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Dandan Bi Reviewed-by: Star Zeng --- .../NonDiscoverablePciDeviceIo.c

[edk2] [patch] MdePkg/BasePeCoffLib: Add more check for relocation data

2019-01-04 Thread Dandan Bi
g function PeCoffLoaderImageAddress which will cover more check and validation. Cc: Michael D Kinney Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Dandan Bi --- MdePkg/Library/BasePeCoffLib/BasePeCoff.c | 29 +++ 1 file changed, 24 insertions(+), 5

[edk2] [patch v2] MdePkg/BasePeCoffLib: Add more check for relocation data

2019-01-14 Thread Dandan Bi
l consideration, it's not safe enough. So this patch is to replace the same code logic with function PeCoffLoaderImageAddress which will cover more validation. Cc: Michael D Kinney Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Dandan Bi --- MdePkg/L

[edk2] [patch] MdePkg/BasePeCoffLib: Correct the address of RelocBaseEnd

2019-01-18 Thread Dandan Bi
>Size - 1 not ImageBase + RelocDir->VirtualAddress + RelocDir->Size This patch is to fix this issue when call PeCoffLoaderImageAddress function to calculate the address of RelocBaseEnd. Cc: Michael D Kinney Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed

[edk2] [patch] ShellPkg/UefiShellAcpiViewCommandLib: Fix VS tool chain build failure

2019-01-27 Thread Dandan Bi
ted ...\Parsers\Pptt\PpttParser.c(193): warning C4244: '=': conversion from 'UINT32' to 'UINT8', possible loss of data Cc: Krzysztof Koch Cc: Jaben Carsey Cc: Ray Ni Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Dandan Bi --- .../UefiShellAcpiViewCo

[edk2] [patch 0/2] Fix coding style issues in MdeModulePkg and MdePkg

2019-01-31 Thread Dandan Bi
Cc: Ard Biesheuvel Cc: Liming Gao Cc: Jian J Wang Cc: Hao Wu Dandan Bi (2): MdeModulePkg: Fix coding style issues MdePkg: Fix coding style issues .../FaultTolerantWriteSmmCommon.h| 4 ++-- .../FaultTolerantWriteStandaloneMm.c | 2

[edk2] [patch 1/2] MdeModulePkg: Fix coding style issues

2019-01-31 Thread Dandan Bi
ned-off-by: Dandan Bi --- .../FaultTolerantWriteDxe/FaultTolerantWriteSmmCommon.h | 4 ++-- .../FaultTolerantWriteDxe/FaultTolerantWriteStandaloneMm.c | 2 +- .../FaultTolerantWriteDxe/FaultTolerantWriteTraditionalMm.c | 2 +- .../Universal/Variable/RuntimeDxe/PrivilegePolymorphi

[edk2] [patch 2/2] MdePkg: Fix coding style issues

2019-01-31 Thread Dandan Bi
bution Agreement 1.1 Signed-off-by: Dandan Bi --- .../Library/StandaloneMmDriverEntryPoint.h | 16 .../StandaloneMmDriverEntryPoint.c | 4 ++-- .../StandaloneMmServicesTableLib.c | 4 ++-- 3 files changed, 12 insertions(+), 12 deletions(-) diff -

[edk2] [patch] MdeModulePkg/ReportStatusCodeLib: Avoid using AllocatePool if possible

2019-02-02 Thread Dandan Bi
avoid using AllocatePool. Cc: Jian J Wang Cc: Hao Wu Cc: Michael Turner Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Dandan Bi --- .../Library/DxeReportStatusCodeLib/ReportStatusCodeLib.c | 9 +++-- .../RuntimeDxeReportStatusCodeLib

[edk2] [patch V2] MdeModulePkg/ReportStatusCodeLib: Avoid using AllocatePool if possible

2019-02-13 Thread Dandan Bi
to avoid using AllocatePool. Cc: Jian J Wang Cc: Hao Wu Cc: Michael Turner Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Dandan Bi --- .../Library/DxeReportStatusCodeLib/ReportStatusCodeLib.c | 9 +++-- .../RuntimeDxeReportStatusCodeLib/ReportStatus

[edk2] [patch 2/2] MdeModulePkg/BmBoot: Report status when fail to load/start boot option

2019-02-15 Thread Dandan Bi
: Jian J Wang Cc: Hao Wu Cc: Ruiyu Ni Cc: Laszlo Ersek Cc: Sean Brogan Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Dandan Bi --- .../Library/UefiBootManagerLib/BmBoot.c | 22 ++- 1 file changed, 16 insertions(+), 6 deletions(-) diff --git a

<    1   2   3   4   5   6   7   >