Reviewed-by: Fu Siyuan
> -Original Message-
> From: Wu, Jiaxin
> Sent: Tuesday, January 2, 2018 11:34 AM
> To: edk2-devel@lists.01.org
> Cc: Ye, Ting ; Fu, Siyuan ; Kinney,
> Michael D ; Wu, Jiaxin
> Subject: [Patch] NetworkPkg/HttpDxe: Fix build warning error i
Reviewed-by: Fu Siyuan
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Wang Fan
> Sent: Tuesday, January 9, 2018 9:19 AM
> To: edk2-devel@lists.01.org
> Cc: Ye, Ting ; Fu, Siyuan ; Wu,
> Jiaxin
> Su
Hi, Jiaxin,
The patch is good to me.
Reviewed-by: Fu Siyuan
> -Original Message-
> From: Wu, Jiaxin
> Sent: Tuesday, January 9, 2018 10:56 AM
> To: edk2-devel@lists.01.org
> Cc: Ye, Ting ; Fu, Siyuan ; Wu,
> Jiaxin
> Subject: [Patch 0/2] IScsiDxe: Set ExitBoo
Reviewed-by: Fu Siyuan
> -Original Message-
> From: Wang, Fan
> Sent: Tuesday, January 9, 2018 9:19 AM
> To: edk2-devel@lists.01.org
> Cc: Wu, Jiaxin ; Ye, Ting ; Fu,
> Siyuan
> Subject: [Patch 1/2] MdeModulePkg: Fixed two issues when error occurs in
> Mtftp4Sta
Contribution Agreement 1.0
Signed-off-by: Fu Siyuan
---
NetworkPkg/UefiPxeBcDxe/PxeBcImpl.c | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/NetworkPkg/UefiPxeBcDxe/PxeBcImpl.c
b/NetworkPkg/UefiPxeBcDxe/PxeBcImpl.c
index 93f3bfa5ba..9068e0686c 100644
--- a/NetworkPkg
Reviewed-by: Fu Siyuan
> -Original Message-
> From: Wang, Fan
> Sent: Thursday, January 11, 2018 6:14 PM
> To: edk2-devel@lists.01.org
> Cc: Fu, Siyuan ; Wu, Jiaxin ; Wu,
> Hao A
> Subject: [Patch v2] MdeModulePkg/DxeNetLib: Add array range check in
> Net
Reviewed-by: Fu Siyuan
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Wang Fan
> Sent: Thursday, January 11, 2018 6:20 PM
> To: edk2-devel@lists.01.org
> Cc: Ye, Ting ; Fu, Siyuan ; Wu,
> Jiaxin
> Subject: [ed
Reviewed-by: Fu Siyuan
> -Original Message-
> From: Wang, Fan
> Sent: Wednesday, January 10, 2018 11:16 AM
> To: edk2-devel@lists.01.org
> Cc: Wu, Jiaxin ; Ye, Ting ; Fu,
> Siyuan
> Subject: [Patch 1/2] MdeModulePkg: Freed the received packet buffer if it
> is n
Reviewed-by: Fu Siyuan
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Wang Fan
> Sent: Wednesday, January 10, 2018 11:16 AM
> To: edk2-devel@lists.01.org
> Cc: Ye, Ting ; Fu, Siyuan ; Wu,
> Jiaxin
> Su
orked
well.
Please tell me if you meet problem with this patch on your system, or have any
objection to include this patch to UDK2018.
BestRegards
Fu Siyuan
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Fu Siyuan
---
MdeModulePkg/Universal/Network/UefiPxeBcDxe/PxeBcDhcp.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/MdeModulePkg/Universal/Network/UefiPxeBcDxe/PxeBcDhcp.c
b/MdeModulePkg/Universal/Network
Current PXE driver uses zero GUID if failed to get the system GUID from smbios
table, and some OS PXE boot may fail in such case. This patch is to add a
warning
message to inform user that smbios table is missed on the platform.
Fu Siyuan (2):
NetworkPkg: Add warning message for PXE if failed
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Fu Siyuan
---
NetworkPkg/UefiPxeBcDxe/PxeBcDhcp4.c | 3 +++
NetworkPkg/UefiPxeBcDxe/PxeBcImpl.c | 1 +
2 files changed, 4 insertions(+)
diff --git a/NetworkPkg/UefiPxeBcDxe/PxeBcDhcp4.c
b/NetworkPkg/UefiPxeBcDxe/PxeBcDhcp4.c
index
Jiewen,
NetLibGetSystemGuid is also used by some other drivers like DHCP6, and it's
acceptable to not use system GUID as client identifier in DHCP protocol. That's
why I only add the warning in PXE driver.
BestRegards
Fu Siyuan
> -Original Message-
> From: Yao, Jiewe
Wu, Jiaxin
> Sent: Friday, February 9, 2018 12:00 PM
> To: edk2-devel@lists.01.org
> Cc: Laszlo Ersek ; Kinney, Michael D
> ; Zimmer, Vincent ;
> Yao, Jiewen ; Ye, Ting ; Fu,
> Siyuan ; Wu, Jiaxin
> Subject: [Patch 0/2] NetworkPkg: Support the platform to configure TLS
> CipherL
Reviewed-by: Fu Siyuan
> -Original Message-
> From: Wu, Jiaxin
> Sent: Sunday, February 11, 2018 11:15 AM
> To: edk2-devel@lists.01.org
> Cc: Laszlo Ersek ; Kinney, Michael D
> ; Zimmer, Vincent ;
> Yao, Jiewen ; Ye, Ting ; Fu,
> Siyuan ; Wu, Jiaxin
> Subject
Reviewed-by: Fu Siyuan
> -Original Message-
> From: Wu, Jiaxin
> Sent: Tuesday, February 27, 2018 11:53 AM
> To: edk2-devel@lists.01.org
> Cc: Karunakar P ; Ye, Ting ;
> Fu, Siyuan ; Wu, Jiaxin
> Subject: [Patch] NetworkPkg/HttpDxe: Support HTTP Delete Method.
&g
Reviewed-by: Fu Siyuan
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Jiaxin Wu
> Sent: Thursday, March 1, 2018 2:30 PM
> To: edk2-devel@lists.01.org
> Cc: Ye, Ting ; Fu, Siyuan ; Wu,
> Jiaxin
> Subject: [
Reviewed-by: Fu Siyuan
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Jiaxin Wu
> Sent: Thursday, March 1, 2018 2:30 PM
> To: edk2-devel@lists.01.org
> Cc: Ye, Ting ; Fu, Siyuan ; Wu,
> Jiaxin
> Subject: [
Reviewed-by: Fu Siyuan
> -Original Message-
> From: Wu, Jiaxin
> Sent: Thursday, March 1, 2018 5:38 PM
> To: edk2-devel@lists.01.org
> Cc: Wang, Fan ; Fu, Siyuan ; Ye,
> Ting
> Subject: [Patch] NetworkPkg/Udp6Dxe: Fix the failure to leave one
> multicast
Hi, Jiaxin
Do you mean the code which calls MTFTP4->Poll() at TPL_CALLBACK will cause
system hang? This should not happen because all network protocol should be able
to run at TPL_CALLBACK.
BestRegards
Fu Siyuan
> -Original Message-
> From: Wu, Jiaxin
> Sent: Thursday, M
Jiaxin,
There will be problem if someone calls Mtftp.Start() at TPL Callback to
send/receive a file with your patch. In such case the RestoreTpl() won't be
able to restore the TPL to application level so it will still while loop in the
Poll.
BestRegards
Fu Siyuan
> -Original
Reviewed-by: Fu Siyuan
> -Original Message-
> From: Wu, Jiaxin
> Sent: Friday, March 2, 2018 2:43 PM
> To: edk2-devel@lists.01.org
> Cc: Fu, Siyuan ; Wang, Fan ; Ye,
> Ting
> Subject: [Patch] MdeModulePkg/Mtftp4Dxe: Separate the timer ticking to
> calcul
Reviewed-by: Fu Siyuan
> -Original Message-
> From: Wu, Jiaxin
> Sent: Monday, March 12, 2018 10:22 AM
> To: edk2-devel@lists.01.org
> Cc: Wang, Fan ; Fu, Siyuan ; Ye,
> Ting
> Subject: [Patch] MdeModulePkg/Mtftp4Dxe: Fix the incorrect return status.
>
> The
Reviewed-by: Fu Siyuan
> -Original Message-
> From: Wu, Jiaxin
> Sent: Monday, March 12, 2018 4:31 PM
> To: edk2-devel@lists.01.org
> Cc: Fu, Siyuan ; Ye, Ting
> Subject: [Patch 1/2] NetworkPkg/IScsiDxe: Fix the ISCSI connection failure
> in certain case.
>
>
Reviewed-by: Fu Siyuan
> -Original Message-
> From: Wu, Jiaxin
> Sent: Tuesday, March 20, 2018 9:10 AM
> To: edk2-devel@lists.01.org
> Cc: Fu, Siyuan ; Ye, Ting
> Subject: [Patch] NetworkPkg/UefiPxeBcDxe: Configure the ARP
> Instance/RouteTable with new address
&
Serials Reviewed-by: Fu Siyuan
> -Original Message-
> From: Wu, Jiaxin
> Sent: Tuesday, March 20, 2018 8:37 AM
> To: edk2-devel@lists.01.org
> Cc: Karunakar P ; Fu, Siyuan
> ; Ye, Ting
> Subject: [Patch 0/3] Support HTTP large data request via TLS channel.
>
escription of EFI_SIGNATURE_LIST structure.
BestRegards
Fu Siyuan
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Tuesday, March 20, 2018 10:56 PM
> To: Wu, Jiaxin ; Fu, Siyuan
> Cc: edk2-devel-01 ; Daniel P. Berrange
>
>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Fu Siyuan
Cc: Ye Ting
Cc: Wu Jiaxin
---
NetworkPkg/IScsiDxe/IScsiConfig.c | 16 ++--
1 file changed, 10 insertions(+), 6 deletions(-)
diff --git a/NetworkPkg/IScsiDxe/IScsiConfig.c
b/NetworkPkg/IScsiDxe
Reviewed-by: Fu Siyuan
-Original Message-
From: Wu, Hao A
Sent: Tuesday, September 19, 2017 10:12 AM
To: edk2-devel@lists.01.org
Cc: Wu, Hao A ; Fu, Siyuan ; Wu,
Jiaxin
Subject: [PATCH] NetworkPkg/IScsiDxe: Remove redundant call to StrLen
The commits ultilizes a local variable to
In NetbufTrim() function, the NetBuf TotalSize should be checked with 0 before
making the trim operation, otherwise the function will fall into infinite loop.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Fu Siyuan
Cc: Wu Jiaxin
Cc: Ye Ting
Cc: Michael Turner
Hi, Meenakshi
You are correct that it's a bug in SNP driver to print error information for
successfully transmitted packet. Please create a Bugzilla ticket for this issue
and we will follow it. Thanks.
BestRegards
Fu Siyuan
-Original Message-
From: edk2-devel [mailto:edk2-devel
#x27;s why the PXE
failed, but Cent OS could use IP address from the same DHCP server.
This is just an example, there may be some other places in edk2 network stack
which have the same assumption, I'm not sure about this. Anyway, we never
considered the point-2-point link in edk2.
BestRe
Hi, Karunakar
May I know that whether you have a real requirement that must use the
point-2-point link in your environment, or you just found this problem in your
test?
BestRegards
Fu Siyuan
From: Fu, Siyuan
Sent: Monday, September 25, 2017 3:50 PM
To: Karunakar P ; 'edk2-devel@lists.0
Reviewed-by: Fu Siyuan
-Original Message-
From: Meenakshi Aggarwal [mailto:meenakshi.aggar...@nxp.com]
Sent: Monday, September 25, 2017 11:06 PM
To: edk2-devel@lists.01.org; Ni, Ruiyu ; Carsey, Jaben
Cc: ard.biesheu...@linaro.org; leif.lindh...@linaro.org; Fu, Siyuan
; Ye, Ting
Reviewed-by: Fu Siyuan
-Original Message-
From: Gao, Liming
Sent: Monday, September 25, 2017 7:06 PM
To: edk2-devel@lists.01.org
Cc: Fu, Siyuan ; Wu, Jiaxin
Subject: [Patch 06/11] NetworkPkg: Update Protocol/Guid usage in INF file to
match source code logic
Contributed-under
Hi, Karunakar
We haven't received requirement for this feature before so we don't have plan
now. I think you can submit a Bugzilla ticket for this feature request, we will
follow up to investigate it.
BestRegards
Fu Siyuan
From: Karunakar P [mailto:karunak...@amiindia.co.in]
Se
Looks good to me.
Reviewed-by: Fu Siyuan
-Original Message-
From: Wu, Hao A
Sent: Thursday, September 28, 2017 12:32 PM
To: edk2-devel@lists.01.org
Cc: Wu, Hao A ; Shi, Steven ; Fu,
Siyuan ; Ye, Ting ; Wu, Jiaxin
; Long, Qin ; Zeng, Star
; Dong, Eric ; Paolo Bonzini
Subject
Reviewed-by: Fu Siyuan
-Original Message-
From: Wu, Jiaxin
Sent: Thursday, September 28, 2017 1:42 PM
To: edk2-devel@lists.01.org
Cc: Ye, Ting ; Fu, Siyuan ; Wu, Jiaxin
Subject: [Patch 0/2] Clarify the usage of HttpConfigData in HTTP protocol
Cc: Ye Ting
Cc: Fu Siyuan
Contributed
Reviewed-by: Fu Siyuan
-Original Message-
From: Wu, Jiaxin
Sent: Thursday, September 28, 2017 1:49 PM
To: edk2-devel@lists.01.org
Cc: Santhapur Naveen ; Ye, Ting ;
Fu, Siyuan ; Wu, Jiaxin
Subject: [Patch] NetworkPkg/UefiPxeBcDxe: Fix the redundant condition check
Cc: Santhapur
gt; (UINT32) (MTFTP4_DATA_HEAD_LEN + Instance->BlkSize)) ||
(Len < (UINT32) MTFTP4_DATA_HEAD_LEN)) {
goto ON_EXIT;
}
Status = Mtftp4RrqHandleData (Instance, Packet, Len, Multicast,
&Completed);
break;
BestRegards
Fu Siyuan
-Original Mess
Hi, Vabhav
Yes the IP layer should discard the whole packet if any frame is lost during
the transmit. Large TFTP blksize will reduce the the number of TFTP data/ack
packets, but add more overhead and risk of IP fragmentation and reassembly.
BestRegards
Fu Siyuan
-Original Message
applied to the
ShellPkg version in the past year. Users should use the standard version in
ShellPkg in future.
I will send out patch to remove the IfConfig6 and Ping6 applications in
NetworkPkg in next few days if no object to this email.
BestRegards
Fu Siyuan
Reviewed-by: Fu Siyuan
-Original Message-
From: Wu, Jiaxin
Sent: Friday, October 13, 2017 2:01 PM
To: edk2-devel@lists.01.org
Cc: Karunakar P ; Ye, Ting ; Fu,
Siyuan ; Wu, Jiaxin
Subject: [Patch] NetworkPkg/IScsiDxe: Display InitiatorInfo in attempt page
even DHCP enabled.
Cc
maintained in future.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Fu Siyuan
Cc: Wu Jiaxin
Cc: Ye Ting
---
NetworkPkg/Application/IfConfig6/IfConfig6.c | 1793
NetworkPkg/Application/IfConfig6/IfConfig6.h | 79 -
NetworkPkg/Application
Hi, Bruce
Thanks for your patch, and I think use "!=" looks better than a parentheses:)
if (SadData->Mode != EfiIPsecTunnel)
Reviewed-by: Fu Siyuan
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Bruce
Cran
Sent: Friday,
I can help to commit it:)
-Original Message-
From: Bruce Cran [mailto:br...@cran.org.uk]
Sent: Friday, July 17, 2015 1:16 PM
To: Fu, Siyuan; edk2-devel@lists.01.org
Subject: Re: [edk2] [PATCH] NetworkPkg: Fix bug in IpSecImpl.c caused by
missing parentheses
On 7/16/2015 11:14 PM, Fu
Reviewed-by: Fu Siyuan
-Original Message-
From: Wu, Jiaxin
Sent: Monday, July 20, 2015 10:31 AM
To: edk2-devel@lists.01.org
Cc: Fu, Siyuan; Ye, Ting
Subject: [PATCH v2] MdeModulePkg: Remove TransmitReceive() and ActiveChild
dependency
v2:
* Remove redundant IsTransmitReceive flag
Reviewed-by: Fu Siyuan
Please update the copyright year to 2015 when commit the patch.
-Original Message-
From: Zhang, Lubo
Sent: Monday, July 20, 2015 11:08 AM
To: Fu, Siyuan; Ye, Ting; edk2-devel@lists.01.org
Subject: [patch] MdeModulePkg: Fix the issue EfiPxeBcDhcp()may return
Reviewed-by: Fu Siyuan
Please update the copyright year to 2015 when commit the patch.
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Zhang
Lubo
Sent: Monday, July 20, 2015 11:08 AM
To: Fu, Siyuan; Ye, Ting; edk2-devel@lists.01.org
Subject
Hi, Michael
It's indeed a problem that NET_RANDOM (NetRandomInitSeed ()) may return same
value if the time service is not accuracy enough on some platform. And as you
said it's used to give unique but not necessarily to be real random number, so
I think we could just add some salt into the seed
-off-by: Fu Siyuan
---
MdeModulePkg/Include/Library/NetLib.h | 10 +-
MdeModulePkg/Library/DxeNetLib/DxeNetLib.c | 12
2 files changed, 13 insertions(+), 9 deletions(-)
diff --git a/MdeModulePkg/Include/Library/NetLib.h
b/MdeModulePkg/Include/Library/NetLib.h
index 7ad8dac
Patch is good, please remember to update the copyright year when commit it.
Reviewed-by: Fu Siyuan
-Original Message-
From: Zhang, Lubo
Sent: Tuesday, July 28, 2015 4:47 PM
To: edk2-devel@lists.01.org
Cc: Fu, Siyuan; Ye, Ting; Wu, Jiaxin
Subject: [patch] MdeModulePkg: Fix the issue
Reviewed-by: Fu Siyuan
-Original Message-
From: Wu, Jiaxin
Sent: Thursday, August 06, 2015 12:08 PM
To: edk2-devel@lists.01.org
Cc: Fu, Siyuan; Ye, Ting
Subject: [Patch] ShellPkg: Fix issue about ping fail with IPv4
Fix issue about ping fail with IPv4, which is caused by the
601 - 654 of 654 matches
Mail list logo
