Re: [edk2] [PATCH v2] MdeModulePkg/Core: Fix MaxAddress in Gcd

The GcdAllocateType are EfiGcdAllocateMaxAddress*, the MaxAddress comes from input BaseAddress parameter. The original code logic is correct according to PI spec. PI Spec: If GcdAllocateType is EfiGcdAllocateMaxAddressSearchBottomUp, then the GCD memory space map is searched from the lowest

Re: [edk2] [PATCH] MdeModulePkg/ConPlatform: Support short-form USB device path

...@intel.com>; Kinney, Michael D <michael.d.kin...@intel.com>; Zeng, Star <star.z...@intel.com> Subject: [PATCH] MdeModulePkg/ConPlatform: Support short-form USB device path Today's implementation does an exact device path match to check whether the device path of a conso

Re: [edk2] [PATCH v2] MdeModulePkg/Core: Fix MaxAddress in Gcd

Glad to know you found the way. :) Thanks, Star -Original Message- From: Roman Bacik [mailto:roman.ba...@broadcom.com] Sent: Friday, May 4, 2018 12:12 AM To: Zeng, Star <star.z...@intel.com>; edk2-devel@lists.01.org Cc: Ni, Ruiyu <ruiyu...@intel.com>; Vladimir

Re: [edk2] [PATCH] MdeModulePkg/AtaAtapiPassThru: disable only BM-DMA at ExitBootServices()

rg> Cc: Aleksei Kovura <alex3...@zoho.com>; Ard Biesheuvel <ard.biesheu...@linaro.org>; Dann Frazier <da...@ubuntu.com>; Dong, Eric <eric.d...@intel.com>; Zeng, Star <star.z...@intel.com> Subject: [PATCH] MdeModulePkg/AtaAtapiPassThru: disable only BM-DMA at Exi

Re: [edk2] Xen Console input very slow in recent UEFI

== Thanks, Star -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Julien Grall Sent: Friday, October 27, 2017 2:32 AM To: Laszlo Ersek <ler...@redhat.com>; edk2-devel-01 <edk2-devel@lists.01.org>; Zeng, Star <star.z...@

Re: [edk2] [PATCH V2 2/2] IntelSiliconPkg/VtdPeiSample: Add premem support.

Another comment. sizeof(MY_VTD_INFO_PPI) is used in mPlatformVTdNoIgdSample, that seems wrong and should be sizeof(MY_VTD_INFO_NO_IGD_PPI), right? Why it does not cause problem with the code. Thanks, Star -Original Message- From: Zeng, Star Sent: Friday, October 27, 2017 2:56 PM

Re: [edk2] [PATCH V2 1/2] IntelSiliconPkg/VtdPmrPei: Add premem support.

Reviewed-by: Star Zeng <star.z...@intel.com> -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jiewen Yao Sent: Friday, October 27, 2017 1:40 PM To: edk2-devel@lists.01.org Cc: Zeng, Star <star.z...@intel.com> Subject: [edk2] [

Re: [edk2] [PATCH V2 2/2] IntelSiliconPkg/VtdPeiSample: Add premem support.

ilto:edk2-devel-boun...@lists.01.org] On Behalf Of Jiewen Yao Sent: Friday, October 27, 2017 1:41 PM To: edk2-devel@lists.01.org Cc: Zeng, Star <star.z...@intel.com> Subject: [edk2] [PATCH V2 2/2] IntelSiliconPkg/VtdPeiSample: Add premem support. Before memory is ready, this sample produces on

Re: [edk2] [PATCH 2/4] MdeModulePkg/Core: Coding style clean-up

Reviewed-by: Star Zeng <star.z...@intel.com> -Original Message- From: Wang, Jian J Sent: Monday, December 25, 2017 9:07 AM To: edk2-devel@lists.01.org Cc: Bi, Dandan <dandan...@intel.com>; Zeng, Star <star.z...@intel.com>; Dong, Eric <eric.d...@intel.com

Re: [edk2] [patch] MdeModulePkg/VarCheckHii: Update data type for variable "ArrayIndex"

Reviewed-by: Star Zeng <star.z...@intel.com> Thanks, Star -Original Message- From: Bi, Dandan Sent: Tuesday, January 9, 2018 3:25 PM To: edk2-devel@lists.01.org Cc: Zeng, Star <star.z...@intel.com>; Gao, Liming <liming@intel.com> Subject: [patch] MdeModulePkg/VarChe

Re: [edk2] Memory space entry is not removed after calling FreeMemorySpace and RemoveMemorySpace

nction, it will call original GetMemoryMap() function, and then append one entry for the memory space you want to add for OS kernel. Thanks, Star -Original Message- From: Wasim Khan [mailto:wasim.k...@nxp.com] Sent: Monday, January 8, 2018 3:03 AM To: Zeng, Star <star.z...@intel.com>

Re: [edk2] [RFC] SATA : Implemented NXP errata A008402

error, 3F_h is misinterpreted by the device as zero length." Thanks, Star -Original Message- From: Meenakshi Aggarwal [mailto:meenakshi.aggar...@nxp.com] Sent: Monday, January 8, 2018 2:26 PM To: Zeng, Star <star.z...@intel.com>; ard.biesheu...@linaro.org; leif.lindh...@linaro

Re: [edk2] [RFC] define PCD for EFI_AHCI_MAX_DATA_PER_PRDT

Cc Ray for any comments. Thanks, Star -Original Message- From: Meenakshi Aggarwal [mailto:meenakshi.aggar...@nxp.com] Sent: Monday, January 8, 2018 7:17 PM To: ard.biesheu...@linaro.org; leif.lindh...@linaro.org; edk2-devel@lists.01.org; Zeng, Star <star.z...@intel.com>; Dong

Re: [edk2] [RFC] SATA : Implemented NXP errata A008402

...@linaro.org; leif.lindh...@linaro.org; edk2-devel@lists.01.org; Zeng, Star <star.z...@intel.com>; Dong, Eric <eric.d...@intel.com> Subject: [edk2] [RFC] SATA : Implemented NXP errata A008402 Description: Commands with 4 MB PRD length entries fail if PRD[DBC] is set to the value accor

Re: [edk2] [Patch 3/7] MdeModulePkg: Update DebugSupportDxe to pass XCODE5 build

Reviewed-by: Star Zeng <star.z...@intel.com> Thanks, Star -Original Message- From: Gao, Liming Sent: Wednesday, January 10, 2018 11:24 PM To: edk2-devel@lists.01.org Cc: Andrew Fish <af...@apple.com>; Zeng, Star <star.z...@intel.com> Subject: [Patch 3/7] Md

Re: [edk2] Communicate with soft-smi-handler with uefi-application question.

The trusted smm communication buffer needs to be allocated as EfiReservedMemoryType, EfiACPIMemoryNVS, or EfiRuntimeServicesData before EndOfDxe. There is a generic smm communication buffer can be used if MdeModulePkg\Universal\SmmCommunicationBufferDxe is included in dsc and fdf. You can

Re: [edk2] Memory space entry is not removed after calling FreeMemorySpace and RemoveMemorySpace

PI spec has clear description below in AddMemorySpace(). "If the memory range specified by BaseAddress and Length is of type EfiGcdMemoryTypeSystemMemory or EfiGcdMemoryTypeMoreReliable, then the memory range may be *automatically allocated for use by the UEFI memory services*." But PI spec

Re: [edk2] [RFC] SATA : Implemented NXP errata A008402

How will the code work based on your patch if the this PCD is configured to other value, for example 0x20/0x30? Thanks, Star -Original Message- From: Meenakshi Aggarwal [mailto:meenakshi.aggar...@nxp.com] Sent: Monday, January 8, 2018 5:54 PM To: Zeng, Star <star.z...@intel.

Re: [edk2] Memory space entry is not removed after calling FreeMemorySpace and RemoveMemorySpace

ar -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Wasim Khan Sent: Monday, January 8, 2018 8:48 PM To: Zeng, Star <star.z...@intel.com>; edk2-devel@lists.01.org Cc: Gao, Liming <liming@intel.com> Subject: Re: [edk2] Memory spac

Re: [edk2] [PATCH 3/3] MdeModulePkg/FrameBufferBltLib: Fix copying of unaligned memory

Reviewed-by: Star Zeng <star.z...@intel.com> Thanks, Star -Original Message- From: Ni, Ruiyu Sent: Monday, January 15, 2018 11:46 AM To: edk2-devel@lists.01.org Cc: Christian Ehrhardt <ehrha...@genua.de>; Zeng, Star <star.z...@intel.com> Subject: [PATCH

Re: [edk2] [PATCH 2/3] MdeModulePkg/FrameBufferBltLib: Fix a bug causing display corrupted

Reviewed-by: Star Zeng <star.z...@intel.com> Thanks, Star -Original Message- From: Ni, Ruiyu Sent: Monday, January 15, 2018 11:46 AM To: edk2-devel@lists.01.org Cc: Christian Ehrhardt <ehrha...@genua.de>; Zeng, Star <star.z...@intel.com> Subject: [PATCH

Re: [edk2] [PATCH] MdeModulePkg/UsbStorage: Fix "map -r" cannot detect media change

Reviewed-by: Star Zeng <star.z...@intel.com> Thanks, Star -Original Message- From: Ni, Ruiyu Sent: Friday, January 19, 2018 3:05 PM To: edk2-devel@lists.01.org Cc: Tian, Feng <feng.t...@intel.com>; Zeng, Star <star.z...@intel.com> Subject: [PATCH] MdeModulePkg/UsbSt

Re: [edk2] [PATCH] CryptoPkg/BaseCryptLib: Add error handling for time() wrapper

What will happen if Time.Year == 1970? :) Thanks, Star -Original Message- From: Long, Qin Sent: Friday, January 19, 2018 3:05 PM To: edk2-devel@lists.01.org Cc: Zeng, Star <star.z...@intel.com>; Ye, Ting <ting...@intel.com>; Long, Qin <qin.l...@intel.com> Subject:

Re: [edk2] [PATCH] CryptoPkg/BaseCryptLib: Add error handling for time() wrapper

Ok, got it. Reviewed-by: Star Zeng <star.z...@intel.com> Thanks, Star -Original Message- From: Long, Qin Sent: Friday, January 19, 2018 3:12 PM To: Zeng, Star <star.z...@intel.com>; edk2-devel@lists.01.org Cc: Ye, Ting <ting...@intel.com> Subject: RE: [PATCH] CryptoPkg

Re: [edk2] [Patch] UefiCpuPkg: Update package version.

Reviewed-by: Star Zeng <star.z...@intel.com> Thanks, Star -Original Message- From: Dong, Eric Sent: Monday, January 22, 2018 10:01 AM To: edk2-devel@lists.01.org Cc: Zeng, Star <star.z...@intel.com>; Ni, Ruiyu <ruiyu...@intel.com> Subject: [Patch] UefiCpuPkg: Update pa

Re: [edk2] [PATCH 0/2] Install PciEnumerationComplete after PciIo

Reviewed-by: Star Zeng Thanks, Star -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ruiyu Ni Sent: Monday, January 22, 2018 2:24 PM To: edk2-devel@lists.01.org Subject: [edk2] [PATCH 0/2] Install PciEnumerationComplete after

Re: [edk2] [PATCH] UefiCpuPkg/PeiMpLib: Fix a system hang-in-pei issue.

ong, Eric <eric.d...@intel.com>; Zeng, Star <star.z...@intel.com> Subject: [PATCH] UefiCpuPkg/PeiMpLib: Fix a system hang-in-pei issue. When HOB contains a system memory resource which is above 4GB, the (UINTN) typecast truncates the high-32 bits. It causes a memory range above 4GB be

Re: [edk2] [PATCH] MdeModulePkg/NvmExpressDxe: Fix data buffer not mapped for Write cmd

Reviewed-by: Star Zeng <star.z...@intel.com> Is it ok to do more test, for example with SCT? Thanks, Star -Original Message- From: Wu, Hao A Sent: Tuesday, January 23, 2018 1:04 PM To: edk2-devel@lists.01.org Cc: Wu, Hao A <hao.a...@intel.com>; Zeng, Star <star.z...

Re: [edk2] [PATCH] UefiCpuPkg/MpInitLib: Make sure AP uses correct StartupApSignal

Reviewed-by: Star Zeng <star.z...@intel.com> -Original Message- From: Ni, Ruiyu Sent: Thursday, January 25, 2018 3:37 PM To: edk2-devel@lists.01.org Cc: Zeng, Star <star.z...@intel.com>; Chiu, Chasel <chasel.c...@intel.com> Subject: [PATCH] UefiCpuPkg/MpInitLib: Make su

Re: [edk2] [PATCH v2] PcAtChipsetPkg: Add PeiAcpiTimerLib to save PerformanceCounterFrequency in HOB

sage- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming Gao Sent: Tuesday, January 23, 2018 10:24 AM To: edk2-devel@lists.01.org Cc: Zeng, Star <star.z...@intel.com> Subject: [edk2] [PATCH v2] PcAtChipsetPkg: Add PeiAcpiTimerLib to save PerformanceCounterFr

Re: [edk2] [Patch 1/3] MdeModulePkg/EsrtFmpDxe: Add EsrtFmpDxe module

intel.com>; Kinney, Michael D <michael.d.kin...@intel.com>; Zeng, Star <star.z...@intel.com> Subject: [edk2] [Patch 1/3] MdeModulePkg/EsrtFmpDxe: Add EsrtFmpDxe module From: Michael D Kinney <michael.d.kin...@intel.com> https://bugzilla.tianocore.org/show_bug.cgi?id=802 Bas

Re: [edk2] [PATCH] MdePkg/DMAR: Add the definition for DMA_CTRL_PLATFORM_OPT_IN_FLAG bit

ursday, January 18, 2018 10:03 AM To: edk2-devel@lists.01.org Cc: Wu, Hao A <hao.a...@intel.com>; Zeng, Star <star.z...@intel.com>; Yao, Jiewen <jiewen@intel.com>; Kinney, Michael D <michael.d.kin...@intel.com>; Gao, Liming <liming@intel.com> Subject: [PA

Re: [edk2] [PATCH] MdeModulePkg/Core: fix a logic hole in page free

Reviewed-by: Star Zeng <star.z...@intel.com> Thanks, Star -Original Message- From: Wang, Jian J Sent: Thursday, January 18, 2018 3:39 PM To: edk2-devel@lists.01.org Cc: Ni, Ruiyu <ruiyu...@intel.com>; Dong, Eric <eric.d...@intel.com>; Zeng, Star <star.z...@intel

Re: [edk2] [PATCH 6/6] MdeModulePkg/BootScriptExecutorDxe: remove NX attr for FfsBuffer

Reviewed-by: Star Zeng <star.z...@intel.com> -Original Message- From: Wang, Jian J Sent: Monday, January 15, 2018 4:55 PM To: edk2-devel@lists.01.org Cc: Yao, Jiewen <jiewen@intel.com>; Ni, Ruiyu <ruiyu...@intel.com>; Dong, Eric <eric.d...@intel.com>; Zeng, S

Re: [edk2] [PATCH 5/6] MdeModulePkg/PiSmmCore: remove NX attr for SMM RAM

Reviewed-by: Star Zeng <star.z...@intel.com> -Original Message- From: Wang, Jian J Sent: Monday, January 15, 2018 4:55 PM To: edk2-devel@lists.01.org Cc: Yao, Jiewen <jiewen@intel.com>; Ni, Ruiyu <ruiyu...@intel.com>; Dong, Eric <eric.d...@intel.com>; Zeng, S

Re: [edk2] [PATCH] MdeModulePkg/EhciDxe: call EhcFreeUrb when int-transfer completes

Reviewed-by: Star Zeng <star.z...@intel.com> Thanks, Star -Original Message- From: Ni, Ruiyu Sent: Monday, January 15, 2018 4:24 PM To: edk2-devel@lists.01.org Cc: Zeng, Star <star.z...@intel.com> Subject: [PATCH] MdeModulePkg/EhciDxe: call EhcFreeUrb when int-transfe

Re: [edk2] [patch 0/3] Remove the useless pref codes

To: edk2-devel@lists.01.org Cc: Ni, Ruiyu <ruiyu...@intel.com>; Zeng, Star <star.z...@intel.com>; Laszlo Ersek <ler...@redhat.com>; Dong, Eric <eric.d...@intel.com>; Gao, Liming <liming@intel.com> Subject: [edk2] [patch 0/3] Remove the useless pref codes Our new

Re: [edk2] [Patch 1/2] MdeModulePkg DxeIpl: remove the hard code alignment adjustment.

Ok, Reviewed-by: Star Zeng <star.z...@intel.com> Thanks, Star -Original Message- From: Gao, Liming Sent: Wednesday, January 10, 2018 1:40 PM To: Zeng, Star <star.z...@intel.com>; edk2-devel@lists.01.org Subject: RE: [Patch 1/2] MdeModulePkg DxeIpl: remove the hard co

Re: [edk2] [Patch] MdeModulePkg DxeIpl: remove the hard code alignment adjustment in Decompress()

Reviewed-by: Star Zeng <star.z...@intel.com> Thanks, Star -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming Gao Sent: Wednesday, January 10, 2018 1:46 PM To: edk2-devel@lists.01.org Cc: Zeng, Star <star.z...@intel.com> Su

Re: [edk2] [Patch 2/2] MdeModulePkg SectionExtractionPei: remove the hard code alignment adjustment

Reviewed-by: Star Zeng <star.z...@intel.com> Thanks, Star -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming Gao Sent: Wednesday, January 10, 2018 1:34 PM To: edk2-devel@lists.01.org Cc: Zeng, Star <star.z...@intel.com> Subject: [

Re: [edk2] [Patch 1/2] MdeModulePkg DxeIpl: remove the hard code alignment adjustment.

Liming, Similar change should be also done in Decompress() of DxeLoad.c, right? Thanks, Star -Original Message- From: Gao, Liming Sent: Wednesday, January 10, 2018 1:33 PM To: edk2-devel@lists.01.org Cc: Zeng, Star <star.z...@intel.com> Subject: [Patch 1/2] MdeModulePkg DxeIpl:

Re: [edk2] [PATCH] UefiCpuPkg PiSmmCpuDxeSmm: Fixed #double fault on #page fault for IA32

Yes, right. Patch for that case is on the way. Thanks, Star -Original Message- From: Yao, Jiewen Sent: Friday, January 12, 2018 3:59 PM To: Zeng, Star <star.z...@intel.com>; edk2-devel@lists.01.org Cc: Wang, Jian J <jian.j.w...@intel.com>; Dong, Eric <eric.d...@intel.com&

Re: [edk2] [PATCH edk2/MdePkg v1] MdePkg ACPI: Correct processor struct of PPTT

Just pushed the patch at 19ef86eec6ed67c11b6a942865b143123180d394 with Liming's and my RB. Thanks, Star -Original Message- From: Gao, Liming Sent: Tuesday, January 30, 2018 5:06 PM To: Zeng, Star <star.z...@intel.com>; Heyi Guo <heyi@linaro.org>; leif.lindh...@linaro.o

Re: [edk2] [PATCH v2 1/8] MdeModulePkg:Add definitions for new Performance infrastructure

A minor comment. Do you think is it better to add prefix for new definitions in ExtendedFirmwarePerformance.h? Maybe FPDT_ ? Thanks, Star -Original Message- From: Bi, Dandan Sent: Tuesday, January 30, 2018 9:54 PM To: edk2-devel@lists.01.org Cc: Gao, Liming <liming@intel.com>

Re: [edk2] [PATCH] IntelSiliconPkg/MicrocodeUpdateDxe: Refine debug messages

mments handled, Reviewed-by: Star Zeng <star.z...@intel.com> Thanks, Star -Original Message- From: Wu, Hao A Sent: Thursday, January 25, 2018 10:19 AM To: edk2-devel@lists.01.org Cc: Wu, Hao A <hao.a...@intel.com>; Yao, Jiewen <jiewen@intel.com>; Zeng, Star <star.z...@int

Re: [edk2] [PATCH] MdeModulePkg/SmmCore: Fix hang due to already-freed memory deference

devel@lists.01.org Cc: Yao, Jiewen <jiewen@intel.com>; Zeng, Star <star.z...@intel.com> Subject: [PATCH] MdeModulePkg/SmmCore: Fix hang due to already-freed memory deference SmiHandlerUnRegister() validates the DispatchHandle by checking whether the first 32bit matches to a ce

Re: [edk2] [Patch 1/1] MdePkg/UefiLib: Add EfiLocateProtocolBuffer()

Hi Mike, UefiLib is capable to be used by SMM Core or SMM driver before SmmReadyToLock. And the new interface has the comment below. +The returned buffer is allocated using +EFI_BOOT_SERVICES.AllocatePool(). The caller is +

Re: [edk2] [PATCH v4 0/2] quirks handling for SDHCI controllers

Reviewed-by: Star Zeng <star.z...@intel.com> Thanks Hao's investigation and Ard's contribution. Star -Original Message- From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] Sent: Monday, January 29, 2018 4:26 PM To: Wu, Hao A <hao.a...@intel.com>; Zeng, Star <star

Re: [edk2] [PATCH 2/6] MdeModulePkg/ConSplitter: ReadKeyStrokeEx always return key state

Sent: Monday, January 22, 2018 4:10 PM To: edk2-devel@lists.01.org Cc: Zeng, Star <star.z...@intel.com>; Kinney, Michael D <michael.d.kin...@intel.com> Subject: [PATCH 2/6] MdeModulePkg/ConSplitter: ReadKeyStrokeEx always return key state Today's implementation only return key state

Re: [edk2] [Patch 1/1] MdePkg/UefiLib: Add EfiLocateProtocolBuffer()

- From: Kinney, Michael D Sent: Thursday, February 1, 2018 10:07 AM To: Zeng, Star <star.z...@intel.com>; edk2-devel@lists.01.org; Kinney, Michael D <michael.d.kin...@intel.com> Cc: Yao, Jiewen <jiewen@intel.com>; Gao, Liming <liming@intel.com> Subject: RE: [edk

Re: [edk2] [PATCH edk2/MdePkg v1] MdePkg ACPI: Correct processor flags struct of PPTT

The change looks good to me, Reviewed-by: Star Zeng . But the title seems not so correct. It is about EFI_ACPI_6_2_PPTT_STRUCTURE_PROCESSOR, but not EFI_ACPI_6_2_PPTT_STRUCTURE_PROCESSOR_FLAGS. How about to refine the title? Thanks, Star -Original Message- From:

Re: [edk2] [PATCH edk2/MdePkg v1] MdePkg ACPI: Correct processor struct of PPTT

Reviewed-by: Star Zeng Thanks, Star -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Heyi Guo Sent: Tuesday, January 30, 2018 1:52 PM To: leif.lindh...@linaro.org; linaro-u...@lists.linaro.org; edk2-devel@lists.01.org;

Re: [edk2] [PATCH edk2/MdePkg v1] MdePkg ACPI: Add some macros for PPTT

How about using EFI_ACPI_6_2_PPTT_PROCESSOR_ID_XXX to be more specific? Others are good to me. Thanks, Star -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Heyi Guo Sent: Friday, February 2, 2018 11:30 AM To: leif.lindh...@linaro.org;

Re: [edk2] [PATCH 10/10] MdeModulePkg/ResetSystemPei: Add reset notifications in PEI

On 2018/2/7 20:40, Zeng, Star wrote: On 2018/2/2 14:45, Ruiyu Ni wrote: From: Bret Barkelew <brbar...@microsoft.com> The Reset Notification protocol is added in UEFI spec to support reset notification mechanism in the DXE phase. This patch adds similar EDKII specific Reset Notificati

Re: [edk2] [PATCH 07/10] MdeModulePkg: Add ResetUtility librray class and BASE instance

in" only? Thanks, Star On 2018/2/8 9:36, Zeng, Star wrote: Another minor comments is to remove below sentences in ResetUtilityLib.inf. > +#  The application pops up a menu showing all the boot options referenced by > +#  BootOrder NV variable and user can choose to boot from one of

Re: [edk2] [PATCH 07/10] MdeModulePkg: Add ResetUtility librray class and BASE instance

Another minor comments is to remove below sentences in ResetUtilityLib.inf. > +# The application pops up a menu showing all the boot options referenced by > +# BootOrder NV variable and user can choose to boot from one of them. Thanks, Star On 2018/2/7 20:28, Zeng, Star wrote: On

Re: [edk2] [PATCH 09/10] MdeModulePkg: Add ResetSystemPei PEIM

EFI_SW_PS_PC_RESET_SYSTEM)); 3. We need update MdeModulePkg.uni for the new PCD PcdMaximumPeiResetNotifies accordingly. Thanks, Star On 2018/2/7 20:35, Zeng, Star wrote: On 2018/2/2 14:45, Ruiyu Ni wrote: This driver implements Reset2, ResetFilter and ResetHandler PPIs. Cc: Liming Gao

Re: [edk2] [Patch 01/10] MdeModulePkg: Add BmpSupportLib class and instance

Jiewen <jiewen....@intel.com>; Zeng, Star <star.z...@intel.com>; Dong, Eric <eric.d...@intel.com>; Ni, Ruiyu <ruiyu...@intel.com>; Kinney, Michael D <michael.d.kin...@intel.com> Subject: [Patch 01/10] MdeModulePkg: Add BmpSupportLib class and instance https://bugz

Re: [edk2] [Patch] MdeModulePkg/DxeCapsuleLibFmp: Verify nested capsule with FMP

Reviewed-by: Star Zeng <star.z...@intel.com> Thanks, Star -Original Message- From: Yao, Jiewen Sent: Thursday, February 8, 2018 8:18 AM To: Kinney, Michael D <michael.d.kin...@intel.com>; edk2-devel@lists.01.org Cc: Zeng, Star <star.z...@intel.com>; Dong, Eric &l

Re: [edk2] [Patch V2 1/3] MdeModulePkg/EsrtFmpDxe: Add EsrtFmpDxe module

ao, Jiewen <jiewen....@intel.com>; Zeng, Star <star.z...@intel.com>; Dong, Eric <eric.d...@intel.com>; Ni, Ruiyu <ruiyu...@intel.com> Subject: [Patch V2 1/3] MdeModulePkg/EsrtFmpDxe: Add EsrtFmpDxe module From: Michael D Kinney <michael.d.kin...@intel.com> https://b

Re: [edk2] [Patch] MdeModulePkg PeiCore: Add error message to describe PEIM load failure

else { + // + // Print FFS GUID when PDB not found. + // + DEBUG ((EFI_D_INFO | EFI_D_LOAD, "%g", FileHandle)); } DEBUG_CODE_END (); Thanks, Star -Original Message- From: Gao, Liming Sent: Thursday, February 8, 2018 4:19 PM To: edk2-devel@lists

Re: [edk2] [Patch] MdeModulePkg PeiCore: Add error message to describe PEIM load failure

How about combining it to one for DXE? Either print FFS GUID or file name from PDB path, or both. Thanks, Star -Original Message- From: Gao, Liming Sent: Thursday, February 8, 2018 6:25 PM To: Zeng, Star <star.z...@intel.com>; edk2-devel@lists.01.org Subject: RE: [Patch] MdeMod

Re: [edk2] [PATCH v2 00/10] Formalize the reset system core design

Thanks for the new version patch series. With minor comments (I provided to V1) handled, Reviewed-by: Star Zeng to the patch series. :) For patch 007: "@param[in] ResetType Base reset type as defined in UEFI spec." needs to be removed in ResetUtilityLib.h For patch

Re: [edk2] [Patch V2 0/3] MdePkg/UefiLib: Add EfiLocateProtocolBuffer()

Reviewed-by: Star Zeng to the patch series. Thanks, Star -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Kinney, Michael D Sent: Saturday, February 3, 2018 9:07 AM To: edk2-devel@lists.01.org Cc: Kinney, Michael D

Re: [edk2] [PATCH edk2/MdePkg v2] MdePkg ACPI: Add some macros for PPTT

Pushed at c4e75574a0c7d3ef97be8e18f261298b34e77065. Thanks, Star -Original Message- From: Gao, Liming Sent: Wednesday, February 7, 2018 8:51 AM To: Zeng, Star <star.z...@intel.com>; Heyi Guo <heyi@linaro.org>; leif.lindh...@linaro.org; linaro-u...@lists.linaro.org; edk2

Re: [edk2] [patch] MdeModulePkg/PciBusDxe: Fix VS2012 build failure

2018 9:31 AM To: edk2-devel@lists.01.org Cc: Zeng, Star <star.z...@intel.com>; Ni, Ruiyu <ruiyu...@intel.com> Subject: [patch] MdeModulePkg/PciBusDxe: Fix VS2012 build failure Initialize local variable to suppress warning C4703: potentially uninitialized local pointer variable. Cc:

Re: [edk2] [PATCH] MdeModulePkg/BmpSupportLib: Refine type cast for pointer subtraction

.bro...@microsoft.com>; Yao, Jiewen <jiewen@intel.com>; Zeng, Star <star.z...@intel.com>; Dong, Eric <eric.d...@intel.com>; Ni, Ruiyu <ruiyu...@intel.com> Subject: [PATCH] MdeModulePkg/BmpSupportLib: Refine type cast for pointer subtraction Since the point

Re: [edk2] [PATCH 3/4] MdeModulePkg/UefiBootManagerLib: remove superfluous TimerLib dependency

aben.car...@intel.com>; Ni, Ruiyu <ruiyu...@intel.com>; Zeng, Star <star.z...@intel.com> Subject: [PATCH 3/4] MdeModulePkg/UefiBootManagerLib: remove superfluous TimerLib dependency In commit 3a039a567a5f ("MdeModulePkg/UefiBootManagerLib: Remove the useless perf codes", 2

Re: [edk2] [PATCH] MdeModulePkg/UsbMass: Fix hot-plug USB CDROM can't be recognized

Reviewed-by: Star Zeng <star.z...@intel.com> Thanks, Star -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ruiyu Ni Sent: Tuesday, February 13, 2018 3:22 PM To: edk2-devel@lists.01.org Cc: Tian, Feng <feng.t...@intel.com>; Zeng,

Re: [edk2] [PATCH] MdeModulePkg/ResetUtilityLib: Fix GCC build failure

Reviewed-by: Star Zeng Thanks, Star -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ruiyu Ni Sent: Tuesday, February 13, 2018 11:03 AM To: edk2-devel@lists.01.org Cc: Bi, Dandan Subject: [edk2] [PATCH]

Re: [edk2] [PATCH v2 0/7] Remove the useless pref codes

m>; Laszlo Ersek <ler...@redhat.com>; Zeng, Star <star.z...@intel.com>; Wei, David <david@intel.com> Subject: [edk2] [PATCH v2 0/7] Remove the useless pref codes V2: a. Remove defintions related to old perf code and clean all useless perf codes in edk2 code base. b.U

Re: [edk2] [PATCH edk2/MdePkg v1] MdePkg ACPI: Add some macros for PPTT

I mean +#define EFI_ACPI_6_2_PPTT_PROCESSOR_ID_INVALID0x0 +#define EFI_ACPI_6_2_PPTT_PROCESSOR_ID_VALID 0x1 Thanks, Star -Original Message- From: Huangming (Mark) [mailto:huangmin...@huawei.com] Sent: Tuesday, February 6, 2018 2:12 PM To: Zeng, Star <sta

Re: [edk2] [Patch] MdeModulePkg: Don't build VarCheckUefiLib and DxeCore for EBC arch

Sent: Tuesday, February 6, 2018 3:00 PM To: Zeng, Star <star.z...@intel.com>; edk2-devel@lists.01.org Subject: RE: [edk2] [Patch] MdeModulePkg: Don't build VarCheckUefiLib and DxeCore for EBC arch Star: I don't know why only VariableRuntimeDxe and EmuVariableRuntimeDxe are in [Com

Re: [edk2] [Patch] MdeModulePkg: Don't build VarCheckUefiLib and DxeCore for EBC arch

Liming, Moving VarCheckUefiLib to be separated with VariableRuntimeDxe is strange to me. It is not just for build, and also to demonstrate how is the library linked with VariableRuntimeDxe. And why only VariableRuntimeDxe and EmuVariableRuntimeDxe are put in [Components.IA32, Components.X64,

Re: [edk2] [PATCH] MdeModulePkg/PiSmmCore: add API parameter check

Reviewed-by: Star Zeng <star.z...@intel.com> Thanks, Star -Original Message- From: Wang, Jian J Sent: Tuesday, February 6, 2018 1:14 PM To: edk2-devel@lists.01.org Cc: Zeng, Star <star.z...@intel.com>; Dong, Eric <eric.d...@intel.com> Subject: [PATCH] MdeModulePkg/

Re: [edk2] [PATCH edk2/MdePkg v2] MdePkg ACPI: Add some macros for PPTT

Reviewed-by: Star Zeng Thanks, Star -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Heyi Guo Sent: Tuesday, February 6, 2018 2:42 PM To: leif.lindh...@linaro.org; linaro-u...@lists.linaro.org; edk2-devel@lists.01.org;

Re: [edk2] [PATCH 01/10] MdePkg/PeiServicesLib: Add PeiServicesResetSystem2()

On 2018/2/2 14:45, Ruiyu Ni wrote: From: Michael D Kinney Add the PeiServicesResetSytstem2() function to the PeiServiesLib to call the ResetSystem2() services in the PEI Services Table. Cc: Liming Gao Cc: Ruiyu Ni

Re: [edk2] [PATCH 02/10] MdeModulePkg/PeiMain: Always attempt to use Reset2 PPI first

On 2018/2/2 14:45, Ruiyu Ni wrote: From: Michael D Kinney Update PEI Service ResetSystem() to always attempt to use the Reset2 PPI before looking for the Reset PPI. Cc: Liming Gao Reviewed-by: Ruiyu Ni Cc: Star Zeng

Re: [edk2] [PATCH 03/10] MdeModulePkg/PeiMain: Cleanup whitespace in Reset.c

On 2018/2/2 14:45, Ruiyu Ni wrote: From: Michael D Kinney Cc: Liming Gao Reviewed-by: Ruiyu Ni Cc: Star Zeng Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Michael D Kinney

Re: [edk2] [PATCH 04/10] MdeModulePkg/ResetSystemRuntimeDxe: Add platform filter and handler

Some minor comments added below except Laszlo's. With them handled, Reviewed-by: Star Zeng On 2018/2/2 14:45, Ruiyu Ni wrote: From: Michael D Kinney Add support for platform specific reset filters and platform specific reset handlers to

Re: [edk2] [PATCH 08/10] MdePkg/UefiRuntimeLib: Support more module types.

On 2018/2/2 14:45, Ruiyu Ni wrote: Because DxeResetSystemLib links to this library to provide reset system services, change UefiRuntimeLib to support the same set of module types as what DxeResetSystemLib does. Cc: Liming Gao Cc: Michael D Kinney

Re: [edk2] [PATCH 10/10] MdeModulePkg/ResetSystemPei: Add reset notifications in PEI

On 2018/2/2 14:45, Ruiyu Ni wrote: From: Bret Barkelew The Reset Notification protocol is added in UEFI spec to support reset notification mechanism in the DXE phase. This patch adds similar EDKII specific Reset Notification PPI to PEI phase to provide the same support.

Re: [edk2] [PATCH 07/10] MdeModulePkg: Add ResetUtility librray class and BASE instance

On 2018/2/2 14:45, Ruiyu Ni wrote: From: Michael D Kinney The library class that provides services to generate a GUID specific reset, parse the GUID from a GUID specific reset, and build the ResetData buffer for any type of reset that requires extra data. Cc:

Re: [edk2] [PATCH 09/10] MdeModulePkg: Add ResetSystemPei PEIM

On 2018/2/2 14:45, Ruiyu Ni wrote: This driver implements Reset2, ResetFilter and ResetHandler PPIs. Cc: Liming Gao Cc: Michael D Kinney Cc: Star Zeng Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by:

Re: [edk2] [PATCH 06/10] MdeModulePkg: Add ResetSystemLib instances that call core services

On 2018/2/2 14:45, Ruiyu Ni wrote: From: Michael D Kinney Add a PEI instance of ResetSystemLib that calls the ResetSystem2() service in the PEI Services Table. Add a DXE instance of ResetSystemLib that calls the ResetSystem() service in the UEFI Runtime Services

Re: [edk2] [PATCH 05/10] MdeModulePkg/ResetSystemRuntimeDxe: Add more debug message

On 2018/2/2 14:45, Ruiyu Ni wrote: The patch adds more debug message in ResetSystem(). It also removes unnecessary check of mResetNotifyDepth. Cc: Liming Gao Cc: Michael D Kinney Cc: Star Zeng Contributed-under: TianoCore

Re: [edk2] [PATCH] MdeModulePkg/PlatformLogo.h: Correct function header comments

Reviewed-by: Star Zeng <star.z...@intel.com> Thanks, Star -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ruiyu Ni Sent: Saturday, February 24, 2018 3:47 PM To: edk2-devel@lists.01.org Cc: Zeng, Star <star.z...@intel.com> Subject: [

Re: [edk2] [PATCH] MdeModulePkg/Logo.idf: Remove incorrect comments.

Reviewed-by: Star Zeng <star.z...@intel.com> Thanks, Star -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ruiyu Ni Sent: Saturday, February 24, 2018 4:05 PM To: edk2-devel@lists.01.org Cc: Zeng, Star <star.z...@intel.com> Subject: [

Re: [edk2] [PATCH] MdeModulePkg/Terminal: ReadKeyStrokeEx always return key state

Reviewed-by: Star Zeng <star.z...@intel.com> Thanks, Star -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ruiyu Ni Sent: Saturday, February 24, 2018 3:14 PM To: edk2-devel@lists.01.org Cc: Zeng, Star <star.z...@intel.com> Subject: [

Re: [edk2] [PATCH] MdeModulePkg/RecoveryDevice.h: Remove semicolon after GUID definitions

Eric <eric.d...@intel.com>; Zeng, Star <star.z...@intel.com> Subject: [edk2] [PATCH] MdeModulePkg/RecoveryDevice.h: Remove semicolon after GUID definitions REF: https://bugzilla.tianocore.org/show_bug.cgi?id=877 Cc: Star Zeng <star.z...@intel.com> Cc: Eric Dong <eric.d...@intel.

Re: [edk2] [PATCH v2 1/3] MdePkg: restrict UefiMultiPhase.h contents if VFRCOMPILE defined

Leif, On 2018/2/23 4:09, Leif Lindholm wrote: Hi Star, I lost track of this one during my sabbatical until Ard's patch earlier today jogged my memory. On Sun, Dec 17, 2017 at 11:23:10AM +, Zeng, Star wrote: You may submit a bugzilla for the long term approach as Liming suggested in V1

Re: [edk2] [Patch v2 0/3] MdeModulePkg: Add Boot Logo 2 Protocol

nction'? Thanks, Star -Original Message- From: Kinney, Michael D Sent: Friday, February 16, 2018 6:52 AM To: edk2-devel@lists.01.org Cc: Sean Brogan <sean.bro...@microsoft.com>; Bret Barkelew <bret.barke...@microsoft.com>; Yao, Jiewen <jiewen....@intel.com>; Zeng, Star <star.

Re: [edk2] [PATCH v2] MdeModulePkg Variable: Update Pointer Minus with UINTN type

Reviewed-by: Star Zeng <star.z...@intel.com> Thanks, Star -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming Gao Sent: Tuesday, December 26, 2017 4:59 PM To: edk2-devel@lists.01.org Cc: Zeng, Star <star.z...@intel.com> Subject: [

Re: [edk2] [Patch] MdeModulePkg HiiDataBaseDxe: Add the check for the memory allocation return

Reviewed-by: Star Zeng <star.z...@intel.com> Thanks, Star -Original Message- From: Gao, Liming Sent: Tuesday, December 26, 2017 4:36 PM To: edk2-devel@lists.01.org Cc: Zeng, Star <star.z...@intel.com> Subject: [Patch] MdeModulePkg HiiDataBaseDxe: Add the check for the memory

Re: [edk2] [PATCH 2/2] MdeModulePkg/DxePrintLibPrint2Protocol: Fix incomplete print output

Reviewed-by: Star Zeng <star.z...@intel.com> Thanks, Star -Original Message- From: Wang, Jian J Sent: Tuesday, January 2, 2018 4:20 PM To: edk2-devel@lists.01.org Cc: Gao, Liming <liming@intel.com>; Yao, Jiewen <jiewen....@intel.com>; Zeng, Star <star.z...@intel

Re: [edk2] [PATCH] MdeModulePkg/MdeModulePkg.dec: clarify Heap Guard usage

org Cc: Dong, Eric <eric.d...@intel.com>; Zeng, Star <star.z...@intel.com> Subject: [edk2] [PATCH] MdeModulePkg/MdeModulePkg.dec: clarify Heap Guard usage Cc: Star Zeng <star.z...@intel.com> Cc: Eric Dong <eric.d...@intel.com> Contributed-under: TianoCore Contribution Agree

Re: [edk2] [Patch] MdeModulePkg HiiDataBase: Fix the potential NULL pointer reference

Could you add more information about this patch between 14b351e2ed8586f144dd3cd2e0a25082c1a32837? With that, Reviewed-by: Star Zeng <star.z...@intel.com> Thanks, Star -Original Message- From: Gao, Liming Sent: Wednesday, December 27, 2017 10:31 AM To: edk2-devel@lists.01.org Cc

Re: [edk2] [Patch] MdeModulePkg Variable: Update expression to directly use boolean type value

The title seems too long. How about updating the title to be "MdeModulePkg Variable: Use boolean type value instead of expression" With the update, Reviewed-by: Star Zeng Thanks, Star -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On

Re: [edk2] [Patch] MdePkg: Update PI spec version to 1.6 in MdePkg.dec

Reviewed-by: Star Zeng Thanks, Star -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming Gao Sent: Wednesday, December 27, 2017 5:12 PM To: edk2-devel@lists.01.org Subject: [edk2] [Patch] MdePkg: Update PI spec version to

Re: [edk2] [Patch] MdeModulePkg HiiDataBase: Fix the potential NULL pointer access

Reviewed-by: Star Zeng <star.z...@intel.com> Thanks, Star -Original Message- From: Gao, Liming Sent: Thursday, December 28, 2017 12:54 PM To: edk2-devel@lists.01.org Cc: Zeng, Star <star.z...@intel.com> Subject: [Patch] MdeModulePkg HiiDataBase: Fix the potential NULL po

<    4   5   6   7   8   9   10   11   12   13   >