Re: [edk2] MdePkg/UefiDevicePathLib: Potential lock in the loop to go to the end of a EFI Device Path

Andrew, It's possible for a UEFI OpROM to call InstallMultipleProtocolInterfaces() to install a quite big device path. It doesn't involve in variable storage at all. Your suggestion to check minimum node length seems reasonable. I will check on this. Thanks, Ray -Original Message- From:

Re: [edk2] Need Help on VFR question ids

Thanks Eric, On Thu, Jul 26, 2012 at 11:46 AM, Dong, Eric wrote: > Hi Neeraj, > > ** ** > > The root cause of this issue is browser not supports different options has > same option value, so it can handle this sample code you used. I will fix > this issue soon. Thanks. > > ** ** > > T

Re: [edk2] Need Help on VFR question ids

Hi Neeraj, The root cause of this issue is browser not supports different options has same option value, so it can handle this sample code you used. I will fix this issue soon. Thanks. Thanks, Eric From: Neeraj Ladkani [mailto:neeraj.ladk...@gmail.com] Sent: Tuesday, July 17, 2012 2:11 AM To: G

Re: [edk2] MdePkg/UefiDevicePathLib: Potential lock in the loop to go to the end of a EFI Device Path

Ray, I agree that bad code can hang, but good code should process external data without hanging. It seems at a minimum the release code can check for device path nodes that are too small, and would cause a loop. I would also point out that while there is no limit on the size of any device pa

Re: [edk2] MdePkg/UefiDevicePathLib: Potential lock in the loop to go to the end of a EFI Device Path

Olivier, With bad written code, firmware may hung very easily. If the device path is invalid, even it's handled by the library code. We may still cannot avoid the hung eventually. Thanks, Ray -Original Message- From: Olivier Martin [mailto:olivier.mar...@arm.com] Sent: Thursday, July 1

Re: [edk2] Problems with gets() and arrow keys

By design, the current version of the console abstraction in StdLib does not support function or arrow keys, nor does it support any form of input line editing. This is in the process of being rectified. The hang shouldn't happen. Remediation of this is being pushed to the top of the priority

[edk2] Problems with gets() and arrow keys

If you use gets() and enter any of the arrow keys, you will get into a hang condition. The root cause appears to be in da_ConRead, in daConsole.c. Arrow keys (and various others listed in table 88 of the UEFI specification) return ScanCode != 0 and UnicodeChar == 0 (except ESC, which I'll mentio

Re: [edk2] [PATCH v2] OvmfPkg: add support for debug console on port 0x402

On 07/25/12 22:40, Jordan Justen wrote: > On Wed, Jul 25, 2012 at 12:02 PM, Laszlo Ersek wrote: >> From: Paolo Bonzini >> >> This patch adds support for a debug console on the same port that is used >> by SeaBIOS. This makes it easier to debug OVMF, because it does not mix >> debug and serial out

Re: [edk2] [PATCH v2] OvmfPkg: add support for debug console on port 0x402

On Wed, Jul 25, 2012 at 12:02 PM, Laszlo Ersek wrote: > From: Paolo Bonzini > > This patch adds support for a debug console on the same port that is used > by SeaBIOS. This makes it easier to debug OVMF, because it does not mix > debug and serial output on the same device. It also makes it easie

[edk2] [PATCH v2] OvmfPkg: add support for debug console on port 0x402

From: Paolo Bonzini This patch adds support for a debug console on the same port that is used by SeaBIOS. This makes it easier to debug OVMF, because it does not mix debug and serial output on the same device. It also makes it easier to leave some of the debug messages on even in release builds.

Re: [edk2] [PATCH] OvmfPkg: add support for debug console on port 0x402

On Wed, Jul 25, 2012 at 12:51 AM, Paolo Bonzini wrote: > Il 25/07/2012 01:11, Jordan Justen ha scritto: >>> > >>> > No, commit >>> > added it. The first tag containing it is v0.13.0-rc0. >>> > >>> > Is that fact a blocker? (The rest of what

Re: [edk2] [PATCH] OvmfPkg: add support for debug console on port 0x402

On Wed, Jul 25, 2012 at 3:10 AM, Laszlo Ersek wrote: > On 07/25/12 11:54, Laszlo Ersek wrote: >> On 07/11/12 02:30, Jordan Justen wrote: >>> On Tue, Jul 10, 2012 at 7:36 AM, Laszlo Ersek wrote: >> + // + // Send the print string to the debug I/O port + // + for (p = (UINT8

Re: [edk2] Question regarding debugging EmulatorPkg in Fedora

On Jul 25, 2012, at 5:03 AM, Ni, Ruiyu wrote: > Andrew, > I found EmulatorPkg is using .dll as the debug symbol by sourcing > Build/Emulator/DEBUG_GCC46/X64/Host.gdb as the GDB script. Actually > .debug should be used. Because Conf/build_rule.txt strips the debug > information out of the .dll

[edk2] Question regarding debugging EmulatorPkg in Fedora

Andrew, I found EmulatorPkg is using .dll as the debug symbol by sourcing Build/Emulator/DEBUG_GCC46/X64/Host.gdb as the GDB script. Actually .debug should be used. Because Conf/build_rule.txt strips the debug information out of the .dll and creates a separate debug symbol file .debug to store

Re: [edk2] [PATCH] OvmfPkg: add support for debug console on port 0x402

On 07/25/12 11:54, Laszlo Ersek wrote: > On 07/11/12 02:30, Jordan Justen wrote: >> On Tue, Jul 10, 2012 at 7:36 AM, Laszlo Ersek wrote: > >>> + // >>> + // Send the print string to the debug I/O port >>> + // >>> + for (p = (UINT8 *) Buffer; *p; p++) { >>> +IoWrite8 (PcdGet16(PcdDebugIOP

Re: [edk2] [PATCH] OvmfPkg: add support for debug console on port 0x402

On 07/11/12 02:30, Jordan Justen wrote: > On Tue, Jul 10, 2012 at 7:36 AM, Laszlo Ersek wrote: >> + // >> + // Send the print string to the debug I/O port >> + // >> + for (p = (UINT8 *) Buffer; *p; p++) { >> +IoWrite8 (PcdGet16(PcdDebugIOPort), *p); >> + } >> +} > > Would IoWriteFifo8

Re: [edk2] [PATCH] OvmfPkg: add support for debug console on port 0x402

Il 25/07/2012 01:11, Jordan Justen ha scritto: >> > >> > No, commit >> > added it. The first tag containing it is v0.13.0-rc0. >> > >> > Is that fact a blocker? (The rest of what you identified should be >> > fixable relatively easily.) > We