Re: [edk2] Fonts, Images, Animations

2012-08-10 Thread Andrew Fish
Tim, I feel your pain. The working process for the tools is very hard to deal with if you are external to Intel. Even if you contribute something you have no idea with the BaseTools project will sync the change back in the edk2 project. Andrew Fish On Aug 10, 2012, at 11:23 AM, Tim Lewis wro

Re: [edk2] [PATCH v2 00/19] OvmfPkg: FADT, DSDT, MADT fixes

2012-08-10 Thread Jordan Justen
Reviewed-by: Jordan Justen Thanks for the valuable changes, and your extensive testing and analysis in developing the series. -Jordan On Fri, Aug 10, 2012 at 10:56 AM, Laszlo Ersek wrote: > On 08/10/12 01:52, Jordan Justen wrote: >> This series looks okay to me. >> >> I do have some concerns.

[edk2] Fonts, Images, Animations

2012-08-10 Thread Tim Lewis
One of the notable gaps in the EDK2 environment is build support for the UEFI HII concepts for fonts, strings (with fonts), images and animations. There are probably 20 press releases in the past year where people are talking about the usage of these. However, there is no way to create an EDK2-b

[edk2] [PATCH v2 18/19] OvmfPkg: have PlatformBdsLib::PciInitialization conform to the _PRS

2012-08-10 Thread Laszlo Ersek
Also set some INTLN values, informatively. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek --- OvmfPkg/Library/PlatformBdsLib/BdsPlatform.c | 20 ++-- 1 files changed, 10 insertions(+), 10 deletions(-) diff --git a/OvmfPkg/Library/PlatformB

[edk2] [PATCH v2 15/19] OvmfPkg: add parallel port to the DSDT

2012-08-10 Thread Laszlo Ersek
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek --- OvmfPkg/AcpiTables/Dsdt.asl | 13 + 1 files changed, 13 insertions(+), 0 deletions(-) diff --git a/OvmfPkg/AcpiTables/Dsdt.asl b/OvmfPkg/AcpiTables/Dsdt.asl index be6fc71..93e84bc 100644 --- a/

[edk2] [PATCH v2 16/19] OvmfPkg: fix interrupt routing in the DSDT, bump revision number

2012-08-10 Thread Laszlo Ersek
Rotate links over devices and pins so that they match qemu. PIIX4 function 3 (Power Management Module) unconditionally uses the INTA interrupt pin. SCI from this module requires IRQ9. Keep other assignments off IRQ9. Only IRQ5, IRQ10, IRQ11 remain for PCI devices. Bump OEMRevision in the DSDT.

[edk2] [PATCH v2 19/19] OvmfPkg: generate full MADT dynamically, synchronize contents with qemu

2012-08-10 Thread Laszlo Ersek
Represent the set of possible PCI link target IRQs with Pcd8259LegacyModeEdgeLevel. This ensures that the 8259 Interrupt Controller code in PcAtChipsetPkg will treat them as level-triggered too. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek --- OvmfPkg/Acpi

[edk2] [PATCH v2 00/19] OvmfPkg: FADT, DSDT, MADT fixes

2012-08-10 Thread Laszlo Ersek
On 08/10/12 01:52, Jordan Justen wrote: > This series looks okay to me. > > I do have some concerns. Like what happens if we tell the OS about the > SMI port, but the firmware has not initialized SMM. > > One big question I have... What OSes have you been able to try this with? I boot tested a W

[edk2] [PATCH v2 17/19] OvmfPkg: PlatformBdsLib: the balloon device (RAM Memory) is in slot 5

2012-08-10 Thread Laszlo Ersek
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek --- OvmfPkg/Library/PlatformBdsLib/BdsPlatform.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/OvmfPkg/Library/PlatformBdsLib/BdsPlatform.c b/OvmfPkg/Library/PlatformBdsLib/BdsPla

[edk2] [PATCH v2 13/19] OvmfPkg: add comments to the DSDT, remove trailing empty line

2012-08-10 Thread Laszlo Ersek
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek --- OvmfPkg/AcpiTables/Dsdt.asl | 12 +++- 1 files changed, 7 insertions(+), 5 deletions(-) diff --git a/OvmfPkg/AcpiTables/Dsdt.asl b/OvmfPkg/AcpiTables/Dsdt.asl index e12c3e9..91d412b 100644 --- a/Ov

[edk2] [PATCH v2 08/19] OvmfPkg: fix LAPIC RangeLength in DSDT

2012-08-10 Thread Laszlo Ersek
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek --- OvmfPkg/AcpiTables/Dsdt.asl |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/OvmfPkg/AcpiTables/Dsdt.asl b/OvmfPkg/AcpiTables/Dsdt.asl index 0ef0d3d..e627835 100644 --- a/OvmfPk

[edk2] [PATCH v2 02/19] OvmfPkg: sync FADT with QEMU: correct SMI_CMD

2012-08-10 Thread Laszlo Ersek
- Qemu's PIIX emulation actually supports SMM and ACPI_ENABLE / ACPI_DISABLE. - After enabling SMI_CMD (SMI_CMD_IO_PORT), further values to be written there must be synchronized with qemu: PSTATE_CNT, CST_CNT. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Erse

[edk2] [PATCH v2 12/19] OvmfPkg: _DIS and _SRS methods should have permanent effect

2012-08-10 Thread Laszlo Ersek
Kill PDIS and PSRS as they are writing to copies of PIR[A-D], not PIR[A-D] themselves. Use specialized _DIS and _SRS methods that access PIR[A-D] directly. (This should be solvable by passing RefOf (PIRA) etc to PDIS/PSRS, however the RHEL-6.3 kernel AML parser seems to choke on it. The rules desc

[edk2] [PATCH v2 04/19] OvmfPkg: sync FADT with QEMU: cleanup FLUSH_SIZE / FLUSH_STRIDE

2012-08-10 Thread Laszlo Ersek
Since WBINVD is supported, clear ignored FLUSH_SIZE and FLUSH_STRIDE. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek --- OvmfPkg/AcpiTables/Platform.h |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/OvmfPkg/AcpiTables/Platform.h b

[edk2] [PATCH v2 11/19] OvmfPkg: unlike PIIX4, qemu needs ActiveHigh for interrupt sharing

2012-08-10 Thread Laszlo Ersek
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek --- OvmfPkg/AcpiTables/Dsdt.asl |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/OvmfPkg/AcpiTables/Dsdt.asl b/OvmfPkg/AcpiTables/Dsdt.asl index 6a26c3b..4c791c1 100644 --- a/OvmfPkg/Ac

[edk2] [PATCH v2 14/19] OvmfPkg: fix the _UID of \_SB.PCI0.LPC.LNKD in the DSDT

2012-08-10 Thread Laszlo Ersek
LNKD is the fourth PNP0C0F. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek --- OvmfPkg/AcpiTables/Dsdt.asl |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/OvmfPkg/AcpiTables/Dsdt.asl b/OvmfPkg/AcpiTables/Dsdt.asl index 91d412b..be6f

[edk2] [PATCH v2 10/19] OvmfPkg: simplify _CRS, _PRS, _SRS methods in the DSDT

2012-08-10 Thread Laszlo Ersek
Use Extended Interrupt Descriptors in the _CRS, _PRS, _SRS methods of \_SB.PCI0.LPC.LNK[A-D], eliminating bit shifting. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek --- OvmfPkg/AcpiTables/Dsdt.asl | 44 +- 1 files

[edk2] [PATCH v2 07/19] OvmfPkg: sync FADT with QEMU: PM Timer is 24-bit

2012-08-10 Thread Laszlo Ersek
Clear TMR_VAL_EXT. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek --- OvmfPkg/AcpiTables/Platform.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/OvmfPkg/AcpiTables/Platform.h b/OvmfPkg/AcpiTables/Platform.h index 6b6d001..4b03897

[edk2] [PATCH v2 03/19] OvmfPkg: sync FADT with QEMU: disable PM2 control block

2012-08-10 Thread Laszlo Ersek
Remove support for optional PM2 control block. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek --- OvmfPkg/AcpiTables/Platform.h |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/OvmfPkg/AcpiTables/Platform.h b/OvmfPkg/AcpiTables/Pla

[edk2] [PATCH v2 06/19] OvmfPkg: sync FADT with QEMU: boot architecture flags

2012-08-10 Thread Laszlo Ersek
Clear boot architecture flags: LEGACY_DEVICES, 8042 keyboard controller. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek --- OvmfPkg/AcpiTables/Facp.aslc |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/OvmfPkg/AcpiTables/Facp.aslc b/

[edk2] [PATCH v2 01/19] OvmfPkg: cleanup whitespace in Facp.aslc / Platform.h

2012-08-10 Thread Laszlo Ersek
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek --- OvmfPkg/AcpiTables/Platform.h |8 OvmfPkg/AcpiTables/Facp.aslc | 12 ++-- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/OvmfPkg/AcpiTables/Platform.h b/OvmfPkg/AcpiT

[edk2] [PATCH v2 05/19] OvmfPkg: sync FADT with QEMU: clear DAY_ALRM

2012-08-10 Thread Laszlo Ersek
"RTC day of the month alarm feature is not supported". Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek --- OvmfPkg/AcpiTables/Platform.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/OvmfPkg/AcpiTables/Platform.h b/OvmfPkg/AcpiTabl

[edk2] [PATCH v2 09/19] OvmfPkg: add qemu debug console port to XTRA device

2012-08-10 Thread Laszlo Ersek
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek --- OvmfPkg/AcpiTables/Dsdt.asl |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/OvmfPkg/AcpiTables/Dsdt.asl b/OvmfPkg/AcpiTables/Dsdt.asl index e627835..2dda7ab 100644 --- a/OvmfPkg/AcpiT

Re: [edk2] [PATCH] NX/ASLR/GS/RTCs Security Features

2012-08-10 Thread Eugene Khoruzhenko
Hi Yao, Yes, I misunderstood your intent in regards to combining libraries, sorry. Please see my additional comments below, I hope we can converge and get to a list of actual changes that need to be done to close on ASLR soon. Thanks ek -Original Message- From: Yao, Jiewen [mailto:jiewen

Re: [edk2] efi capabilities?

2012-08-10 Thread Andrew Fish
On Aug 10, 2012, at 9:58 AM, Tony wrote: > Hi Andrew, > So if I plan on using the ConsSplitterDxe, do I have to bind my application > to > this driver? No there is no dynamic linking in EFI. Communicating between modules is done via Protocols. A protocol is a C data structure, that often con

Re: [edk2] efi capabilities?

2012-08-10 Thread Tony
Hi Andrew, So if I plan on using the ConsSplitterDxe, do I have to bind my application to this driver? Tony -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat

Re: [edk2] Serial Protocol Implementation in BeagleBoardPkg

2012-08-10 Thread Hutcheson, Alex M.
Olivier, Thanks, didn't realize a fix was already in the works. Will the new code also add support for UART2 and UART3 on the BeagleBoard? Thanks, Alex From: edk2-devel-boun...@lists.sourceforge.net [mailto:edk2-devel-boun...@lists.sourceforge.net] On Behalf Of Olivier Martin Sent: Fri

Re: [edk2] Serial Protocol Implementation in BeagleBoardPkg

2012-08-10 Thread Olivier Martin
Hello Alex, I am planning to push some code (probably next week) to add support for SerialSetAttributes()/SerialSetControl()/SerialGetControl() in EmbeddedPkg/SerialDxe through a new library (probably 'SerialPortExtLib'). I have this change in our internal repository for a while, I just need to po

Re: [edk2] RouteConfig query

2012-08-10 Thread Dong, Eric
Hi Neeraj, For current browser implementation, it calls EFI_HII_CONFIG_ACCESS_PROTOCOL->RouteConfig in the following case: 1. User request to save the question value. 2. Execute the "action" opcode and it has "QuestionConfig" with it. I think your case may be belonging to 2. Thanks,