Got it, I will update the code to fix it. I think we can just update the
definition like below:
vfrFormSetDefinition ::=
"formset"
"guid" "=" guidDefinition ","
"title" "=" getStringId ","
"help" "=" getStringId
{"," "classguid" "=" classguidDefinition}
{"," "class" "=" classDefinition}
{"
On Mon, 2013-01-21 at 18:59 -0800, Andrew Fish wrote:
> EFI_BLOCK_IO_PROTOCOL *BlkIo;
>
> BlkIo->Media->RemovableMedia
>
> Keys the EFI behavior.
It does, slightly. EFI puts removable devices before non-removable ones
in the list. That's it, AFAICT.
It *isn't* relevant to the question of whethe
Eric -
It is "this definition does not follow the VFR code style?" Many other opcodes
have optional pieces, but end in ";" Only formset ends in a "," So I would like
to allow ";" also. I don't want to break existing code, just make VFR rules
easier to follow.
Tim
From: Dong, Eric [mailto:eric
Tim,
VFR spec definition for formset opcode in the follow format:
vfrFormSetDefinition ::=
"formset"
"guid" "=" guidDefinition ","
"title" "=" getStringId ","
"help" "=" getStringId ","
{ "classguid" "=" classguidDefinition "," }
{ "class" "=" classDefinition "," }
{ "subclass" "=" subclassDefinit
On Jan 21, 2013, at 5:40 PM, David Woodhouse wrote:
> On Mon, 2013-01-21 at 16:59 -0800, Andrew Fish wrote:
>> Not sure if BdsGetBootTypeFromDevicePath() is broken, or functioning
>> as intended. Remember in EFI there is not a concept of a bootable
>> non-removable block IO device. The OS insta
David:
We have no such usage mode to make header files to be reused by other
project... sorry.
Thanks
Elvin
-Original Message-
From: David Woodhouse [mailto:dw...@infradead.org]
Sent: Friday, January 18, 2013 4:52 AM
To: edk2-devel@lists.sourceforge.net
Subject: [edk2] [PATCH] L
On Mon, 2013-01-21 at 16:59 -0800, Andrew Fish wrote:
> Not sure if BdsGetBootTypeFromDevicePath() is broken, or functioning
> as intended. Remember in EFI there is not a concept of a bootable
> non-removable block IO device. The OS installs the OS loader as a
> file and updates a variable to cont
On Jan 21, 2013, at 4:43 PM, David Woodhouse wrote:
> On Tue, 2013-01-22 at 00:29 +, Li, Elvin wrote:
>> You can make a try to implement such CSM16 to return back to EFI,
>> GenericLegacyBoot()
>> thus returns EFI_DEVICE_UNSUPPORTED, but it is BDS which initially
>> calls "LegacyBios->Legacy
On Jan 21, 2013, at 4:17 PM, David Woodhouse wrote:
> When I have a virtio disk attached to a qemu VM, it doesn't appear in
> the OVMF boot menu, so I can't boot from it. This is because the
> BdsGetBootTypeFromDevicePath() function in GenericBdsLib.c only works on
> the device path and isn't ab
On Tue, 2013-01-22 at 00:29 +, Li, Elvin wrote:
> You can make a try to implement such CSM16 to return back to EFI,
> GenericLegacyBoot()
> thus returns EFI_DEVICE_UNSUPPORTED, but it is BDS which initially
> calls "LegacyBios->LegacyBoot ()" to launch legacy boot, you can add
> error handling
You can make a try to implement such CSM16 to return back to EFI,
GenericLegacyBoot()
thus returns EFI_DEVICE_UNSUPPORTED, but it is BDS which initially calls
"LegacyBios->LegacyBoot ()" to launch legacy boot, you can add error handling
after LegacyBoot () returns and reconnect EFI drivers and g
When I have a virtio disk attached to a qemu VM, it doesn't appear in
the OVMF boot menu, so I can't boot from it. This is because the
BdsGetBootTypeFromDevicePath() function in GenericBdsLib.c only works on
the device path and isn't able to infer that 'PciRoot(0x0)/Pci(0x5,0x0)'
is a virtio disk.
Sergey,
I don't have a 16-bit disassembler handy, or a gcc toolchain installed. Can you
send the disassembly of the entire function, including the byte values.
It is not clear to me how this works correctly with gcc? The 0x66 prefix
changes the operand size, and the 0x2e prefix forces the CS s
On Jan 20, 2013, at 2:51 PM, Joe Vernaci wrote:
> Hi Andrew,
>
> That's fine, it's ambiguities that lead to problems like this. When I wrote
> "must be type (signed) int" I was only referring to enumeration constants
> within the enumeration definition.
I agree but when we were working thr
Hi Andrew,
As you are maintainer of XCLANG compilation I call to you to resolve the
problem.
I reported about it a year ago but now I see the wrong version of Thunk16.s is
returned into the library
MdePkg/Library/BaseLib/X64/Thunk16.S
The problematic codes is here
--
.byte 0x66,0x
Is there some specific reason why "vfrFormSetDefinition" does not have a ";"
after the "subclass" keyword? Instead it uses a comma. But "form" and every
other statement ends in a ";"
Tim
--
Master Visual Studio, SharePoi
Ben -
This is a browser issue. SetBrowserData should not be necessary (if using
RETRIEVE), but it should certainly force the browser value to be updated.
DriverSampleDxe (which you are using) only seems to have a sample for Ref, not
for numeric. And, unfortunately, the SCT doesn't handle callba
The BaseLib.h has unaligned read and write functions to help with alignment
issues.
On ARMv7 (like the BeagleBoard) it is possible turn on and off the alignment
exceptions. So it it possible to test the code for alignment faults if needed.
Andrew Fish
https://edk2.svn.sourceforge.net/svnroo
Thanks for the replies Tim and Sathya.
I have tried changing the Value field in these events as well:
EFI_BROWSER_ACTION_CHANGED & EFI_BROWSER_ACTION_CHANGING.
The value was not updated.
Perhaps I need to call SetBrowserData() or perhaps I need to use VFR refresh
opcode for my questions (EFI_IFR
Ah I see, that is good to know and handy in the right situation. But yes I
see how that could be abused. I guess your suggestions for the lax
alignment does make sense for better support. Maybe just throw in a
warning message about breaking the pci spec and call it a day.
On Sun, Jan 20, 2013
This may mean that SignTool found MyDriver.efi's PE header to be invalid or
corrupt.
I've seen similar errors in those situations but don't recall the exact
wording
Are you able to sign other drivers or apps (ie: HelloWorld.efi in
MdeModulePkg/Applications)?
If so I'd suggest comparing their
Have you tried changing the values in CHANGED/CHANGING Callback actions? Also
have you tried invoking SetBrowserData() before returning from your callback?
Thanks
Sathya
From: Tim Lewis [mailto:tim.le...@insyde.com]
Sent: Monday, January 21, 2013 10:22 AM
To: edk2-devel@lists.sourceforge.net
Sub
On Jan 21, 2013, at 8:42 AM, 雅虎邮箱 wrote:
> Hi All,
>
> I meet with some problems now.
>
> 1. I am writing an Application use EFI_FIRMWARE_VOLUME2_PROTOCOL
> (MdePkg\Include\Protocol\FirmwareVolume2.h), but when I compile it with
> VS2010 compiler, it will prompt a warning C4431, which warn
Ben -
For FORM_OPEN changing the value does nothing. For RETRIEVE it should allow you
to update the current question value used by the Forms Browser. So something is
strange.
In general, ONE_OF and NUMERIC are identical. A forms browser may choose to
display one differently than another. But t
Ben -
In general, you should avoid using Key, since it is not UEFI standard. "Key" is
left over from Intel's Framework specification. It is accepted by some form
browsers, but not others.
Tim
From: Ben Schroeder [mailto:ben...@mellanox.com]
Sent: Monday, January 21, 2013 2:12 AM
To: edk2-devel
On Mon, 2013-01-21 at 17:53 +0100, Paolo Bonzini wrote:
> You are in control of the EFI_LEGACY_REGION_PROTOCOL implementation
> though. If SeaBIOS needs 0xE-0xF to be always writable, just
> make a Lock of that region a no-op...
We could do that, but it seems wrong to me. The LegacyRegion
Il 21/01/2013 00:42, David Woodhouse ha scritto:
> The main issue I have on the OVMF side is that it locks the entire
> memory region from 0xC-0xF to be read-only, right before
> invoking the Legacy16Boot method. This upsets SeaBIOS, which puts a
> stack in the E segment for use during
Hi All,
I meet with some problems now.
1. I am writing an Application use EFI_FIRMWARE_VOLUME2_PROTOCOL
(MdePkg\Include\Protocol\FirmwareVolume2.h), but when I compile it with VS2010
compiler, it will prompt a warning C4431, which warning that UINTN type is not
recognized by compiler and must
Hi everyone,
I was wondering how it is possible to modify the value of a field displayed in
an HII form.
For instance:
numeric varid = MyIfrNVData.HowOldAreYouInYears,
questionid = 0x1200,
prompt = STRING_TOKEN(STR_NUMERIC_STEP_PROMPT),
help
Hi everyone,
I am unsure to what difference there is between key and questionid in some VFR
operators.
I understand in some situations 'key' field will act as questionid, like in
text operator. Questionid does not exist in EFI_IFR_TEXT, so it seems logical
that key will replace this field.
Wha
Sorry for that, I have no clue how that happened.
Thanks,
Kevin
戴連輝
From: Kevin Davis [mailto:kevin.da...@insyde.com]
Sent: Monday, January 21, 2013 1:32 PM
To: edk2-devel@lists.sourceforge.net
Subject: [edk2] Eqwd
___
31 matches
Mail list logo
