Re: [edk2] [PATCH] MdeModulePkg/Core/Pei: Critical buffer overflow when loading TE Images

2013-02-19 Thread Dong, Eric
Olivier, For section alignment, it only requires the section data begin at the Section Alignment address, not require TE image header also section alignment. When generate PE image, the compiler has make sure the section data is section alignment to the PE file's base address when load into mem

Re: [edk2] Dyanamic primitive creation

2013-02-19 Thread Tim Lewis
Eric -- Do you think it is good practice to modify a form that is already open? Using UpdateForm() in the method you describe seems unusual, since there is no documented behavior about how the Form Browser should handle this behavior. I know it is done often, but using undefined behavior in a d

Re: [edk2] Dyanamic primitive creation

2013-02-19 Thread Dong, Eric
Sathya, Add my comments below. Thanks, Eric -Original Message- From: Prakash, Sathya [mailto:sathya.prak...@lsi.com] Sent: Wednesday, February 20, 2013 12:18 AM To: edk2-devel@lists.sourceforge.net Subject: [edk2] Dyanamic primitive creation I am trying to create dynamic primitives in

Re: [edk2] How to align auto variables?

2013-02-19 Thread Felix Poludov
Mike, Your arguments certainly make sense. However, as Tim pointed out earlier, the chapter 2 language could've been stronger and more precise. Perhaps we should add a sentence explicitly stating alignment requirement for the input parameters. -Original Message- From: Kinney, Michael D

Re: [edk2] [Qemu-devel] [SeaBIOS] (PAM stuff) reset doesn't work on OVMF + SeaBIOS CSM

2013-02-19 Thread Laszlo Ersek
On 02/19/13 19:41, Gleb Natapov wrote: > On Tue, Feb 19, 2013 at 06:35:03PM +, David Woodhouse wrote: >> On Tue, 2013-02-19 at 20:13 +0200, Gleb Natapov wrote: >>> I take it you mean copy 0xfffe to 0xe? That would not be >>> fun. SeaBIOS would need to detect that it's in the

Re: [edk2] How to align auto variables?

2013-02-19 Thread Kinney, Michael D
Felix, The UEFI Specification defines the HII String Protocol SetString() function to have following function prototype: typedef EFI_STATUS (EFIAPI *EFI_HII_SET_STRING) ( IN CONST EFI_HII_STRING_PROTOCOL *This, IN EFI_HII_HANDLE PackageList

Re: [edk2] [PATCH] MdeModulePkg/Core/Pei: Critical buffer overflow when loading TE Images

2013-02-19 Thread Kinney, Michael D
Olivier, Thanks for finding this issue and providing the patch. We are reviewing and testing is now and will let you know the results soon. Mike -Original Message- From: Ryan Harkin [mailto:ryan.har...@linaro.org] Sent: Tuesday, February 19, 2013 12:31 AM To: edk2-devel@lists.sourcefo

Re: [edk2] How to align auto variables?

2013-02-19 Thread Hiriyannaiah, Savitha
Sathya, What is the behavior / consequences when the VFR structures are not byte packed? Regards, Savitha From: Prakash, Sathya [sathya.prak...@lsi.com] Sent: Tuesday, February 19, 2013 8:01 AM To: edk2-devel@lists.sourceforge.net Subject: Re: [edk2] How t

[edk2] Dyanamic primitive creation

2013-02-19 Thread Prakash, Sathya
I am trying to create dynamic primitives in a form, the calls were successful and I am able to see the one of values, but the string I am using for the question prompt are not displayed (I am dynamically setting those strings). Also I did see whenever I enters into the form, the dynamic primitiv

Re: [edk2] How to align auto variables?

2013-02-19 Thread Prakash, Sathya
So what would be the conclusion to resolve this?. Even if I change the EDK build environment I use, I can not change what platform provides. Anyone actually faced this and overcome? Thanks Sathya -Original Message- From: Felix Poludov [mailto:fel...@ami.com] Sent: Thursday, February 14

Re: [edk2] Issues while building the driver through udk

2013-02-19 Thread Prakash, Sathya
Thanks Eric. I will follow #2 for now. Do you see anything preferred over other? -Sathya From: Dong, Eric [mailto:eric.d...@intel.com] Sent: Monday, February 18, 2013 12:22 AM To: edk2-devel@lists.sourceforge.net Subject: Re: [edk2] Issues while building the driver through udk Sathya, You can

Re: [edk2] QEMU + OVMF Query:Fedora 18 installed on ATA disk and then booted it as NVMe disk ( with F18 installed on it) giving dracut-initqueue errors.

2013-02-19 Thread Laszlo Ersek
On 02/19/13 07:38, baban devkate wrote: > Finally OS booted using my driver!!! Congrats! :) > I used Ubuntu 12.10 instead F18. It worked like charm. > > It was great learning experience with you, thanks a lot. Glad to help as far as I'm able... Cheers, Laszlo ---

Re: [edk2] [PATCH] MdeModulePkg/Core/Pei: Critical buffer overflow when loading TE Images

2013-02-19 Thread Olivier Martin
Thanks Eric, gBS->AllocatePages() already returns an 4KB-aligned address. I still think the fix you have done should go in BasePeCoffLib (in PeCoffLoaderGetImageInfo() and PeCoffLoaderLoadImage()). What I think is not correct is to copy the EFI_TE_IMAGE_HEADER just before the sections, you sh

Re: [edk2] [PATCH] MdeModulePkg/Core/Pei: Critical buffer overflow when loading TE Images

2013-02-19 Thread Ryan Harkin
Hi Dong, On 19 February 2013 07:56, Dong, Eric wrote: > Oliver, > > > > In red mark code is used to fix the alignment issue raised in IPF platform, > we can’t remove it. For TE image, it also needs to make sure the section > data is section alignment. So in my patch, i just expand the memory size