Re: [edk2] [PATCH] FatPkg: Make FatGetCurrentFatTime() always return a valid time

2013-05-07 Thread Ni, Ruiyu
It's good. Reviewed-by: Ruiyu Ni BTW, under what circumstance the GetTime() would return failure? From: Olivier Martin [mailto:olivier.mar...@arm.com] Sent: Wednesday, May 08, 2013 1:00 AM To: Ni, Ruiyu; 'Jordan Justen' Cc: edk2-devel@lists.sourceforge.net Subject: [PATCH] FatPkg: Make FatGetCu

Re: [edk2] [PATCH] ShellPkg: Fixed build error 'variable set but not used'

2013-05-07 Thread Carsey, Jaben
Olivier, For DmpStore will this work instead of your proposed change? The reason is that I think the STATUS_ABORTED is good to return to the caller in case a script file is checking return values. -Jaben From: Olivier Martin [mailto:olivier.mar...@arm.com] Sent: Tuesday, May 07, 2013 9:34 AM

[edk2] [PATCH] FatPkg: Make FatGetCurrentFatTime() always return a valid time

2013-05-07 Thread Olivier Martin
Dear FatPkg maintainers, Please find this patch that makes FatGetCurrentFatTime() always return a valid time. Without this patch if gRT->GetTime fails to return the time then some operations on the filesystem could fail. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-b

[edk2] [PATCH] ShellPkg: Fixed build error 'variable set but not used'

2013-05-07 Thread Olivier Martin
Dear ShellPkg maintainer, Please find the attached patch that fixes the ShellPkg build for the GCC toolchain. GCC raises a warning when a variable is initialized but not used; but warnings are treated as error (to ensure quality in our code). Regards, Olivier 0001-ShellPkg-Fixed-build-error-v

Re: [edk2] beginner: debugging an UEFI HII application

2013-05-07 Thread Richardson, Brian
Saheb: It’s best to do early development from the UEFI Shell, so you don’t have to re-flash the PCI device for each iteration. You can build your application with the ‘DEBUG’ setting in conf/target.txt, so debug messages can be diverted to the serial port. There is a basic presentation for bui

[edk2] Using StdLib in UEFI_DRIVER Type

2013-05-07 Thread Jeffrey Chou
Hi all, I am trying to use StbLib in an uefi driver module, and it seems the StbLib is only supported on UEFI_APPLICATION. So I have an idea that my uefi driver invoking an uefi application built with StdLib thru ShellExecute or LoadImage. But I am facing a problem that I don't know how to pass au

[edk2] [PATCH] OvmfPkg: QemuBootOrder: recognize Ethernet OFW device paths

2013-05-07 Thread Laszlo Ersek
Tested with the Intel e1000 driver and VirtioNetDxe. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek --- OvmfPkg/Library/PlatformBdsLib/QemuBootOrder.c | 29 1 files changed, 29 insertions(+), 0 deletions(-) diff --git a/OvmfPkg/Li