[edk2] EFI_FILE_PROTOCOL.Read() - error condition not clear

2013-08-22 Thread David F.
For a regular file, the 2.3.1, Errata C isn't clear if buffersize is updated even if a failure and file pointer advanced. I presume it's always reset to 0 at start of function so any error will return 0 unless the error occurred after reading some number of bytes where it's not clear if that is re

Re: [edk2] DXE Dispatch() Will Not Dispatch SMM drivers in certain cases

2013-08-22 Thread Gao, Liming
Tim: I agree this is an issue. And, your solution is good. We will fix it. Thanks Liming From: Tim Lewis [mailto:tim.le...@insyde.com] Sent: Thursday, August 22, 2013 12:44 AM To: edk2-devel@lists.sourceforge.net Subject: [edk2] DXE Dispatch() Will Not Dispatch SMM drivers in certain cases We h

Re: [edk2] [edk2-buildtools] Sync BaseTools Trunk (version r2598) to EDKII main trunk

2013-08-22 Thread Gao, Liming
Oliver: This round sync is done at EDKII r14591. And, I have got your request. Once your fix is done, please let me know. I will evaluate its quality and do new sync. Besides, for your change to GenFw, do you expect who will response to this patch? Jordan or others? Thanks Liming -

Re: [edk2] [PATCH] OvmfPkg NvVarsFileLib: Set NvVars variable after writing vars file

2013-08-22 Thread Jordan Justen
On Mon, Aug 19, 2013 at 3:00 AM, Michael Chang wrote: > On Sat, Aug 17, 2013 at 11:16:16PM -0700, Jordan Justen wrote: >> The volatile 'NvVars' variable indicates that the variables do >> not need to be loaded from the file again. After we write the >> variables out to the file, there is clearly n

Re: [edk2] MNP PaddingSize Question

2013-08-22 Thread Cohen, Eugene
➢ You only need to byte copy 7 bytes max, so this seems like a bug in your CopyMem routine.  You only have to align the 1st few, and last few bytes, and then do a fast CopyMem in the middle? Unfortunately, no. Let me illustrate it with an example: Source buffer: 0x1000 (aligned, uncahced)

Re: [edk2] MNP PaddingSize Question

2013-08-22 Thread Andrew Fish
On Aug 22, 2013, at 6:41 AM, Andrew Fish wrote: > > > On Aug 22, 2013, at 5:58 AM, "Cohen, Eugene" wrote: > >> Thanks for the responses Siyuan and Andrew. >> >> I think I understand your explanation -- to get the payload aligned properly >> so higher layers can get the best performance a

Re: [edk2] MNP PaddingSize Question

2013-08-22 Thread Andrew Fish
On Aug 22, 2013, at 5:58 AM, "Cohen, Eugene" wrote: > Thanks for the responses Siyuan and Andrew. > > I think I understand your explanation -- to get the payload aligned properly > so higher layers can get the best performance and not necessarily align the > start of the frame itself. Do

Re: [edk2] [edk2-buildtools] Sync BaseTools Trunk (version r2598) to EDKII main trunk

2013-08-22 Thread Cohen, Eugene
It seems like the sync system is designed to provide stability by limiting day-to-day tools turmoil to edk2 trunk. But without a way to validate all toolchains (including ARM, XCode, etc) then I don' t think the process is really all that helpful as Olivier describes. I think this issue points

Re: [edk2] MNP PaddingSize Question

2013-08-22 Thread Cohen, Eugene
Thanks for the responses Siyuan and Andrew. I think I understand your explanation -- to get the payload aligned properly so higher layers can get the best performance and not necessarily align the start of the frame itself. Do you have some data you can share on how much improvement aligning t

Re: [edk2] [PATCH] OvmfPkg: Virtio: load used ring element strictly after loading used index

2013-08-22 Thread Laszlo Ersek
On 08/19/13 09:33, Laszlo Ersek wrote: > Enforce in-order execution of these steps even on not sequentially > consistent architectures, as discussed in [1]. These changes should be > unnecessary on x86 (the only architecture OVMF currently supports), but > they align the OVMF virtio code with the v

Re: [edk2] [edk2-buildtools] Sync BaseTools Trunk (version r2598) to EDKII main trunk

2013-08-22 Thread Olivier Martin
Liming, I understand the benefit to get a stable BaseTools in EDK2. And it looks your level of validation is high as the BaseTools sync was announced a week ago and it has not been pushed yet. But if when you will sync the BaseTools my firmware does not work anymore (it has been the case in the p

[edk2] FTDI 4232 used to loopback test two LTC2872 transceivers

2013-08-22 Thread Mircea Trepadus
Hello I want to self-test using the Loop-Back mode two LTC2872 transceivers configured in RS232 mode. The transceivers are linked to one FTDI 4232, obtaining four Serial Communication Ports. Step 1: In order to perform the Loop-Back test, I successfully enabled the Loop-Back mode for t

Re: [edk2] MNP PaddingSize Question

2013-08-22 Thread Andrew Fish
Sent from my iPhone On Aug 22, 2013, at 12:15 AM, "Fu, Siyuan" wrote: > Hi, Eugene > > The PaddingSize is in order to make the packet data (exclude the media > header) 4-byte aligned when we tries to receive a packet. > When MNP driver calls the Snp.Receive() interface, both the media heade

Re: [edk2] MNP PaddingSize Question

2013-08-22 Thread Fu, Siyuan
Hi, Eugene The PaddingSize is in order to make the packet data (exclude the media header) 4-byte aligned when we tries to receive a packet. When MNP driver calls the Snp.Receive() interface, both the media header and the data will be placed to the *Buffer*. Use IP packet over Ethernet for examp