Re: [edk2] [utwg] Re: UEFI SCT few queries

2013-10-29 Thread Wei, Dong (HP Servers CT Office)
See my answers in line. - DW From: u...@uefi.org [mailto:u...@uefi.org] On Behalf Of Prabhakar Kushwaha Sent: Tuesday, October 29, 2013 1:26 AM To: edk2-devel@lists.sourceforge.net; u...@uefi.org Subject: [utwg] Re: [edk2] UEFI SCT few queries +u...@uefi.org Hi Li

Re: [edk2] [PATCH v4 00/11] OvmfPkg: Introduce and use the new VIRTIO_DEVICE_PROTOCOL protocol

2013-10-29 Thread Jordan Justen
On Mon, Oct 28, 2013 at 10:36 PM, Olivier Martin wrote: > Unfortunately, the caller (the VirtIo Block driver) does not > know if the access is unaligned. Did you or Laszlo say that the virtio spec specifically says that all I/O accesses can be broken up into smaller accesses? If so, then I think

Re: [edk2] [PATCH v4 07/11] OvmfPkg: Make the VirtIo devices use the new VIRTIO_DEVICE_PROTOCOL

2013-10-29 Thread Laszlo Ersek
OK, I'm really stopping for today. Corrections: On 10/29/13 17:28, Laszlo Ersek wrote: > This comment is stale -- see near the implementation of the > VirtioAppendDesc() function. Clearly the function in question is VirtioFlush(). > (3) The error handling is wrong, you need to assign EFI_UNSUPP

Re: [edk2] ShellPkg: Properly set lasterror environment variable

2013-10-29 Thread Carsey, Jaben
Reviewed and committed. From: Phillips, Chris J (BCS CFE) [mailto:chr...@hp.com] Sent: Tuesday, October 29, 2013 9:15 AM To: edk2-devel@lists.sourceforge.net; Carsey, Jaben Subject: ShellPkg: Properly set lasterror environment variable Importance: High Please review the attached patch file. - Se

[edk2] ShellPkg: Properly set lasterror environment variable

2013-10-29 Thread Phillips, Chris J (BCS CFE)
Please review the attached patch file. - Set lasterror value based on platform width - Use "lasterror" rather than "Lasterror" for variable name to match Shell Specification - Set lasterror value when a binary or script file is not found Thanks, Chris ShellPkg: Properly set lasterror environ

Re: [edk2] [PATCH v4 11/11] OvmfPkg/Virtio: Removed VirtioReadDevice() / VirtIoWriteDevice() functions

2013-10-29 Thread Laszlo Ersek
On 10/16/13 19:29, Olivier Martin wrote: > These functions did not provide much more than the new protocol functions > VIRTIO_DEVICE_PROTOCOL.ReadDevice() / VIRTIO_DEVICE_PROTOCOL.WriteDevice(). > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Olivier Martin > --- > O

Re: [edk2] [PATCH v4 06/11] OvmfPkg/VirtioMmioDeviceLib: Implement VIRTIO_DEVICE_PROTOCOL for VirtIo Devices over MMIO

2013-10-29 Thread Laszlo Ersek
On 10/16/13 19:29, Olivier Martin wrote: > Why is the virtio-mmio implementation of the protocol a library, > instead of a driver binary? > The UEFI driver model would encourage to create a virtio-mmio driver > instead of a library. But the reasons why I created a library are: > > - A virtio-mmio

Re: [edk2] UEFI SCT few queries

2013-10-29 Thread Prabhakar Kushwaha
+u...@uefi.org Hi List, Please help me in getting below queries resolved. Regards, Prabhakar On 10/29/2013 11:22 AM, Li, Ruth wrote: Hi Prabhakar, Recommend you bring your question to UTWG group. Email: u...@uefi.org Thanks, Ruth *From:*Pr