[edk2] gBS->LocateProtocol

2013-11-29 Thread Nishit Patira
Hi, I am writing an UEFI Application. I am using gBS_>LocateProtocol to return the instance where the protocl is found. EFI_STATUS Status; gBS = SystemTable->BootServices; Status = gBS->LocateProtocol (&gEfiIntelDimmToolProtocolGuid, NULL,(void **) &mDimmToolProtocol); However, the function is n

Re: [edk2] [PATCH] UefiCpuPkg/.../X64/ExceptionHandlerAsm.S: 64-bit relocation for variables

2013-11-29 Thread Fan, Jeff
David, I send the same contents(Laszlo's check-in log message) by internal mail or by my outside Hotmail to me. They are NOT be reformatted. But the message was really reformatted when I post message to edk2-devel@lists.sourceforge.net. What do you think of it? Best Regards Jeff -Original

Re: [edk2] [PATCH] UefiCpuPkg/.../X64/ExceptionHandlerAsm.S: 64-bit relocation for variables

2013-11-29 Thread Fan, Jeff
Hi, Ersek Sorry. The log message in mail body is reformatted again. Please check the svn log. Its format is correct. Jeff -Original Message- From: Fan, Jeff [mailto:jeff@intel.com] Sent: Saturday, November 30, 2013 10:35 AM To: Laszlo Ersek Cc: edk2-devel@lists.sourceforge.net Subj

Re: [edk2] [UefiCpuPkg][Patch] Fix UNIXGCC IA32 build issue

2013-11-29 Thread Fan, Jeff
Jordan, Thanks! Fixed it in title and commit log. Jeff -Original Message- From: Jordan Justen [mailto:jljus...@gmail.com] Sent: Saturday, November 30, 2013 7:55 AM To: edk2-devel@lists.sourceforge.net Subject: Re: [edk2] [UefiCpuPkg][Patch] Fix UINXGCC IA32 build issue On Fri, Nov 29, 2

Re: [edk2] [PATCH] UefiCpuPkg/.../X64/ExceptionHandlerAsm.S: 64-bit relocation for variables

2013-11-29 Thread Fan, Jeff
Hi, Ersek, I updated the commit log as below, please review it. Thanks! Jeff UefiCpuPkg/.../X64/ExceptionHandlerAsm.S: 64-bit relocation for variables This assembly file declares the following seven symbols: CommonExceptionHandler CommonInterruptEntry HookAfterStubHeaderEnd mErrorC

Re: [edk2] [UefiCpuPkg][Patch] Fix UINXGCC IA32 build issue

2013-11-29 Thread Jordan Justen
On Fri, Nov 29, 2013 at 12:53 AM, Fan, Jeff wrote: > Hi, all > > I just fixed one UNIXGCC IA32 build issue on > UefiCpuPkg\Library\CpuExceptionHandlerLib\Ia32\ExceptionHandlerAsm.S, as > below. If you have meet other build issue on other TOOL CHAIN, please tell > me. Thanks! > > Fixed typo: HookAf

[edk2] eMMC at UEFI

2013-11-29 Thread Rafael Machado
Hi everyone I need to check some information on an eMMC storage device. I still don't have this device here, so I'm trying to do some research before receiving it. As far as I could check, there is no specific protocol to access this kind of device. Does any of you have already worked with eMMC de

Re: [edk2] StrHexToUint64 function

2013-11-29 Thread Sergey Isakov
Hi Nishit, argv[1] is an Ascii string while StrHexToUint64 deals with Unicode string. You should first convert Ascii to Unicode. Hope it helps, Sergey On 29 нояб. 2013 г., at 16:51, Nishit Patira wrote: > Hi, > > I am taking a string from console using int main(argc, **argv). > The second arg

[edk2] [PATCH] Clean up hard-coded offsets and other utter bogosity in Thunk16.S.

2013-11-29 Thread David Woodhouse
Again. Properly this time. In r12889 we attempted to clean this up, but we missed a vital part of it, so it was reverted in r12898. What we missed was the fact that much of this is 16-bit code, and the assembler didn't *know* that — it thought it was compiling 32-bit code and we had even gone ou

Re: [edk2] [PATCH] UefiCpuPkg/.../X64/ExceptionHandlerAsm.S: 64-bit relocation for variables

2013-11-29 Thread David Woodhouse
On Fri, 2013-11-29 at 14:56 +, Fan, Jeff wrote: > > My mail system may reformat the log message. Do you mind sending log > in one attached txt file to me? Updating log does not spend too much > time.:-) Jeff, if Intel's mail system is breaking your incoming mail, please ensure it is reported

Re: [edk2] [PATCH] UefiCpuPkg/.../X64/ExceptionHandlerAsm.S: 64-bit relocation for variables

2013-11-29 Thread Laszlo Ersek
On 11/29/13 15:56, Fan, Jeff wrote: > My mail system may reformat the log message. Do you mind sending log > in one attached txt file to me? Updating log does not spend too much > time.:-) Please find the patch in the attachment. Thank you. Laszlo From 710bc8e58d6608a58c713055a6b0e42fe839a35b Mon

Re: [edk2] [PATCH] UefiCpuPkg/.../X64/ExceptionHandlerAsm.S: 64-bit relocation for variables

2013-11-29 Thread Fan, Jeff
Hi, Laszlo My mail system may reformat the log message. Do you mind sending log in one attached txt file to me? Updating log does not spend too much time.:-) Thanks! Jeff -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Friday, November 29, 2013 10:41 PM To: Fan,

Re: [edk2] [PATCH] UefiCpuPkg/.../X64/ExceptionHandlerAsm.S: 64-bit relocation for variables

2013-11-29 Thread Laszlo Ersek
Hi Jeff, On 11/29/13 15:28, Fan, Jeff wrote: > Log updating done. Please use show log command to check this > updating, any problem please tell me. Thanks your contribution on > UefiCpuPkg! I believe your mail user agent must be automatically re-flowing plaintext emails -- the line breaks that I

Re: [edk2] [PATCH] UefiCpuPkg/.../X64/ExceptionHandlerAsm.S: 64-bit relocation for variables

2013-11-29 Thread Fan, Jeff
Laszlo, Log updating done. Please use show log command to check this updating, any problem please tell me. Thanks your contribution on UefiCpuPkg! Best Regards, Jeff -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Friday, November 29, 2013 8:03 PM To: Fan, Jeff C

[edk2] [PATCH v4 4/7] OvmfPkg: detect Xen earlier

2013-11-29 Thread Wei Liu
This is useful for initializing memory map. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Wei Liu Reviewed-by: Jordan Justen --- OvmfPkg/PlatformPei/Platform.c |8 +++- OvmfPkg/PlatformPei/Platform.h |5 + OvmfPkg/PlatformPei/Xen.c | 12 +-

[edk2] [PATCH v4 7/7] OvmfPkg: enable Xen specific path

2013-11-29 Thread Wei Liu
This patch sets PcdPciDisableBusEnumeration to true then makes use of PublishPeiMemory and XenMemMapInitialization to construct memory map for Xen guest. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Wei Liu --- OvmfPkg/OvmfPkgIa32.dsc |6 +- OvmfPkg/

[edk2] [PATCH v4 6/7] OvmfPkg: introduce XenMemMapInitialization

2013-11-29 Thread Wei Liu
This function parses E820 map provided by Xen and arrange memory maps accordingly. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Wei Liu --- OvmfPkg/PlatformPei/Platform.c | 70 OvmfPkg/PlatformPei/Platform.h |8 + OvmfP

[edk2] [PATCH v4 3/7] OvmfPkg: define EFI_XEN_OVMF_INFO

2013-11-29 Thread Wei Liu
EFI_XEN_OVMF_INFO is defined to accept configurations from hvmloader. It must match the definition on Xen side. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Wei Liu --- OvmfPkg/PlatformPei/Xen.h | 45 + 1 file changed, 45 in

[edk2] [PATCH v4 2/7] OvmfPkg: introduce E820.h

2013-11-29 Thread Wei Liu
E820 definitions copied from IntelFrameworkModulePkg/Csm/ LegacyBiosDxe/LegacyBiosInterface.h. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Wei Liu Reviewed-by: Jordan Justen --- OvmfPkg/Include/IndustryStandard/E820.h | 46 +++ 1 file cha

[edk2] [PATCH v4 5/7] OvmfPkg: introduce PublishPeiMemory

2013-11-29 Thread Wei Liu
MemDetect actully does too many things, the underlying platform might want to have more control over memory layout. Extract the functionality of publishing PEI memory to a dedicated function. Also fixed wrong comment while I was there. Contributed-under: TianoCore Contribution Agreement 1.0 Sign

[edk2] [PATCH v4 1/7] MdeModulePkg: introduce PcdPciDisableBusEnumeration

2013-11-29 Thread Wei Liu
Platforms such as Xen already enumerates PCI bridges and devices. Use this PCD to control EDK2 behavior. PcdPciDisableBusEnumeration is placed under [PcdsFixedAtBuild, PcdsPatchableInModule, PcdsDynamic, PcdsDynamicEx], so that it is possible to alter it during runtime. The default setting of thi

[edk2] [PATCH v4 0/7] Make OVMF fully working with Xen

2013-11-29 Thread Wei Liu
Hi all This is version 4 of this series. The first patch adds PcdPciDisableBusEnumeration in MdeModulePkg, which short-circuits full enumeration if set to true. We maintain some Xen specific functions at the moment, hopefully when QEMU / KVM figures out what to do with memory map we can refactor

Re: [edk2] [Xen-devel] [PATCH v3 8/8] OvmfPkg: enable Xen specific path

2013-11-29 Thread Wei Liu
On Thu, Nov 28, 2013 at 08:39:10PM -0800, Jordan Justen wrote: > On Tue, Nov 26, 2013 at 11:26 AM, Wei Liu wrote: > > This patch sets PcdPciDisableBusEnumeration to true then makes use of > > PublishPeiMemory and XenMemMapInitialization to construct memory map for > > Xen guest. > > > > Contribute

Re: [edk2] [PATCH v3 6/8] OvmfPkg: introduce PublishPeiMemory

2013-11-29 Thread Wei Liu
On Thu, Nov 28, 2013 at 08:31:11PM -0800, Jordan Justen wrote: [...] > > + VOID > > + ) > > +{ > > + EFI_STATUS Status; > > + EFI_PHYSICAL_ADDRESSMemoryBase; > > + UINT64 MemorySize; > > + UINT64 LowerMemorySize; > > + > > +

[edk2] StrHexToUint64 function

2013-11-29 Thread Nishit Patira
Hi, I am taking a string from console using int main(argc, **argv). The second argument is a hexadecimal number. Hence, I usse StrHexToUint64 to convert the string to hexadecimal number. UINT64 PhyAddress = 123456; printf("%d\n",PhyAddress); PhyAddress = StrHexToUint64((CONST CHAR16 *)argv[1]) ;

Re: [edk2] [PATCH] UefiCpuPkg/.../X64/ExceptionHandlerAsm.S: 64-bit relocation for variables

2013-11-29 Thread Laszlo Ersek
Hi Jeff, On 11/29/13 05:57, Fan, Jeff wrote: > Laszlo, > > I have check-in your patch at EDKII 14920. Thank you very much! > Due to there is no subject in your new patch, I added my comment. If > you do not like it, you could update the log message further. Actually, the patch did have a subje

[edk2] [UefiCpuPkg][Patch] Fix UINXGCC IA32 build issue

2013-11-29 Thread Fan, Jeff
Hi, all I just fixed one UNIXGCC IA32 build issue on UefiCpuPkg\Library\CpuExceptionHandlerLib\Ia32\ExceptionHandlerAsm.S, as below. If you have meet other build issue on other TOOL CHAIN, please tell me. Thanks! Fixed typo: HookAfterStubEnd should be HookAfterStubHeaderEnd. It will make UINI