Re: [edk2] [RFC 00/15] S3 suspend/resume for OVMF (WIP)

2013-12-26 Thread Yao, Jiewen
Hi I am not clear why you think EDKII S3 support requires SMM. Per current design EDKII S3 support only requires lockbox, because boot script will be saved there. SMM is just one possible implementation for lockbox. If OVMF has another way to create lockbox, it does not need SMM. Thank you Yao

Re: [edk2] [RFC 00/15] S3 suspend/resume for OVMF (WIP)

2013-12-26 Thread Jordan Justen
On Tue, Dec 3, 2013 at 12:23 AM, Laszlo Ersek wrote: > On 12/02/13 22:42, Jordan Justen wrote: >> Mike, >> >> Do you think it would be better for OVMF to add EMU SMM modules, or to >> fix the core S3 modules to not require SMM? > > Yes, that's the crucial question. My approach was to use whatever'

Re: [edk2] [PATCH v2 28/32] OvmfPkg: QemuFwCfgLib: implement for SEC

2013-12-26 Thread Jordan Justen
On Tue, Dec 24, 2013 at 8:50 AM, Laszlo Ersek wrote: > The QemuFwCfgSecLib library instance > - is stateless, > - has no library constructor, > - is available to SEC client code, > - must be queried with QemuFwCfgIsAvailable() before use, > - is restricted to SEC in order to limit the explicit que

Re: [edk2] [PATCH v2 24/32] OvmfPkg: QemuFwCfgLib: drop bogus dependency on UefiBootServicesTableLib

2013-12-26 Thread Jordan Justen
Reviewed-by: Jordan Justen I committed .inf portion of this. The .dsc parts are arguably a separate change anyhow. Thanks! On Tue, Dec 24, 2013 at 8:50 AM, Laszlo Ersek wrote: > This in turn requires resolving MemoryAllocationLib for DXE_SMM_DRIVERs. > > Contributed-under: TianoCore Contributi

Re: [edk2] [PATCH v2 04/32] OvmfPkg: PlatformPei: simplify memory range expressions in MemDetect()

2013-12-26 Thread Jordan Justen
Patches 4 & 5 Reviewed-by: Jordan Justen and committed. Thanks! On Tue, Dec 24, 2013 at 8:49 AM, Laszlo Ersek wrote: > Exploit that (MemoryBase + MemorySize) always equals LowerMemorySize. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Laszlo Ersek > --- > OvmfPk