Re: [edk2] [PATCH 1/2] edksetup.sh: Code style

2014-01-29 Thread Gao, Liming
Jordan: Thanks for your catch this typo. The patch is good to me. Reviewed-by: Liming Gao Thanks Liming -Original Message- From: Jordan Justen [mailto:jordan.l.jus...@intel.com] Sent: Thursday, January 30, 2014 5:02 AM To: edk2-devel@lists.sourceforge.net Subject: [edk2] [PATCH 1

Re: [edk2] Bug in TerminalDxe UnicodeFiFoRemoveOneKey() function

2014-01-29 Thread Gao, Liming
Alexei: I agree 1) and 2) are issues. But, they should not happen. Before UnicodeFiFoRemoveOneKey() is called, while statement has checked IsUnicodeFiFoEmpty() to make sure Fifo buffer is not empty. So, UnicodeFiFoRemoveOneKey() doesn't enter into Fifo empty case. Do you meet with the real pr

Re: [edk2] [PATCH] OvmfPkg/PlatformPei: Don't allocate ACPI NVS memory

2014-01-29 Thread Bill Paul
Of all the gin joints in all the towns in all the world, Laszlo Ersek had to walk into mine at 16:41:41 on Wednesday 29 January 2014 and say: > On 01/29/14 23:23, Jordan Justen wrote: > > Once we support ACPI S3, then we can restore this to > > being allocated as ACPI NVS memory. > > > > At that

Re: [edk2] [PATCH] OvmfPkg/PlatformPei: Don't allocate ACPI NVS memory

2014-01-29 Thread Laszlo Ersek
On 01/29/14 23:23, Jordan Justen wrote: > Once we support ACPI S3, then we can restore this to > being allocated as ACPI NVS memory. > > At that time we should also have a way to disable > S3 support in QEMU. When we detect that S3 is > disabled in QEMU, then we can allocate this as regular > Boot

[edk2] [PATCH 4/7] OvmfPkg/PlatformPei: Set PcdPciDisableBusEnumeration in InitializeXen

2014-01-29 Thread Jordan Justen
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jordan Justen --- OvmfPkg/PlatformPei/Platform.c | 4 +--- OvmfPkg/PlatformPei/Xen.c | 2 ++ 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/OvmfPkg/PlatformPei/Platform.c b/OvmfPkg/PlatformPei/Platform.c i

[edk2] [PATCH 0/7] Merge OvmfPkg/PlatformPei QEMU and Xen boot paths

2014-01-29 Thread Jordan Justen
This is a subset of the current ovmf-s3 branch at: https://github.com/jljusten/edk2.git The goal is to bring the Xen boot path back together with the QEMU boot path as much as possible. This will allow the rest of S3 support to not break Xen normal boots, and hopefully will allow Xen to support S3

[edk2] [PATCH 7/7] OvmfPkg/PlatformPei: Add RAM for Xen in InitializeRamRegions

2014-01-29 Thread Jordan Justen
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jordan Justen --- OvmfPkg/PlatformPei/MemDetect.c | 7 ++- OvmfPkg/PlatformPei/Platform.c | 7 +-- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/OvmfPkg/PlatformPei/MemDetect.c b/OvmfPkg/PlatformPei/M

[edk2] [PATCH 5/7] OvmfPkg/PlatformPei: Merge Xen support into MemMapInitialization

2014-01-29 Thread Jordan Justen
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jordan Justen --- OvmfPkg/PlatformPei/MemDetect.c | 6 +-- OvmfPkg/PlatformPei/Platform.c | 88 + OvmfPkg/PlatformPei/Platform.h | 5 +++ 3 files changed, 35 insertions(+), 64 deleti

[edk2] [PATCH 6/7] OvmfPkg/PlatformPei: Add InitializeRamRegions function

2014-01-29 Thread Jordan Justen
In the next commit we will update the Xen boot path to also use this function. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jordan Justen --- OvmfPkg/PlatformPei/MemDetect.c | 25 + OvmfPkg/PlatformPei/Platform.c | 2 +- OvmfPkg/PlatformPei/Pla

[edk2] [PATCH 3/7] OvmfPkg/PlatformPei: Add XenPublishRamRegions

2014-01-29 Thread Jordan Justen
This will be called from a unified MemDetect function. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jordan Justen --- OvmfPkg/PlatformPei/Platform.c | 39 +-- OvmfPkg/PlatformPei/Platform.h | 7 +++--- OvmfPkg/PlatformPei/Xen.c | 52 +++

[edk2] [PATCH 1/7] OvmfPkg/PlatformPei: Add mXen boolean to indicate Xen is running

2014-01-29 Thread Jordan Justen
Signed-off-by: Jordan Justen --- OvmfPkg/PlatformPei/Platform.c | 8 OvmfPkg/PlatformPei/Platform.h | 4 +++- OvmfPkg/PlatformPei/Xen.c | 5 - 3 files changed, 11 insertions(+), 6 deletions(-) diff --git a/OvmfPkg/PlatformPei/Platform.c b/OvmfPkg/PlatformPei/Platform.c index 10

[edk2] [PATCH 2/7] OvmfPkg/PlatformPei: Hide Xen Leaf details

2014-01-29 Thread Jordan Justen
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jordan Justen --- OvmfPkg/PlatformPei/Platform.c | 5 ++--- OvmfPkg/PlatformPei/Platform.h | 4 ++-- OvmfPkg/PlatformPei/Xen.c | 34 +++--- 3 files changed, 27 insertions(+), 16 deletions(-)

Re: [edk2] build run has duplicate consoles

2014-01-29 Thread Andrew Fish
On Jan 29, 2014, at 2:29 PM, John Davis wrote: > Hello > > I used ms windows to build the EDK II source. I have built the code using > ms visual studio 2010 premium and even done a build post cleanall. However > everytime I do a $ build run, I get two tianocore emulator screens. They > a

[edk2] build run has duplicate consoles

2014-01-29 Thread John Davis
Hello I used ms windows to build the EDK II source. I have built the code using ms visual studio 2010 premium and even done a build post cleanall. However everytime I do a $ build run, I get two tianocore emulator screens. They appear to be mirrored, but its confusing to have two windows. Is

[edk2] [PATCH] OvmfPkg/PlatformPei: Don't allocate ACPI NVS memory

2014-01-29 Thread Jordan Justen
Once we support ACPI S3, then we can restore this to being allocated as ACPI NVS memory. At that time we should also have a way to disable S3 support in QEMU. When we detect that S3 is disabled in QEMU, then we can allocate this as regular Boot Services Data memory. Contributed-under: TianoCore C

Re: [edk2] [PATCH] OvmfPkg: QemuBootOrder: handle QEMU's "-boot strict=on" option

2014-01-29 Thread Jordan Justen
Committed in r15197. Thanks! -Jordan On Tue, Jan 28, 2014 at 10:01 AM, Laszlo Ersek wrote: > When this option is passed to qemu, it appends the word HALT to the > "bootorder" fw_cfg file, as last entry. For example, > > /pci@i0cf8/ethernet@3/ethernet-phy@0 > /pci@i0cf8/scsi@4/disk@0,0 > HA

Re: [edk2] edk2/edksetup.sh patch to solve command line parameter

2014-01-29 Thread Jordan Justen
Whoops. Looks like I also submitted a patch for the missing s on BaseTools. On 2014-01-29 08:50:50, Leif Lindholm wrote: > Actually, there is another issue with the new edksetup.sh - it returns success > (0) regardless of whether the executions succeeds or not. > > The attached patch resolves bot

[edk2] [PATCH 2/2] edksetup.sh: Accept BaseTools parameter instead of BaseTool

2014-01-29 Thread Jordan Justen
Some build.sh scripts in the tree pass BaseTools when sourcing this script. (OvmfPkg/build.sh) Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jordan Justen --- edksetup.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/edksetup.sh b/edksetup.sh index

[edk2] [PATCH 1/2] edksetup.sh: Code style

2014-01-29 Thread Jordan Justen
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jordan Justen --- edksetup.sh | 28 +++- 1 file changed, 15 insertions(+), 13 deletions(-) diff --git a/edksetup.sh b/edksetup.sh index 39b76e1..7285dfe 100755 --- a/edksetup.sh +++ b/edksetup.sh @@ -4

Re: [edk2] OVMF on QEMU with recent EDK2 code

2014-01-29 Thread Bill Paul
Of all the gin joints in all the towns in all the world, Laszlo Ersek had to walk into mine at 15:10:12 on Tuesday 28 January 2014 and say: > On 01/28/14 21:55, Bill Paul wrote: > > I think part of my problem is that I don't quite understand how the > > firmware image volumes work either. You st

[edk2] [PATCH] Script for command when using for %x in *.txt return results with misplaced quotation marks and spaces

2014-01-29 Thread Leandro Becker
Hello, I made a small patch to the "for" command when used with "in" iterating files in a folder. (for %x in *.txt). The result values (%x) have misplaced quotation marks and some spaces. The patch is attached in this e-mail. --

[edk2] Bug in TerminalDxe UnicodeFiFoRemoveOneKey() function

2014-01-29 Thread Alexei Fedorov
I'm getting the following error for TerminalDxe when compiling with -O3 option: q:\edk2\MdeModulePkg\Universal\Console\TerminalDxe\TerminalConIn.c: In function 'UnicodeToEfiKey': q:\edk2\MdeModulePkg\Universal\Console\TerminalDxe\TerminalConIn.c:1571:8: error: 'UnicodeChar' may be used uninitial

Re: [edk2] edk2/edksetup.sh patch to solve command line parameter

2014-01-29 Thread Leif Lindholm
Hi Liming, This commit (15192) does not do what was described. It permits '. edksetup.sh BaseTool', rather than what was described in the text - '. edksetup.sh BaseTools'. (missing a trailing 's') Regards, Leif On 27 January 2014 07:46, Gao, Liming wrote: > Parmeshwr: > > Your patch is g

Re: [edk2] edk2/edksetup.sh patch to solve command line parameter

2014-01-29 Thread Leif Lindholm
Actually, there is another issue with the new edksetup.sh - it returns success (0) regardless of whether the executions succeeds or not. The attached patch resolves both of these issues. Contributed-under: TianoCore Contribution Agreement 1.0 On 29 January 2014 16:31, Leif Lindholm wrote: > H

Re: [edk2] Changes in Microsoft policy about approving uEFI drivers for signature

2014-01-29 Thread Richardson, Brian
The policy was last updated Dec 2013 ... http://blogs.msdn.com/b/windows_hardware_certification/archive/2013/12/03/microsoft-uefi-ca-signing-policy-updates.aspx Thanks ... br --- Brian Richardson -- brian.richard...@intel.com -- Twitter: intel_brian From: Yossef Efraim [mailto:yoss...@mellanox.co

[edk2] Changes in Microsoft policy about approving uEFI drivers for signature

2014-01-29 Thread Yossef Efraim
Hi all - Currently I am signing my UEFI driver by submitting the EFI file to MS site. https://login.live.com/ I have heard that MS are going to change the signing process \ approval policy ? Is it true ? If so - where can we find details regarding the new process \ policy? Thanks, Yossi

[edk2] [PATCH] Script for command when using for %x in *.txt return results with misplaced quotation marks and spaces

2014-01-29 Thread Leandro Becker
Hello, I made a small patch to the "for" command when used with "in" iterating files in a folder. (for %x in *.txt). The result values (%x) have misplaced quotation marks and some spaces. The patch is attached in this e-mail. I also have some modifications on the set command (set -p) to prompt