Re: [edk2] JPEG image block parsing error in HiiDataBase.

2014-03-11 Thread Dong, Eric
Hi Mars, I check the uefi spec, not found the yellow mark one, which version do you used? Also I check the similar code in this function, like EFI_HII_IIBT_EXT1, EFI_HII_IIBT_EXT2, they all include the size of the header. So I think current implementation is ok. Thanks, Eric From: Tian, Feng [

Re: [edk2] JPEG image block parsing error in HiiDataBase.

2014-03-11 Thread Tian, Feng
Hi, Mars We will review this patch and get back to you if we have feedback. Thanks Feng From: Mars Lin [mailto:mars_...@phoenix.com] Sent: Wednesday, March 12, 2014 11:05 To: edk2-devel@lists.sourceforge.net Subject: [edk2] 回覆: JPEG image block parsing error in HiiDataBase. Hi Feng, Any update

[edk2] 回覆: JPEG image block parsing error in HiiDataBase.

2014-03-11 Thread Mars Lin
Hi Feng, Any update for this proposed change to MdeModulePkg? Thanks, -Mars 寄件者: Mars Lin [mailto:mars_...@phoenix.com] 寄件日期: 2014年2月19日 下午 02:27 收件者: edk2-devel@lists.sourceforge.net 主旨: [edk2] JPEG image block parsing error in HiiDataBase. Dear MdeModulePkg maintainers, Please consider attached

Re: [edk2] EFIAPI Calling Convention

2014-03-11 Thread Andrew Fish
On Mar 11, 2014, at 6:17 PM, Ben Schroeder wrote: > Hi, > > Regarding EFIAPI calling convention, the UEFI 2.3.1 specification writes: > “All public interfaces of a UEFI module must follow the UEFI calling > convention. Public interfaces include the image entry point, UEFI event > handlers, a

[edk2] EFIAPI Calling Convention

2014-03-11 Thread Ben Schroeder
Hi, Regarding EFIAPI calling convention, the UEFI 2.3.1 specification writes: "All public interfaces of a UEFI module must follow the UEFI calling convention. Public interfaces include the image entry point, UEFI event handlers, and protocol member functions. The type EFIAPI is used to indicate

Re: [edk2] Success!

2014-03-11 Thread Bill Paul
> The miniPCIe to PCIe adapter that I ordered arrived today, and I'm happy to > report that I was able to use it in conjunction with my custom EFI option > ROM driver loaded onto an Intel 82574 ethernet card to un-brick my ExoPC > Slate tablet. > > I want to say thanks again for all those who ans

Re: [edk2] MdeModulePkg: (at least) 4 writes to Flash to update a NV variable in UpdateVariable()

2014-03-11 Thread Olivier Martin
Actually, I was assuming FVB was manipulating block size data. But I have just realized it can do byte size accesses... I would need to check what our driver does... Thanks, Olivier From: Tim Lewis [mailto:tim.le...@insyde.com] Sent: 11 March 2014 16:27 To: edk2-devel@lists.sourceforge.n

Re: [edk2] PCI OpROM driver

2014-03-11 Thread Igor Sharovar
Is your driver present in a list of PCI devices if you run "pci" Shell command? Igor Sharovar On Tue, Mar 11, 2014 at 7:46 AM, Neeraj Ladkani wrote: > Can you try disabling SATA/RAID and other on board storage controllers ? > there might be a possibility that BIOS finds block IO protocol produc

Re: [edk2] MdeModulePkg: (at least) 4 writes to Flash to update a NV variable in UpdateVariable()

2014-03-11 Thread Tim Lewis
Olivier - Actually, the current NOR technology assumes that we can do a byte level write only when changing bits from 1 to 0. In order to change from 0 to 1, you need to do an erase. I understood (correct me if I'm wrong) that NAND works the opposite way (can change from 0 to 1, but 1 to 0 requ

Re: [edk2] MdeModulePkg: (at least) 4 writes to Flash to update a NV variable in UpdateVariable()

2014-03-11 Thread Olivier Martin
As Andrew says you have assumed a hardware specific technology (you assume you have SPI Flash which allows to write a single byte in NV memory) to manage your atomicity. For most block devices, it is not possible to update a single byte without reading/writing the full block. It means the curr

Re: [edk2] PCI OpROM driver

2014-03-11 Thread Neeraj Ladkani
Can you try disabling SATA/RAID and other on board storage controllers ? there might be a possibility that BIOS finds block IO protocol produced by primary storage controller and skips loading your adapter's oprom (I am assuming your adapter is a storage adapter) since this is a desktop board Neer

Re: [edk2] edk2-devel Digest, Vol 50, Issue 79

2014-03-11 Thread Steven Kinney
Thanks Olivier, I am still defining the AMD SoC Platform Package and will wait to see if there are any other patches that need to be considered. Thanks for the advice, it is very much appreiciated. BR, Steve On 24 February 2014 13:17, wrote: > Send edk2-devel mailing list submission

[edk2] [PATCH] BaseTools: Added support to use GCC on Windows host (WINGCC)

2014-03-11 Thread Olivier Martin
WINGCC EDK2 toolchain enables building EDK2 with GCC toolchain on Windows host machine. It currently only supports ARM and AARCH64 architectures. Change-Id: I49eb3103137e5dd73c24a9596d25d4899ca76cfc Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Olivier Martin --- BaseToo

Re: [edk2] PCI OpROM driver

2014-03-11 Thread Zeng, Star
Some information for the first experiment. Follow the UEFI spec, gEfiGlobalVariableGuid is reserved for variables defined in UEFI spec. Suggestion to use another defined GUID for your TEST variable set experiment, for example, gEfiCallerIdGuid. Thanks, Star -Original Message- From: Onipc

Re: [edk2] PCI OpROM driver

2014-03-11 Thread Onipchuk Vladimir
Ok, I'm finally realized, that my driver doesn't start on the DH67BL ( http://www.intel.com/content/www/us/en/motherboards/desktop-motherboards/desktop-board-dh67bl.html ) My experiments: 1) This code at the Entrypoint: >  [...] > >  UINTN msgSize; >  CHAR16 msg[] = L"Hello, is this thi

Re: [edk2] MdeModulePkg/Universal/Network/SnpDxp/Station_address.c

2014-03-11 Thread Li, Ruth
Hi Ari, I tend to agree with your assessment. At the same time, I checked UEFI/code again. It turns out the PXE_OPFLAGS_STATION_ADDRESS_READ and PXE_OPFLAG_STATION_ADDRESS_WRITE are both defined as zero. [cid:image001.png@01CF3D40.5A455C10] So, using current BIOS FW, I thought there'll be no ac