[edk2] Resource leak at CoreSectionExtraction

2014-07-15 Thread Sergey Isakov
Dear sirs, Next report. File edk2/MdeModulePkg/Core/Dxe/SectionExtraction/CoreSectionExtraction.c: line 1007. Resource leak: CurrentChildNode - Status = CreateChildNode (SourceStream, 0, &CurrentChildNode); if (EFI_ERROR (Status)) { return Status; } - because the proc

Re: [edk2] Resource leak in BdsBoot.c

2014-07-15 Thread Dong, Eric
Sergey, Thanks for you to report this issue, we will follow up to clean it. Thanks, Eric From: Sergey Isakov [mailto:isakov...@bk.ru] Sent: Tuesday, July 15, 2014 9:26 PM To: edk2-devel@lists.sourceforge.net Subject: [edk2] Resource leak in BdsBoot.c Dear sirs, File edk2/IntelFrameworkModulePkg

[edk2] [BUG] Wrong usage sizeof(SIZE)

2014-07-15 Thread Sergey Isakov
Dear sirs, File edk2/OptionRomPkg/CirrusLogic5430Dxe/Edid.c line:143 ——— *EdidDataBlock = AllocateCopyPool ( sizeof (EDID_BLOCK_SIZE), ValidEdid ); —— There must be EDID_BLOCK_SIZE not sizeof(). Summary: Suspicious usage of 'sizeof

Re: [edk2] 回覆: Memory usage does not get updated when free the allocated one

2014-07-15 Thread Kinney, Michael D
Mars, If the actual memory usage when the OS is booted is less than the peak memory usage, then you could imagine a potential optimization from the current design. However, if there is a driver that allocates a large buffer for a short period of time that exceeds the current bin size, you can

Re: [edk2] Multiple DP commands included in EDK2

2014-07-15 Thread Bjorge, Erik C
The one in the shell package is for being built into the shell as a native command. The other is a standalone application. -Erik -Original Message- From: Blibbet [mailto:blib...@gmail.com] Sent: Wednesday, July 09, 2014 9:14 PM To: edk2-devel@lists.sourceforge.net Subject: [edk2] Multi

[edk2] Resource leak in BdsBoot.c

2014-07-15 Thread Sergey Isakov
Dear sirs, File edk2/IntelFrameworkModulePkg/Library/GenericBdsLib/BdsBoot.c Procedure BdsRefreshBbsTableForBoot() Local array DeviceType is AllocatePooled at line 1587 but never FreePooled. Sergey-- Want fast and easy ac

[edk2] 回覆: Memory usage does not get updated when free the allocated one

2014-07-15 Thread Mars Lin
Mike, Thanks for your comment. I have additional comment for current design. I know there is a requirement for UEFI S4 resume that need to have consistent memory map and OS using gBS->GetMemoryMap() for such check. CoreGetMemoryMap returned UEFI memory map based on the information conveyed via g