Got it. Thanks
From: Kinney, Michael D [mailto:michael.d.kin...@intel.com]
Sent: Saturday, August 16, 2014 1:01 AM
To: edk2-devel@lists.sourceforge.net
Subject: Re: [edk2] [Patch 1/2] [UefiCpuPkg] INF/DEC file updates to EDK II
packages
Liming,
I looks like the patch file contains the patch fil
On 15/08/14 12:50, Laszlo Ersek wrote:
> Sure.
>
> First, by looking at (and maybe posting) the debug log section that I
> described before.
>
> Second, by creating a virtual machine as follows:
> - ATA disk in IDE or AHCI mode, with booindex spec
> - ATA CD-ROM in IDE or AHCI mode, with bootinde
Reviewed-by: Jordan Justen
Liming, it sounds like you have looked over these too?
-Jordan
On Wed, Aug 13, 2014 at 2:49 AM, Laszlo Ersek wrote:
> Gcc-4.4 and VS2005 emit a number of false warnings, silence them.
>
> Jordan, can you please help apply these? I'd like the commit messages to
> stay
Thanks Daryl for the update :-)
> -Original Message-
> From: Mcdaniel, Daryl [mailto:daryl.mcdan...@intel.com]
> Sent: 15 August 2014 18:02
> To: Olivier Martin; Carsey, Jaben; edk2-devel@lists.sourceforge.net;
> Tian, Feng
> Cc: Brendan Jackman
> Subject: StdLib ARM issues (was RE: [edk2]
Liming,
I looks like the patch file contains the patch file
Index: UefiCpuPkg.patch
===
--- UefiCpuPkg.patch (revision 0)
+++ UefiCpuPkg.patch (working copy)
Can you remove and resend.
Thanks,
Mike
From: Gao, Liming [ma
Olivier,
These patches are in the queue along with many others.
I am currently working on "StdLib: the long standing build error". The patch,
by itself, causes a number of errors to ripple through the code. I am working
on them and as soon as all of my tests pass, the changes will be reviewed
Liming,
The patch looks good to me.
Reviewed-by: Michael Kinney
mailto:michael.d.kin...@intel.com>>
Mike
From: Gao, Liming [mailto:liming@intel.com]
Sent: Thursday, August 14, 2014 11:25 PM
To: edk2-devel@lists.sourceforge.net
Subject: Re: [edk2] [Patch 1/2] [MdePkg] INF/DEC file updates t
On 08/15/14 12:31, Reza Jelveh wrote:
> On 15/08/14 09:30, Laszlo Ersek wrote:
>> ... actually, I guess the goal of this patch is to enable AHCI mode ATA
>> devices while keeping IDE mode ATA devices working.
> Yes, this requires the IdeMode and SataController patches that come later.
> Otherwise,
On 15/08/14 09:30, Laszlo Ersek wrote:
> ... actually, I guess the goal of this patch is to enable AHCI mode ATA
> devices while keeping IDE mode ATA devices working.
Yes, this requires the IdeMode and SataController patches that come later.
Otherwise, IdeMode would not properly enumerate ide devic
On 15/08/14 04:51, Tian, Feng wrote:
> Hi, Reza
>
> This is a reason to use IdeInit.ChannelCount rather than the constant value.
> Some platforms may only expose one ide channel to external. By this way, we
> can skip unnecessary enumeration time according to platform policy.
>
> Do you see any
On 15/08/14 04:51, Tian, Feng wrote:
> Hi, Reza
>
> This is a reason to use IdeInit.ChannelCount rather than the constant value.
> Some platforms may only expose one ide channel to external. By this way, we
> can skip unnecessary enumeration time according to platform policy.
>
> Do you see any
On 15/08/14 04:53, Tian, Feng wrote:
> Hi, Reza
>
> Do you see any impact with original code? Why we don't use
> IdeInit.GetChannelInfo() is because we can get the info by AHCI PI register.
>
I get that, the GetChannelInfo in this context serves to initialize the
SataController, which should not
While you are here, I would be quite happy if you can review the following
simple patches:
- [PATCH] StdLib/LibC: Fix ARM symbol problems
- [PATCH] StdLibPrivateInternalFiles: Add AArch64 support
... they seems to be part of the packages you are responsible for
(http://tianocore.sourceforge.net/wik
I am quite happy to make some change to this library if Jaben agrees with
this change. But this patch only moves the existing BasePathLib from one
package to another one.
Olivier
> -Original Message-
> From: Ni, Ruiyu [mailto:ruiyu...@intel.com]
> Sent: 15 August 2014 06:23
> To: edk2-dev
This patch updates users of PcdVerifyNodeInList and
PcdValidateOrderedCollection.
Suggested-by: Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek
---
MdePkg/Library/BaseLib/BaseLib.inf| 2 ++
.../BaseOrderedCollect
Hess:
Does it include the fix to ignore [UserExtension]?
Thanks
Liming
From: Chen, Hesheng [mailto:hesheng.c...@intel.com]
Sent: Friday, August 15, 2014 3:48 PM
To: edk2-devel@lists.sourceforge.net
Subject: [edk2] [Patch][Basetools]Retire top level makefile on BaseTools
Hello all,
Could you hel
Hello all,
Could you help review this patch?
This patch is going to retire the top level makefile on BaseTools for
supporting a pure binary build without any complier.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Hess Chen mailto:hesheng.c...@intel.com>>
Best Regard
We will review it and get back to you.
Thanks,
Star
-Original Message-
From: reza.jel...@tuhh.de [mailto:reza.jel...@tuhh.de]
Sent: Friday, August 15, 2014 8:20 AM
To: edk2-devel@lists.sourceforge.net
Cc: ag...@suse.de
Subject: [edk2] [PATCH 2/6] DuetPkg: Move SataControllerDxe to PcAtChi
Yes. Please update them both.
Thanks
Liming
-Original Message-
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Friday, August 15, 2014 3:34 PM
To: edk2-devel@lists.sourceforge.net
Subject: Re: [edk2] [PATCH v3 2/3] MdePkg: introduce
BaseOrderedCollectionRedBlackTreeLib library insta
On 08/15/14 09:28, Gao, Liming wrote:
> Laszlo:
> FeaturePcd must use FeaturePcdGet() API to get its value.
The code does comply with this requirement.
> So, it is a good style to place it into [FeaturePcd] section.
> Those PCD in [Pcd] section uses PcdGetXXX() to get its value.
Alright,
On 08/15/14 09:12, Laszlo Ersek wrote:
> On 08/15/14 02:19, reza.jel...@tuhh.de wrote:
>> From: Reza Jelveh
>>
>> Removed:
>> - IntelFrameworkModulePkg/Bus/Pci/IdeBusDxe/IdeBusDxe.inf
>> (provides gEfiDiskInfoProtocolGuid, gEfiBlockIoProtocolGuid)
>> - PcAtChipsetPkg/Bus/Pci/IdeControllerDxe/IdeCo
Laszlo:
FeaturePcd must use FeaturePcdGet() API to get its value. So, it is a good
style to place it into [FeaturePcd] section.
Those PCD in [Pcd] section uses PcdGetXXX() to get its value.
Thanks
Liming
-Original Message-
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Friday,
On 08/15/14 02:19, reza.jel...@tuhh.de wrote:
> From: Reza Jelveh
>
> Removed:
> - IntelFrameworkModulePkg/Bus/Pci/IdeBusDxe/IdeBusDxe.inf
> (provides gEfiDiskInfoProtocolGuid, gEfiBlockIoProtocolGuid)
> - PcAtChipsetPkg/Bus/Pci/IdeControllerDxe/IdeControllerDxe.inf
> (provides gEfiIdeControllerI
23 matches
Mail list logo
