Re: [edk2] [PATCH] IntelFrameworkModulePkg/BdsDxe: Removed dependency on SmBios

2014-10-10 Thread Dong, Eric
Reviewed-by: Eric Dongmailto:eric.d...@intel.com>> Checked in code at r16207. Thanks, Eric From: Olivier Martin [mailto:olivier.mar...@arm.com] Sent: Friday, October 10, 2014 5:20 PM To: Fan, Jeff Cc: edk2-devel@lists.sourceforge.net Subject: [edk2] [PATCH] IntelFrameworkModulePkg/BdsDxe: Removed

Re: [edk2] [PATCH] Add .gitignore

2014-10-10 Thread Jordan Justen
On Fri, Oct 10, 2014 at 1:57 PM, Leif Lindholm wrote: > On Fri, Oct 10, 2014 at 01:46:04PM -0700, Jordan Justen wrote: >> On Fri, Oct 10, 2014 at 11:38 AM, Leif Lindholm >> wrote: >> > On Fri, Oct 10, 2014 at 07:09:22AM -0700, Jordan Justen wrote: >> > > >> > I guess that should be in addition to

Re: [edk2] [PATCH] Add .gitignore

2014-10-10 Thread Leif Lindholm
On Fri, Oct 10, 2014 at 01:46:04PM -0700, Jordan Justen wrote: > On Fri, Oct 10, 2014 at 11:38 AM, Leif Lindholm > wrote: > > On Fri, Oct 10, 2014 at 07:09:22AM -0700, Jordan Justen wrote: > > > >> > I guess that should be in addition to keeping it here? > > > >> > > > >> There is no need for thos

Re: [edk2] [PATCH] Add .gitignore

2014-10-10 Thread Jordan Justen
On Fri, Oct 10, 2014 at 11:38 AM, Leif Lindholm wrote: > On Fri, Oct 10, 2014 at 07:09:22AM -0700, Jordan Justen wrote: > > >> > I guess that should be in addition to keeping it here? > > >> > > >> There is no need for those patterns at the root if they are ignored at > > >> the BaseTools director

Re: [edk2] [PATCH] Add .gitignore

2014-10-10 Thread Leif Lindholm
On Fri, Oct 10, 2014 at 07:09:22AM -0700, Jordan Justen wrote: > >> > I guess that should be in addition to keeping it here? > >> > >> There is no need for those patterns at the root if they are ignored at > >> the BaseTools directory level. > > > > There is until the next BaseTools sync. > > Base

Re: [edk2] [PATCH] Add .gitignore

2014-10-10 Thread Jordan Justen
On Fri, Oct 10, 2014 at 6:24 AM, Leif Lindholm wrote: > On Thu, Oct 09, 2014 at 03:08:14PM -0700, Jordan Justen wrote: >> On Thu, Oct 9, 2014 at 7:45 AM, Leif Lindholm >> wrote: >> > On Thu, Oct 09, 2014 at 06:23:18AM -0700, Jordan Justen wrote: >> >> >>> diff --git a/.gitignore b/.gitignore >>

Re: [edk2] [PATCH] Add .gitignore

2014-10-10 Thread Leif Lindholm
On Thu, Oct 09, 2014 at 03:08:14PM -0700, Jordan Justen wrote: > On Thu, Oct 9, 2014 at 7:45 AM, Leif Lindholm > wrote: > > On Thu, Oct 09, 2014 at 06:23:18AM -0700, Jordan Justen wrote: > >> >>> diff --git a/.gitignore b/.gitignore > >> >>> new file mode 100644 > >> >>> index 000..8b6147b >

[edk2] [PATCH] IntelFrameworkModulePkg/BdsDxe: Removed dependency on SmBios

2014-10-10 Thread Olivier Martin
Dear IntelFrameworkModulePkg maintainer, Please find the attached patch that removes dependencies on SMBIOS in the Intel's BDS. Without this patch the BDS fails to start if there is no SmBios protocol. Smbios is only used to retrieve platform information. I do not think Smbios should be a hard r