Re: [edk2] [PATCH 1/3] MdePkg: UefiScsiLib: turn 'LUN encoding in CDB' into an explicit feature

2014-11-23 Thread Tian, Feng
Hi, Laszlo After checked history, I don't know why these old logic were introduced. R8330 is: ScsiIo->GetDeviceLocation (ScsiIo, &Target, &Lun); Cdb[1] = (UINT8) (Lun & EFI_SCSI_LOGICAL_UNIT_NUMBER_MASK); R8331 removed these two lines. But R8334 added it back with modified semantics: ScsiIo-

Re: [edk2] [PATCH] BaseTools: extend support for Windows hosted gcc to versions 4.4-4.7

2014-11-23 Thread Gao, Liming
The patch is good. Reviewed-by: Liming Gao -Original Message- From: Scott Duplichan [mailto:sc...@notabs.org] Sent: Thursday, November 20, 2014 7:55 AM To: edk2-devel@lists.sourceforge.net Cc: Liu, Yingke D; Gao, Liming Subject: [PATCH] BaseTools: extend support for Windows hosted gcc t

Re: [edk2] Change NT32 and DUET platform to use UefiShell instead of EDK Shell

2014-11-23 Thread Ni, Ruiyu
Update the patch to use OVMF style. From: Ni, Ruiyu [mailto:ruiyu...@intel.com] Sent: Friday, November 21, 2014 1:59 PM To: Dong, Eric Cc: edk2-devel@lists.sourceforge.net Subject: [edk2] Change NT32 and DUET platform to use UefiShell instead of EDK Shell Eric, Please check the attached patch. I

Re: [edk2] [PATCH] BaseTools: Fix ARM build failure with gcc 4.6

2014-11-23 Thread Liu, Yingke D
Scott, Patch looks good to me. Reviewed-by: Yingke Liu Dennis -Original Message- From: Scott Duplichan [mailto:sc...@notabs.org] Sent: Thursday, November 20, 2014 3:46 AM To: edk2-devel@lists.sourceforge.net Cc: Liu, Yingke D Subject: [PATCH] BaseTools: Fix ARM build failure with gcc 4

Re: [edk2] [PATCH v5 1/3] EmulatorPkg/Mpservice: fix wrong unsigned to signed variable transition

2014-11-23 Thread Chen, Fan
On Fri, 2014-11-21 at 15:01 -0800, Jordan Justen wrote: > On 2014-11-20 21:09:03, Chen Fan wrote: > > Because TimeoutInMicrosecsond is a unsigned value, converting it to > > signed value will cause the data region changed. so this patch fix > > that. > > > > Contributed-under: TianoCore Contribut