Re: [edk2] [PATCH] IntelFrameworkModulePkg: Fixed unbalanced TPL raise/restore.

2014-12-23 Thread Li, Elvin
The patch has been checked into 16556. Thanks Elvin From: Li, Elvin [mailto:elvin...@intel.com] Sent: Tuesday, December 23, 2014 5:01 PM To: edk2-devel@lists.sourceforge.net Subject: Re: [edk2] [PATCH] IntelFrameworkModulePkg: Fixed unbalanced TPL raise/restore. It looks good to me. Reviewed-

Re: [edk2] registering stop() service in driverbinding protocol, but disconnect doesn; t call stop() service.

2014-12-23 Thread Tian, Feng
Ritul, The error msg of shell shows the handle you passed in doesn't install device path protocol. So there are two possibilities: one is you don't install device path protocol on the handle, the another is the handle you passed into Disconnect/Reconnect cmd is not a device/controller handle.

Re: [edk2] registering stop() service in driverbinding protocol, but disconnect doesn; t call stop() service.

2014-12-23 Thread Andrew Fish
> On Dec 23, 2014, at 1:22 AM, ritul guru (riguru) wrote: > > Thanks. > Controller has DP protocol installed, and also I added it in > InstallMultipleProtocolInterfaces() in start() service, > > Are you creating a new handle? Otherwise known as a bus driver? Thanks, Andrew Fish > > Ri

Re: [edk2] registering stop() service in driverbinding protocol, but disconnect doesn; t call stop() service.

2014-12-23 Thread ritul guru (riguru)
Thanks. Controller has DP protocol installed, and also I added it in InstallMultipleProtocolInterfaces() in start() service, Ritul From: Tian, Feng [mailto:feng.t...@intel.com] Sent: Tuesday, December 23, 2014 12:59 PM To: edk2-devel@lists.sourceforge.net Subject: Re: [edk2] registering stop()

Re: [edk2] [PATCH] IntelFrameworkModulePkg: Fixed unbalanced TPL raise/restore.

2014-12-23 Thread Li, Elvin
It looks good to me. Reviewed-by: Elvin Li mailto:olivier.mar...@arm.com>> Thanks Elvin From: Mars Lin [mailto:mars_...@phoenix.com] Sent: Tuesday, December 23, 2014 4:17 PM To: edk2-devel@lists.sourceforge.net Subject: [edk2] [PATCH] IntelFrameworkModulePkg: Fixed unbalanced TPL raise/restore

[edk2] [PATCH] IntelFrameworkModulePkg: Fixed unbalanced TPL raise/restore.

2014-12-23 Thread Mars Lin
File affected: IntelFrameworkModulePkg\Csm\BiosThunk\KeyboardDxe\BiosKeyboard.c Please review the patch which address the potential system TPL does not been restore. This patch make sure the TPL been raised and restored in pair. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-