[edk2] [PATCH] Don't require optional ISCSI negotiation responses.

2015-01-23 Thread Roy Franz
Some simple value negotiation responses are optional, in particular DataPDUInOrder and DataSequenceInOrder. If we send "Yes", then the response from the target is optional, and the Linux target implementation does not return a response. Contributed-under: TianoCore Contribution Agreement 1.0 Signe

Re: [edk2] [PATCH] ShellPkg: refine command line parsing

2015-01-23 Thread Carsey, Jaben
Yes, for non-script files. It works in scripts already. From: Shah, Tapan [mailto:tapands...@hp.com] Sent: Friday, January 23, 2015 12:39 PM To: Carsey, Jaben; Peterson, Joe Cc: edk2-devel@lists.sourceforge.net Subject: RE: [PATCH] ShellPkg: refine command line parsing Importance: High Are you g

Re: [edk2] [PATCH v1 12/21] Ovmf/Xen: fix pointer to int cast in XenBusDxe

2015-01-23 Thread Laszlo Ersek
On 01/23/15 16:03, Ard Biesheuvel wrote: > On ARM, xen_pfn_t is 64 bits but the size of a pointer is only > 32 bits, so casting between them needs to go via (UINTN) > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ard Biesheuvel > --- > OvmfPkg/XenBusDxe/GrantTable.c

Re: [edk2] [PATCH v1 13/21] Ovmf/Xen: move arch specific hypercall implementation to XenHypercallLib

2015-01-23 Thread Laszlo Ersek
On 01/23/15 19:24, Stefano Stabellini wrote: > On Fri, 23 Jan 2015, Ard Biesheuvel wrote: >> For future ARM/AArch64 support in the XenBus code, move the implementation >> of hypercall invocation to a dedicated library. The use of a library rather >> than just an arch specific source in XenBusDxe.in

Re: [edk2] [PATCH v1 11/21] Ovmf/Xen: move Xen interface version to

2015-01-23 Thread Laszlo Ersek
On 01/23/15 16:03, Ard Biesheuvel wrote: > Tiancore has its private copy of the Xen headers, and all drivers > that depend on it should use the same Xen interface version, so > let's move the #define to xen.h itself. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ard

Re: [edk2] [PATCH v1 06/21] ArmVirtualizationPkg: add padding to FDT allocation

2015-01-23 Thread Laszlo Ersek
On 01/23/15 16:02, Ard Biesheuvel wrote: > Our primary user QEMU/mach-virt presents us with a FDT blob padded > to 64 KB with plenty of room to set additional properties. However, > in the general case, we should only add properties after making sure > there is enough room available. > > Contribut

Re: [edk2] [PATCH v1 10/21] ArmVirtualizationPkg: Xen/PV relocatable platformlib instance

2015-01-23 Thread Laszlo Ersek
On 01/23/15 16:02, Ard Biesheuvel wrote: > Add a ArmPlatformLib instance that can deal with the self relocation > and truly dynamic discovery of system RAM base and size. > > Signed-off-by: Ard Biesheuvel > --- > .../AARCH64/MemnodeParser.S| 232 > + >

Re: [edk2] [PATCH v1 09/21] ArmVirtualizationPkg: implement custom MemoryInitPeiLib

2015-01-23 Thread Laszlo Ersek
some notes On 01/23/15 16:02, Ard Biesheuvel wrote: > This implements a MemoryInitPeiLib instance that differs from the > stock ArmPlatformPkg version only in the fact that it does not remove > the memory used by the flash device (FD). The reason is that, when using > PrePi, the DXE core is starte

Re: [edk2] Information on UEFI application

2015-01-23 Thread Larry Cleeton
The Windows APIs are: GetFirmwareEnvironmentVariable() GetFirmwareEnvironmentVariableEx() SetFirmwareEnvironmentVariable() SetFirmwareEnvironmentVariableEx() They work in WinPE. Note that on a regular Windows SKU and possibly even WinPE you need to add “SeSystemEnvironmentPrivilege” to your pro

Re: [edk2] [PATCH] ShellPkg: refine command line parsing

2015-01-23 Thread Shah, Tapan
Are you going to post a separate review request to handle non-existent environment variable in quoted string? From: Carsey, Jaben [mailto:jaben.car...@intel.com] Sent: Friday, January 23, 2015 2:30 PM To: Shah, Tapan; Peterson, Joe Cc: edk2-devel@lists.sourceforge.net; Carsey, Jaben Subject: RE:

Re: [edk2] [PATCH] ShellPkg: refine command line parsing

2015-01-23 Thread Carsey, Jaben
Update. Now does these cases: echo "hi" echo "hi hi" echo "hi echo "hi^"" echo "^hi" echo "%uefiversion%%test%" echo "hi^^" echo "hi^^^"" echo hi^^ echo hi^^^ echo "testing is "done"" echo "hi^" echo =L"this is a test" echo this" is a "test please re-review. -Jaben From: Shah, Tapan [mailto:

Re: [edk2] [PATCH v1 05/21] ArmVirtualizationPkg: use a HOB to store device tree blob

2015-01-23 Thread Laszlo Ersek
I reviewed the discussion under http://lists.linaro.org/pipermail/linaro-uefi/2014-December/000601.html and I can see that you addressed all points there. I have some new comments: On 01/23/15 16:02, Ard Biesheuvel wrote: > Instead of using a dynamic PCD, store the device tree address in a HOB >

Re: [edk2] [PATCH v1 04/21] ArmVirtualizationPkg: move early UART discovery to PlatformPeim

2015-01-23 Thread Laszlo Ersek
On 01/23/15 16:02, Ard Biesheuvel wrote: > This is partially motivated by the desire to use PrePi in a virt > environment, and in that configuration, ArmPlatformInitializeMemory() > is never called. But actually, this is a more suitable place anyway. > > Contributed-under: TianoCore Contribution A

Re: [edk2] [PATCH v1 03/21] ArmVirtualizationPkg: replace instance of FixedPcdGet()

2015-01-23 Thread Laszlo Ersek
On 01/23/15 16:02, Ard Biesheuvel wrote: > This removes an instance of FixedPcdGet () so that the self relocating > PrePi instance can poke another value into it. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ard Biesheuvel > --- > .../ArmVirtualizationPkg/Library/

Re: [edk2] [PATCH v1 20/21] ArmVirtualizationPkg/VirtFdtDxe: wire up XenBusDxe to "xen, xen" DT node

2015-01-23 Thread Ard Biesheuvel
On 23 January 2015 at 19:03, Stefano Stabellini wrote: > On Fri, 23 Jan 2015, Ard Biesheuvel wrote: >> This patchs adds support to VirtFdtDxe for the Xen DT node which >> contains the base address of the Grant Table. This data is communicated >> to XenBusDxe using a XENIO_PROTOCOL instance. >> >>

Re: [edk2] [PATCH v1 02/21] ArmVirtualizationPkg: add GICv3 detection to VirtFdtDxe

2015-01-23 Thread Laszlo Ersek
On 01/23/15 16:02, Ard Biesheuvel wrote: > This adds support for detecting the presence of a GICv3 interrupt > controller from the device tree, and recording its distributor > base address in a PCD. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ard Biesheuvel > ---

Re: [edk2] [PATCH v1 17/21] Ovmf/Xen: add Xen PV console SerialPortLib driver

2015-01-23 Thread Ard Biesheuvel
On 23 January 2015 at 18:54, Stefano Stabellini wrote: > On Fri, 23 Jan 2015, Ard Biesheuvel wrote: >> This implements a SerialPortLib instance that wires up to the >> PV console ring used by domU guests. Also imports the required >> upstream Xen io/console.h header. >> >> Contributed-under: Tiano

Re: [edk2] [PATCH v1 01/21] ArmPkg: allow HYP timer interrupt to be omitted

2015-01-23 Thread Laszlo Ersek
On 01/23/15 16:02, Ard Biesheuvel wrote: > The DT binding for the ARM generic timer describes the secure, > non-secure, virtual and hypervisor timer interrupts, respectively. > However, under virtualization, only the virtual timer is usable, and > the device tree may omit the hypervisor timer inter

Re: [edk2] Information on UEFI application

2015-01-23 Thread Andrew Fish
> On Jan 23, 2015, at 5:26 AM, Koen Mulderij wrote: > > Hi group, > > I’m sorry to bother you with my question, but I hope you can help me. > I want to develop an WinPE-based application to modify the bootorder of a > UEFI-firmware computer. > Unfortunately Microsoft only seems to provide inf

Re: [edk2] [PATCH v1 00/21] Xen/ARM guest support

2015-01-23 Thread Laszlo Ersek
On 01/23/15 16:02, Ard Biesheuvel wrote: > ArmPkg/Drivers/TimerDxe/TimerDxe.c | 14 +- > .../ArmVirtualizationPkg/ArmVirtualizationPkg.dec | 3 +- > .../ArmVirtualizationPkg/ArmVirtualizationQemu.dsc | 3 - > .../ArmVirtualizationPkg/ArmVirtualizationXen.dsc | 274 +

Re: [edk2] [PATCH v1 15/21] Ovmf/Xen: implement XenHypercallLib for ARM

2015-01-23 Thread Ard Biesheuvel
On 23 January 2015 at 18:41, Stefano Stabellini wrote: > On Fri, 23 Jan 2015, Ard Biesheuvel wrote: >> This patch adds an implementation of XenHypercallLib for both >> AArch64 and AArch32 execution modes on ARM systems. >> >> Contributed-under: TianoCore Contribution Agreement 1.0 >> Signed-off-by

Re: [edk2] [PATCH v1 03/21] ArmVirtualizationPkg: replace instance of FixedPcdGet()

2015-01-23 Thread Olivier Martin
Reviewed-By: Olivier Martin > -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: 23 January 2015 15:03 > To: edk2-devel@lists.sourceforge.net; ler...@redhat.com; Olivier > Martin; roy.fr...@linaro.org; leif.lindh...@linaro.org; > stefano.stabell...@eu.cit

Re: [edk2] [PATCH v1 02/21] ArmVirtualizationPkg: add GICv3 detection to VirtFdtDxe

2015-01-23 Thread Olivier Martin
Reviewed-By: Olivier Martin > -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: 23 January 2015 15:03 > To: edk2-devel@lists.sourceforge.net; ler...@redhat.com; Olivier > Martin; roy.fr...@linaro.org; leif.lindh...@linaro.org; > stefano.stabell...@eu.cit

Re: [edk2] [PATCH v1 01/21] ArmPkg: allow HYP timer interrupt to be omitted

2015-01-23 Thread Olivier Martin
Reviewed-By: Olivier Martin > -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: 23 January 2015 15:03 > To: edk2-devel@lists.sourceforge.net; ler...@redhat.com; Olivier > Martin; roy.fr...@linaro.org; leif.lindh...@linaro.org; > stefano.stabell...@eu.cit

[edk2] [PATCH v1 08/21] ArmPlatformPkg/PrePi: add a relocatable version of PrePi

2015-01-23 Thread Ard Biesheuvel
This patch introduces a relocatable PrePi, which can execute from arbitrary offsets in RAM. This is intendend to be run from a boot loader which passes a description of the actual platform in a device tree, for instance. Signed-off-by: Ard Biesheuvel --- ArmPlatformPkg/PrePi/AArch64/ModuleEntryP

[edk2] [PATCH v1 04/21] ArmVirtualizationPkg: move early UART discovery to PlatformPeim

2015-01-23 Thread Ard Biesheuvel
This is partially motivated by the desire to use PrePi in a virt environment, and in that configuration, ArmPlatformInitializeMemory() is never called. But actually, this is a more suitable place anyway. Contributed-under: TianoCore Contribution Agreement 1.0 Reviewed-by: Laszlo Ersek Signed-off-

[edk2] [PATCH v1 20/21] ArmVirtualizationPkg/VirtFdtDxe: wire up XenBusDxe to "xen, xen" DT node

2015-01-23 Thread Ard Biesheuvel
This patchs adds support to VirtFdtDxe for the Xen DT node which contains the base address of the Grant Table. This data is communicated to XenBusDxe using a XENIO_PROTOCOL instance. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- .../ArmVirtualizationPk

[edk2] [PATCH v1 05/21] ArmVirtualizationPkg: use a HOB to store device tree blob

2015-01-23 Thread Ard Biesheuvel
Instead of using a dynamic PCD, store the device tree address in a HOB so that we can also run under a configuration that does not support dynamic PCDs. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- .../ArmVirtualizationPkg/ArmVirtualizationPkg.dec |

[edk2] [PATCH v1 10/21] ArmVirtualizationPkg: Xen/PV relocatable platformlib instance

2015-01-23 Thread Ard Biesheuvel
Add a ArmPlatformLib instance that can deal with the self relocation and truly dynamic discovery of system RAM base and size. Signed-off-by: Ard Biesheuvel --- .../AARCH64/MemnodeParser.S| 232 + .../AARCH64/RelocatableVirtHelper.S| 161

[edk2] [PATCH v1 06/21] ArmVirtualizationPkg: add padding to FDT allocation

2015-01-23 Thread Ard Biesheuvel
Our primary user QEMU/mach-virt presents us with a FDT blob padded to 64 KB with plenty of room to set additional properties. However, in the general case, we should only add properties after making sure there is enough room available. Contributed-under: TianoCore Contribution Agreement 1.0 Signed

[edk2] [PATCH v1 19/21] Ovfm/Xen: add a Vendor Hardware device path GUID for the XenBus root

2015-01-23 Thread Ard Biesheuvel
On non-PCI Xen guests (such as ARM), the XenBus root is not a PCI device but an abstract 'platform' device. Add a dedicated Vendor Hardware device path GUID to identify this node. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- OvmfPkg/Include/Guid/XenBu

[edk2] [PATCH v1 17/21] Ovmf/Xen: add Xen PV console SerialPortLib driver

2015-01-23 Thread Ard Biesheuvel
This implements a SerialPortLib instance that wires up to the PV console ring used by domU guests. Also imports the required upstream Xen io/console.h header. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- OvmfPkg/Include/IndustryStandard/Xen/io/console

[edk2] [PATCH v1 21/21] ArmVirtualizationPkg: add platform description for Xen guests

2015-01-23 Thread Ard Biesheuvel
This adds the .dsc and .fdf descriptions to build a UEFI image that is bootable by a Xen guest on 64-bit ARM (AArch64) Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- .../ArmVirtualizationPkg/ArmVirtualizationXen.dsc | 274 + .../ArmVirt

[edk2] [PATCH v1 02/21] ArmVirtualizationPkg: add GICv3 detection to VirtFdtDxe

2015-01-23 Thread Ard Biesheuvel
This adds support for detecting the presence of a GICv3 interrupt controller from the device tree, and recording its distributor base address in a PCD. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- .../ArmVirtualizationPkg/VirtFdtDxe/VirtFdtDxe.c

[edk2] [PATCH v1 14/21] Ovmf/Xen: allow non-PCI usage of XenBusDxe

2015-01-23 Thread Ard Biesheuvel
While Xen on Intel uses a virtual PCI device to communicate the base address of the grant table, the ARM implementation uses a DT node, which is fundamentally incompatible with the way XenBusDxe is implemented, i.e., as a UEFI Driver Model implementation for a PCI device. To allow the non-PCI impl

[edk2] [PATCH v1 12/21] Ovmf/Xen: fix pointer to int cast in XenBusDxe

2015-01-23 Thread Ard Biesheuvel
On ARM, xen_pfn_t is 64 bits but the size of a pointer is only 32 bits, so casting between them needs to go via (UINTN) Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- OvmfPkg/XenBusDxe/GrantTable.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(

[edk2] [PATCH v1 15/21] Ovmf/Xen: implement XenHypercallLib for ARM

2015-01-23 Thread Ard Biesheuvel
This patch adds an implementation of XenHypercallLib for both AArch64 and AArch32 execution modes on ARM systems. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- .../Include/IndustryStandard/Xen/arch-arm/xen.h| 436 + OvmfPkg/Incl

[edk2] [PATCH v1 11/21] Ovmf/Xen: move Xen interface version to

2015-01-23 Thread Ard Biesheuvel
Tiancore has its private copy of the Xen headers, and all drivers that depend on it should use the same Xen interface version, so let's move the #define to xen.h itself. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- OvmfPkg/Include/IndustryStandard/Xen

[edk2] [PATCH v1 16/21] Ovmf/Xen: add ARM and AArch64 support to XenBusDxe

2015-01-23 Thread Ard Biesheuvel
This patch adds support to XenBusDxe for executing on ARM and AArch64 machines (the former only when built with GCC). Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- OvmfPkg/XenBusDxe/AtomicsGcc.c | 44 + OvmfPkg/

[edk2] [PATCH v1 01/21] ArmPkg: allow HYP timer interrupt to be omitted

2015-01-23 Thread Ard Biesheuvel
The DT binding for the ARM generic timer describes the secure, non-secure, virtual and hypervisor timer interrupts, respectively. However, under virtualization, only the virtual timer is usable, and the device tree may omit the hypervisor timer interrupt. (Other timer interrupts cannot be omitted s

[edk2] [PATCH v1 09/21] ArmVirtualizationPkg: implement custom MemoryInitPeiLib

2015-01-23 Thread Ard Biesheuvel
This implements a MemoryInitPeiLib instance that differs from the stock ArmPlatformPkg version only in the fact that it does not remove the memory used by the flash device (FD). The reason is that, when using PrePi, the DXE core is started immediately and never returns so there is no reason to pres

[edk2] [PATCH v1 13/21] Ovmf/Xen: move arch specific hypercall implementation to XenHypercallLib

2015-01-23 Thread Ard Biesheuvel
For future ARM/AArch64 support in the XenBus code, move the implementation of hypercall invocation to a dedicated library. The use of a library rather than just an arch specific source in XenBusDxe.inf allows us to move the constructor dependency on the gXenInfoGuid HOB to the library implementatio

[edk2] [PATCH v1 07/21] ArmPlatformPkg/PrePi: factor out FixedPcdGetXX() and ArmIsMpCore()

2015-01-23 Thread Ard Biesheuvel
As a prepatory step towards introduction of a relocatable PrePi instance, this patch makes some code changes that should not affect operation, but will allow the relocable PrePi to work correctly. First of all, instances of FixedPcdGetXX() are replaced by their PcdGetXX() counterparts. This will e

[edk2] [PATCH v1 18/21] Ovmf/Xen: implement dummy RealTimeClockLib for Xen

2015-01-23 Thread Ard Biesheuvel
This implements a dummy RealTimeClockLib for Xen, as there is no guest interface to access the time kept by Xen that can be shared between UEFI and the OS. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- .../XenRealTimeClockLib/XenRealTimeClockLib.c

[edk2] [PATCH v1 00/21] Xen/ARM guest support

2015-01-23 Thread Ard Biesheuvel
This series implements support for executing Tianocore inside a Xen guest domain on 64-bit ARM systems (AArch64) The first part addresses ARM platform specifics, primarily to allow a Tianocore binary image to be runtime relocatable, and execute from DRAM. The second part refactors the XenBus supp

[edk2] [PATCH v1 03/21] ArmVirtualizationPkg: replace instance of FixedPcdGet()

2015-01-23 Thread Ard Biesheuvel
This removes an instance of FixedPcdGet () so that the self relocating PrePi instance can poke another value into it. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- .../ArmVirtualizationPkg/Library/ArmVirtualizationPlatformLib/Virt.c| 2 +- 1 file c

Re: [edk2] [PATCH 0/3] UDF/ECMA-167 file system support

2015-01-23 Thread Paulo Alcantara
Hi Feng, On Wed, January 21, 2015 9:15 pm, Tian, Feng wrote: > Partition driver owner is reviewing your patch, will get back to you when > he have feedback. Alright. Thanks for the information and looking forward to it. >>From my side, a straightforward issue about device path was raised >> befo

[edk2] Information on UEFI application

2015-01-23 Thread Koen Mulderij
Hi group, I'm sorry to bother you with my question, but I hope you can help me. I want to develop an WinPE-based application to modify the bootorder of a UEFI-firmware computer. Unfortunately Microsoft only seems to provide information on how to change their OS-bootloader. Could you point me to

Re: [edk2] Could anyone show me the roadmap of UEFI SCT?

2015-01-23 Thread Olivier Martin
And the branch 'sct-next' to support all the other architectures (including ARM 32-bit and ARM 64-bit). From: Jin, Eric [mailto:eric@intel.com] Sent: 23 January 2015 08:25 To: guoh...@huawei.com Cc: edk2-devel@lists.sourceforge.net Subject: Re: [edk2] Could anyone show me the roadmap of UE

[edk2] 答复: Could anyone show me the roadmap of UEFI SCT?

2015-01-23 Thread Guoheyi
Hi Eric Thanks for your reply! Is there branch for ARM64 platform? 发件人: Jin, Eric [mailto:eric@intel.com] 发送时间: 2015年1月23日 16:25 收件人: Guoheyi 抄送: edk2-devel@lists.sourceforge.net 主题: Re: [edk2] Could anyone show me the roadmap of UEFI SCT? The repository is correct. Please switch to the

Re: [edk2] Could anyone show me the roadmap of UEFI SCT?

2015-01-23 Thread Jin, Eric
The repository is correct. Please switch to the branch sct-next-IA to get the latest source if you want to validate on IA platform. Best Regards Eric -Original Message- From: Guoheyi [mailto:guoh...@huawei.com] Sent: Friday, January 23, 2015 15:35 To: edk2-devel@lists.sourcefo

Re: [edk2] [PATCH] Fix the Windows MNW2/Vlv2TbltDevicePkg build

2015-01-23 Thread Wei, David
Thanks. I am OK with this new patch. Reviewed-by: David Wei Thanks, David -Original Message- From: Bruce Cran [mailto:bruce.c...@gmail.com] Sent: Friday, January 23, 2015 3:35 PM To: edk2-devel@lists.sourceforge.net Cc: He, Tim; Wei, David; Wu, Mike Subject: Re: [edk2] [PATCH] Fix the