Re: [edk2] [PATCH v2 11/28] ArmVirtualizationPkg/PciHostBridgeDxe: translate addresses for IO and MMIO

2015-02-21 Thread Alexander Graf
On 22.02.15 01:03, Peter Maydell wrote: > On 22 February 2015 at 02:19, Laszlo Ersek wrote: >> So, before I try to reason more about code that's potentially not >> covered by this patch, let me ask this -- is it conceivable that in the >> following: >> >> // >> // child

Re: [edk2] [PATCH v2 11/28] ArmVirtualizationPkg/PciHostBridgeDxe: translate addresses for IO and MMIO

2015-02-21 Thread Peter Maydell
On 22 February 2015 at 02:19, Laszlo Ersek wrote: > So, before I try to reason more about code that's potentially not > covered by this patch, let me ask this -- is it conceivable that in the > following: > > // > // child base cpu base > //type add

Re: [edk2] [PATCH v2 11/28] ArmVirtualizationPkg/PciHostBridgeDxe: translate addresses for IO and MMIO

2015-02-21 Thread Laszlo Ersek
(CC'ing Will Deacon, author of "drivers/pci/host/pci-host-generic.c") On 02/21/15 18:19, Laszlo Ersek wrote: > Alex, [...] > I'm having second thoughts if the translation in this patch covers > everything. I'm wondering if the translation should also be done for the > gDS->XxxxMemorySpace() call

Re: [edk2] [PATCH v2 11/28] ArmVirtualizationPkg/PciHostBridgeDxe: translate addresses for IO and MMIO

2015-02-21 Thread Laszlo Ersek
Alex, On 02/18/15 22:08, Laszlo Ersek wrote: > Unlike the one in PcAtChipsetPkg, our PciHostBridgeDxe module must handle > address space translation. IO and MMIO addresses expressed in the > respective apertures may be mapped to different bases in CPU address > space, and in case of IO, they actua