[edk2] Macro expansion in DEC

2015-02-28 Thread apianti
Hello, I'm having an issue with macro expansion in DEC files, I am not understanding why the macro OUTPUT_DIRECTORY is not being expanded under the [includes] section. I have generated some headers into the build directory, which can be changed to a different location and this location is pass

Re: [edk2] possible off-by-one in CoreAllocateSpace()?

2015-02-28 Thread Laszlo Ersek
On 02/28/15 10:22, Gao, Liming wrote: > Laszlo: > So, your proposal is to change line 1158if ((Entry->BaseAddress + > Length) > MaxAddress) { ==>if ((Entry->BaseAddress + Length - 1) > > MaxAddress) {? Yes, it is. I didn't write a patch up-front because the code change is eas

Re: [edk2] [PATCH v5a 14/29] MdePkg/BaseSynchronizationLib: Add InterlockedCompareExchange16

2015-02-28 Thread Laszlo Ersek
On 02/28/15 08:58, Ard Biesheuvel wrote: > On 27 February 2015 at 22:55, Kinney, Michael D > wrote: >> Laszlo, >> >> You are welcome to apply the patch set. Thanks for helping. >> > > Thanks everyone > > I have updated the public branch with Michael's R-b and rebased onto > the latest upstream

Re: [edk2] SEC PPI HOBs

2015-02-28 Thread Andrew Fish
> On Feb 27, 2015, at 11:18 PM, Gao, Liming wrote: > > PI spec doesn’t define the clear rule. So, this is not PeiCore compliant > issue. > Like Jiewen say, Early PEIM that run before CAR down can consume data from > PPI and publish HOB. It should be platform PEIM, because we can’t assure the

Re: [edk2] possible off-by-one in CoreAllocateSpace()?

2015-02-28 Thread Gao, Liming
Laszlo: So, your proposal is to change line 1158if ((Entry->BaseAddress + Length) > MaxAddress) { ==>if ((Entry->BaseAddress + Length - 1) > MaxAddress) {? Thanks Liming -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Thursday, February 26, 2015

Re: [edk2] [PATCH v5a 14/29] MdePkg/BaseSynchronizationLib: Add InterlockedCompareExchange16

2015-02-28 Thread Ard Biesheuvel
On 27 February 2015 at 22:55, Kinney, Michael D wrote: > Laszlo, > > You are welcome to apply the patch set. Thanks for helping. > Thanks everyone I have updated the public branch with Michael's R-b and rebased onto the latest upstream (1 minor merge conflict) Regards, Ard, > -Original M