Re: [edk2] [Patch 8/16] UefiCpuPkg: Avoid "error A2085" when DDK3790 tool chain is used

2015-04-06 Thread Fan, Jeff
It works. Thanks! Reviewed-by: Jeff Fan -Original Message- From: Scott Duplichan [mailto:sc...@notabs.org] Sent: Monday, April 06, 2015 12:23 PM To: edk2-devel@lists.sourceforge.net; Ma, Maurice; Agyeman, Prince Subject: [edk2] [Patch 8/16] UefiCpuPkg: Avoid "error A2085" when DDK3790 t

Re: [edk2] [Patch 9/16] MdePkg: Fix build fail when DDK3790 tool chain is used

2015-04-06 Thread Gao, Liming
Scott: Your patch is good. Reviewed-by: Liming Gao Thanks Liming -Original Message- From: Scott Duplichan [mailto:sc...@notabs.org] Sent: Monday, April 06, 2015 12:25 PM To: edk2-devel@lists.sourceforge.net; Ma, Maurice; Agyeman, Prince; Gao, Liming Subject: [Patch 9/16] MdePkg: Fix b

Re: [edk2] [PATCH] MdeModulePkg: Move Include/Guid/LzmaDecompress.h under MdeModulePkg

2015-04-06 Thread Gao, Liming
Jordan: This is a block issue, I just want to fix it ASAP. Like you say, it is a wrong commit, not a bug. So, I take responsibility to fix it. Thanks Liming -Original Message- From: Justen, Jordan L Sent: Tuesday, April 07, 2015 9:21 AM To: Gao, Liming; edk2-devel@lists.sourceforge.n

Re: [edk2] [PATCH] MdeModulePkg: Move Include/Guid/LzmaDecompress.h under MdeModulePkg

2015-04-06 Thread Jordan Justen
On 2015-04-06 17:30:41, Gao, Liming wrote: > Jordan: > Thanks for your report. I just fix it at 17121. Sorry for my mistake. Darn, I was was going to cleanup the extra tailing whitespace during the move too. :) May I ask why you didn't just give an r-b for my patch? -Jordan > -Original M

Re: [edk2] [PATCH] MdeModulePkg: Move Include/Guid/LzmaDecompress.h under MdeModulePkg

2015-04-06 Thread Gao, Liming
Jordan: Thanks for your report. I just fix it at 17121. Sorry for my mistake. Thanks Liming -Original Message- From: Justen, Jordan L Sent: Tuesday, April 07, 2015 7:24 AM To: edk2-devel@lists.sourceforge.net Cc: Justen, Jordan L; Gabriel L. Somlo; Gao, Liming Subject: [PATCH] MdeModul

[edk2] [PATCH] MdeModulePkg: Move Include/Guid/LzmaDecompress.h under MdeModulePkg

2015-04-06 Thread Jordan Justen
In r17111, this file was mistakenly added to Include/Guid/LzmaDecompress.h rather than MdeModulePkg/Include/Guid/LzmaDecompress.h. I guess r17110 broke this. (Meaning the r17111 change should have happened before r17110 anyway...) Reported-by: "Gabriel L. Somlo" Cc: "Gabriel L. Somlo" Cc: Limin

[edk2] syslinux vs. OVMF

2015-04-06 Thread BALATON Zoltan
Hello, I'm trying to find out why pxe boot with syslinux is failing on QEMU with OVMF. The problem is already described here in detail: http://www.syslinux.org/archives/2014-November/022804.html Since it is reported to work on real hardware (presumably with a different UEFI implementation) I s

[edk2] Lzma GUID patch breaks OVMF build

2015-04-06 Thread Gabriel L. Somlo
Hi Liming, Starting with commit 584ea2c8ef87e06cee9142966620db7a5bd2d344 ("IntelFrameworkModulePkg: Move LzmaDecompress GUID", a.k.a. https://svn.code.sf.net/p/edk2/code/trunk/edk2@17110 6f19259b-4bc3-4df7-8a09-765794883524), I can no longer build OVMF (on Linux/X64): build -a X64 -t GCC4

Re: [edk2] [Patch 0/16] CorebootModulePkg/CorebootPayloadPkg: Various improvements

2015-04-06 Thread Scott Duplichan
Jordan Justen [mailto:jordan.l.jus...@intel.com] wrote: ]Sent: Monday, April 06, 2015 02:07 AM ]To: Scott Duplichan; edk2-devel@lists.sourceforge.net; 'Maurice Ma'; 'Prince Agyeman' ]Subject: Re: [edk2] [Patch 0/16] CorebootModulePkg/CorebootPayloadPkg: Various improvements ] ]Wow. By the looks

Re: [edk2] [Patch 16/16] CorebootModulePkg: Add EFIAPI to CbDxeEntryPoint to fix gcc compile fail

2015-04-06 Thread Jordan Justen
On 2015-04-05 21:32:54, Scott Duplichan wrote: > Make CbDxeEntryPoint function match the AutoGen.h prototype to avoid gcc > compile fail. The change is only needed for gcc builds because EFIAPI ABI > differs from the default ABI when gcc is used. No. This change is needed because EFIAPI should be

Re: [edk2] [Patch 1/16] CorebootModulePkg: Add EFIAPI to OnReadyToBoot to fix gcc compile fail

2015-04-06 Thread Jordan Justen
On 2015-04-05 21:14:03, Scott Duplichan wrote: > Make OnReadyToBoot function match the prototype in UefiLib.h. The change > only affects gcc builds because EFIAPI ABI differs from the default ABI > when building with gcc. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by:

Re: [edk2] [Patch 0/16] CorebootModulePkg/CorebootPayloadPkg: Various improvements

2015-04-06 Thread Jordan Justen
Wow. By the looks of this, you somehow managed to create and send all these patches with svn. I applaud your effort, but I hope you consider looking into git for future work to save yourself time. :) One request I have is to make patch 1 throgh 16 all reply to patch 0. This will keep all code revi