Re: [edk2] MdeModulePkg:Fix required in NvmExpressDxe driver

2015-04-13 Thread Baban Devkate
Feng, you were correct that we don't need the 2nd Prp list for such case( case 3) and the last entry in the first Prp list points to last 4K range rather than a pointer to next Prp List). Which is inline with NVMe spec. *Excerpt from NVM Express 1.1, section 4.3:* The first PRP entry contained wi

Re: [edk2] [PATCH 06/11] MdePkg: Add definitions related to UEFI 2.5's ESRT feature.

2015-04-13 Thread Gao, Liming
Jones: EFI System Resource Table is a GUID definition. We suggest using a separate head file to include its definition and place this header file into MdePkg/Include/Guid directory. And, you also add a protocol definition to manage its contents. But, I can't find this protocol from UEFI spe

Re: [edk2] [PATCH 04/11] MdePkg: Remove EFI_CAPSULE_TABLE definition from UefiSpec.h

2015-04-13 Thread Gao, Liming
Jones: UEFI spec defines this table format. And, for the a capsule with CAPSULE_FLAGS_POPULATE_SYSTEM_TABLE flag, the firmware should install this system table for it. So, I don't agree this change. UEFI spec 7.5.3 Update Capsule: A capsule which has the CAPSULE_FLAGS_POPULATE_SYSTEM_TABLE Fl

Re: [edk2] [PATCH] MdePkg/DevicePath.h: Fixed 'integer operation result is out of range'

2015-04-13 Thread Gao, Liming
Martin: Yes. We will use Mike patch to be consistent with other places. I will add Tested-by: Olivier Martin Thanks Liming -Original Message- From: Olivier Martin [mailto:olivier.mar...@arm.com] Sent: Thursday, April 09, 2015 7:24 PM To: Laszlo Ersek; Kinney, Michael D Cc: edk2-deve

Re: [edk2] [PATCH v4 2/5] ArmPlatformPkg: do not fulfil MemoryInitPeiLib dependency directly via .c file

2015-04-13 Thread Ard Biesheuvel
On 13 April 2015 at 17:24, Olivier Martin wrote: > Reviewed-By: Olivier Martin > Thanks! So, since the breakage caused by this patch has apparently been solved, are you ok to merge this? I have updated my public branch: https://git.linaro.org/people/ard.biesheuvel/uefi-next.git/shortlog/refs/he

Re: [edk2] [PATCH v4 2/5] ArmPlatformPkg: do not fulfil MemoryInitPeiLib dependency directly via .c file

2015-04-13 Thread Olivier Martin
Reviewed-By: Olivier Martin -Original Message- From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] Sent: 09 April 2015 12:29 To: edk2-devel@lists.sourceforge.net; ler...@redhat.com; Olivier Martin Cc: roy.fr...@linaro.org; leif.lindh...@linaro.org; Ard Biesheuvel Subject: [PATCH v4 2/

Re: [edk2] [PATCH v4 1/5] ArmVirtualizationPkg: make ArmVirtualizationMemoryInitPeiLib the default

2015-04-13 Thread Olivier Martin
Reviewed-by: Olivier Martin -Original Message- From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] Sent: 09 April 2015 12:29 To: edk2-devel@lists.sourceforge.net; ler...@redhat.com; Olivier Martin Cc: roy.fr...@linaro.org; leif.lindh...@linaro.org; Ard Biesheuvel Subject: [PATCH v4 1/