[edk2] [PATCH] MdeModulePkg/SetupBrowserDxe: Action should supports QuestionConfig is not 0 but the content string is NULL case

2015-04-16 Thread Dong, Eric
Hi Liming, Please find the attached patch that enhance the action opcode to supports QuestionConfig is not 0 but the content string is NULL case. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Eric Dong Thanks, Eric Question Config NULL check .patch Description: Quest

Re: [edk2] XHCI data transfer size

2015-04-16 Thread Tian, Feng
XhcCheckUrbResult() will get invoked many times for single request. XhcExecTransfer () will be only invoked once for single request. The URB is a software data structure and will be persistent till the request is finished. It will record how many bytes has been transferred. You can think the lo

[edk2] Python script could call LocateHandle function?

2015-04-16 Thread TigerLiu
Hi, experts: I have a question about Python script. Could I call Boot Service function in Python script? Such as: Call BootServices->LocateHandle() in python script! Best wishes, 本邮件仅针对指定的收件人发送并可能含有保密或专有内容。任何非指定收件人所为之查阅、转发或使用本信息是不被允许的。 如果您误收到本邮件,请立即告知发件人并删除本邮件及所有附件。谢谢! The information transmitte

Re: [edk2] XHCI data transfer size

2015-04-16 Thread Anbazhagan, Baraneedharan
But the total data transfer size is accumulated based on input DataLen field and if there is more than 1 transfer block(64K+ data request), then the return size is not correct. CheckedUrb->Completed += (CheckedUrb->DataLen - EvtTrb->Lenth); From: Tian, Feng [mailto:feng.t...@intel.com] Sent: Th

Re: [edk2] XHCI data transfer size

2015-04-16 Thread Tian, Feng
Hi, Baranee The intention of XhcCheckUrbResult() and XhcExecTransfer() is to traverse all received events and accumulate these received data lengths for a URB request to see if it matches with requested data length. The members of URB, such as ->Completed, -> Finished, -> StartDone and -> End

Re: [edk2] [Patch] BaseTools: Ignore BaseTools/Bin/Win32 directory in .gitignore

2015-04-16 Thread Jordan Justen
Reviewed-by: Jordan Justen On 2015-04-16 08:43:52, Liming Gao wrote: > Configure .gitignore file to ignore Bin/Win32 and Lib directory. > Those two directories are generated when BaseTools are compiled at Windows. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Limin

[edk2] [Patch] BaseTools: Ignore BaseTools/Bin/Win32 directory in .gitignore

2015-04-16 Thread Liming Gao
Configure .gitignore file to ignore Bin/Win32 and Lib directory. Those two directories are generated when BaseTools are compiled at Windows. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Liming Gao --- .gitignore | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.git

Re: [edk2] hide message ASSERT

2015-04-16 Thread S . Vieira
Gao How i do it ? 'cause, only cite TimerLib is *.dsc TimerLib|MdePkg/Library/BaseTimerLibNullTemplate/BaseTimerLibNullTemplate.inf and this file *.dsc is of the UDK in the section GENERIC MODULES. So Can you give me a example ?! Thanks.

Re: [edk2] hide message ASSERT

2015-04-16 Thread Gao, Liming
Vieira: BaseTimerLibNull is empty implementation. You should use the real TimerLib. Thanks Liming -Original Message- From: S.Vieira [mailto:jwvsan...@outlook.com] Sent: Thursday, April 16, 2015 11:07 PM To: edk2-devel@lists.sourceforge.net Subject: Re: [edk2] hide message ASSERT @Mart

Re: [edk2] hide message ASSERT

2015-04-16 Thread S . Vieira
@Martin the message is: "ASSERT UDK2014.SP1/MdPkg/Library/BaseTimerLibNull.c(35) : ((BOOLEAN)(0==1))" the code: UINTN amountNode; UINTN indice; EFI_STATUS Status,StatusPor

Re: [edk2] hide message ASSERT

2015-04-16 Thread S . Vieira
Thanks @Martin, I will see and try fix this. -- BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT Develop your own process in accordance with the BPMN 2 standard Learn Process modeling best practices with Boni

Re: [edk2] hide message ASSERT

2015-04-16 Thread Olivier Martin
The best approach to hide ASSERT is to fix them! ASSERT() messages are generally critical errors that must be fixed to prevent unexpected code flow. Or you can disable ASSERT by unsetting BIT4 of the PCD gEfiMdePkgTokenSpaceGuid.PcdDebugPropertyMask. -Original Message- From: S.Vieira [m

Re: [edk2] [PATCH] Network/TcpDxe: Fix some grammar and converge formatting of the two versions of TcpInput.c

2015-04-16 Thread BALATON Zoltan
On Thu, 16 Apr 2015, Fu, Siyuan wrote: > Most of the patch is ok but there are a little problem about the opening > brace place after a complex predicate expression. See details in > https://github.com/tianocore/tianocore.github.io/wiki/Code-Style-C > In EDK2_C_Coding_Standards_2_0, Rule 5.1.1.1-

Re: [edk2] [PATCH]IntelFrameworkPkg: Fix typo in LegacyBios.h.

2015-04-16 Thread Wei Li
Shumin, Thanks for fixing this issue. The non-ascii character may be caused by copying the update from original patch... ThanksElvin Li From: shumin@intel.com To: hot.t...@intel.com Date: Thu, 16 Apr 2015 02:40:45 + CC: edk2-devel@lists.sourceforge.net; jeff@intel.com Subject: Re: [e