Re: [edk2] [Patch V3 01/16] Copy PCD from IntelFrameworkModulePkg to MdePkg and MdeModulePkg

2015-04-28 Thread Gao, Liming
Reviewed-by: Liming Gao -Original Message- From: Ni, Ruiyu Sent: Monday, April 27, 2015 10:54 AM To: edk2-devel@lists.sourceforge.net Cc: Ni, Ruiyu; Gao, Liming Subject: [Patch V3 01/16] Copy PCD from IntelFrameworkModulePkg to MdePkg and MdeModulePkg to MdePkg: PcdHardwareErrorRecordL

Re: [edk2] [Patch] MdePkg: Update comments for DriverSupportedEfiVersion.FirmwareVersion

2015-04-28 Thread Gao, Liming
Reviewed-by: Liming Gao -Original Message- From: Ni, Ruiyu Sent: Tuesday, April 28, 2015 2:33 PM To: edk2-devel@lists.sourceforge.net Cc: Ni, Ruiyu; Gao, Liming Subject: [Patch] MdePkg: Update comments for DriverSupportedEfiVersion.FirmwareVersion Contributed-under: TianoCore Contribut

Re: [edk2] [Patch]UEFI 2.5 - IPV6 support from UNDI

2015-04-28 Thread Fu, Siyuan
Ting The patch is good to me. Reviewed-by: Fu Siyuan From: Ye, Ting [mailto:ting...@intel.com] Sent: Monday, April 27, 2015 2:21 PM To: edk2-devel@lists.sourceforge.net Subject: [edk2] [Patch]UEFI 2.5 - IPV6 support from UNDI Patches to support new AIP information block - IPV6 support from UND

[edk2] MdeModulePkg: Should have a library to produce the gEfiMemoryTypeInformationGuid HOB driven by PCDs.

2015-04-28 Thread Andrew Fish
I noticed the EmbeddedPkg has PCDs to set the gEfiMemoryTypeInformationGuid HOB (EFI_MEMORY_TYPE_INFORMATION array) default values. Given this is something that needs to get tuned per platform it seems like we should have PCD values. I noticed some ARM platforms use PCD values, but a lot of plat

[edk2] [Patch] EdkCompatibilityPkg: Add PersistentMemory definition

2015-04-28 Thread Liming Gao
Include this definition to make sure EfiMaxMemoryType be same value in EDKII and ECP code. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Liming Gao Reviewed-by: Star Zeng --- EdkCompatibilityPkg/Foundation/Efi/Include/EfiTypes.h | 3 ++- 1 file changed, 2 insertions(+)

[edk2] [patch] MdeModulePkg: fix some issues in ScsiDisk to co-work with UFS stack

2015-04-28 Thread Feng Tian
The changes in ScsiDisk include: 1. Add UFS disk info support. 2. Remove the wrong block size calculation. 3. Get sense data for TEST_UNIT_READY cmd immediately rather than sending a REQUEST_SENSE cmd again. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Feng Tian Reviewe

[edk2] The 1st DXE Core memory allocation does not follow the S4 bucketing scheme?

2015-04-28 Thread Andrew Fish
Is it “functioning as intended” for the 1st memory allocation of the DXE Core to not come from gMemoryTypeInformation/mMemoryTypeStatistics buckets? I walked the allocations in the debugger and the 1st call to CoreAddMemoryDescriptor() (from the end of CoreInitializeMemoryServices(), and it is

Re: [edk2] Disconnect a driver without to use Shell command

2015-04-28 Thread KSilva
I need only find the handle of the Sata controller and to use for example: gBS->DisconnectController( HandleSataController, NULL, NULL ); can you help me?

Re: [edk2] BdsSetMemoryTypeInformationVariable

2015-04-28 Thread Brian J. Johnson
On 04/21/2015 09:34 PM, Nelson, Eric wrote: > This routine triggers a reset after every time mytstapp.efi runs, when > any UEFI Boot Manager boot option is subsequently selected (EFI Shell, > OS loader, mytstapp.efi, etc.) > > I drove myself crazy for a while making sure that mytstapp.efi doesn’t >

[edk2] [PATCH] IntelFspPkg adds dual FSP binaries support

2015-04-28 Thread Yao, Jiewen
IntelFpsPkg: add dual FSP binaries support. There are two FSP images at different locations in a flash (one factory version is read only and other in updatable version) TempRamInit, FspMemoryInit and TempRamExit are executed from factory version and FspSiliconInit/NotifyPhase will be executed

[edk2] error handling in driver binding start routine

2015-04-28 Thread sushma s
Hello, We are working on UEFI driver for HBA card. The card supports booting in both UEFI and legacy BIOS mode. In the start() routine of the driver binding protocol, we are checking if the HBA card has initialized successfully and is ready to accept the commands. If there are any issues with HBA

[edk2] [Patch] MdePkg: Refine EFI_DARKGRAY definition and comments for EFI_TEXT_ATTR

2015-04-28 Thread Ruiyu Ni
It's to follow UEFI spec 2.5. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni CC: Eric Jin --- MdePkg/Include/Protocol/SimpleTextOut.h | 17 ++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/MdePkg/Include/Protocol/SimpleTextOut.h

Re: [edk2] [PATCH 2/2] efinet: fix lost packets due to active MNP instances

2015-04-28 Thread Michael Chang
On Tue, Apr 28, 2015 at 02:03:02PM +0800, Michael Chang wrote: > On Mon, Apr 27, 2015 at 02:47:16PM +0800, Michael Chang wrote: > Apparently I made a mistake here, the exclusive open still fails. > > It's in your new patch that can survive the failed exlusive open by > keep using the non-exclusive

[edk2] [Patch] MdePkg, MdeModulePkg: Remove EFI_NOT_FOUND from I2C IO protocol

2015-04-28 Thread Ruiyu Ni
It's to follow the PI spec 1.4. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni CC: Jie Lin --- MdeModulePkg/Bus/I2c/I2cDxe/I2cBus.c | 1 - MdePkg/Include/Protocol/I2cIo.h | 3 +-- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/MdeModulePkg/Bu

[edk2] [Patch 2/2] MdeModulePkg: Remove EFI_ABORTED from I2C protocols per PI spec 1.4.

2015-04-28 Thread Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni CC: Jie Lin --- MdeModulePkg/Bus/I2c/I2cDxe/I2cBus.c | 4 +--- MdeModulePkg/Bus/I2c/I2cDxe/I2cHost.c | 4 +--- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/MdeModulePkg/Bus/I2c/I2cDxe/I2cBus.c b/M

[edk2] [Patch 1/2] MdePkg: Remove EFI_ABORTED from I2C protocols per PI spec 1.4.

2015-04-28 Thread Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni CC: Jie Lin --- MdePkg/Include/Protocol/I2cHost.h | 10 +- MdePkg/Include/Protocol/I2cIo.h | 4 +--- 2 files changed, 2 insertions(+), 12 deletions(-) diff --git a/MdePkg/Include/Protocol/I2cHost.h b/Mde

[edk2] [Patch 0/2] Remove EFI_ABORTED from I2C protocols

2015-04-28 Thread Ruiyu Ni
The patch follows PI Spec 1.4 to remove EFI_ABORTED return status from I2C protocols. Ruiyu Ni (2): MdePkg: Remove EFI_ABORTED from I2C protocols per PI spec 1.4. MdeModulePkg: Remove EFI_ABORTED from I2C protocols per PI spec 1.4. MdeModulePkg/Bus/I2c/I2cDxe/I2cBus.c | 4 +--- MdeModulePk

Re: [edk2] [Patch V3 12/16] MdeModulePkg: Add BdsDxe driver and PlatformBootManagerNull library.

2015-04-28 Thread Dong, Eric
I think you can remove the "return" for functions which use void as return value. Reviewed-by: Eric Dong -Original Message- From: Ni, Ruiyu Sent: Monday, April 27, 2015 10:54 AM To: edk2-devel@lists.sourceforge.net Cc: Ni, Ruiyu; Dong, Eric Subject: [Patch V3 12/16] MdeModulePkg: Add Bd

Re: [edk2] [Patch V3 15/16] MdeModulePkg: Add DriverHealthManagerDxe driver.

2015-04-28 Thread Dong, Eric
Reviewed-by: Eric Dong -Original Message- From: Ni, Ruiyu Sent: Monday, April 27, 2015 10:54 AM To: edk2-devel@lists.sourceforge.net Cc: Ni, Ruiyu; Dong, Eric Subject: [Patch V3 15/16] MdeModulePkg: Add DriverHealthManagerDxe driver. DriverHealthManagerDxe provides a driver health manag

Re: [edk2] [Patch V3 13/16] MdeModulePkg: Add BootManagerMenuApp.

2015-04-28 Thread Dong, Eric
Reviewed-by: Eric Dong -Original Message- From: Ni, Ruiyu Sent: Monday, April 27, 2015 10:54 AM To: edk2-devel@lists.sourceforge.net Cc: Ni, Ruiyu; Dong, Eric Subject: [Patch V3 13/16] MdeModulePkg: Add BootManagerMenuApp. BootManagerMenuApp only provides a very simple UI showing all th

Re: [edk2] [Patch V3 14/16] IntelFrameworkModulePkg: Add LegacyBootManagerLib.

2015-04-28 Thread Dong, Eric
Reviewed-by: Eric Dong -Original Message- From: Ni, Ruiyu Sent: Monday, April 27, 2015 10:54 AM To: edk2-devel@lists.sourceforge.net Cc: Ni, Ruiyu; Dong, Eric Subject: [Patch V3 14/16] IntelFrameworkModulePkg: Add LegacyBootManagerLib. LegacyBootManagerLib is a NULL class library to wor

Re: [edk2] [Patch V3 16/16] Remove obsolete PCDs (new ones are moved to MdePkg and MdeModulePkg)

2015-04-28 Thread Dong, Eric
Reviewed-by: Eric Dong -Original Message- From: Ni, Ruiyu Sent: Monday, April 27, 2015 10:54 AM To: edk2-devel@lists.sourceforge.net Cc: Ni, Ruiyu; Dong, Eric Subject: [Patch V3 16/16] Remove obsolete PCDs (new ones are moved to MdePkg and MdeModulePkg) Including: PcdHardwareErrorRec