[edk2] [Patch 2/2] CorebootModulePkg/CbParseLib: coding style update

Replace tab with space. Remove the sapce at the end of lines. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Guo Dong --- CorebootModulePkg/Library/CbParseLib/CbParseLib.c | 492 +++--- 1 file changed, 245 insertions(+), 247 deletions(-) diff --git a/Core

[edk2] [Patch 0/2] Support coreboot IMD in CorebootModulePkg

Make CorebootModulePkg to be used with the current upstream coreboot Guo Dong (2): CorebootModulePkg/CbParseLib: Support current coreboot IMD CorebootModulePkg/CbParseLib: coding style update CorebootModulePkg/Include/Coreboot.h | 21 +- CorebootModulePkg/Library/CbParseLib/CbPars

[edk2] [Patch 1/2] CorebootModulePkg/CbParseLib: Support current coreboot IMD

The latest coreboot use IMD (In Memory Database) to report Tables. This patch adds IMD support in UEFI payload. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Guo Dong --- CorebootModulePkg/Include/Coreboot.h | 21 - CorebootModulePkg/Library/CbParseL

Re: [edk2] [patch] FatPkg: Add RecoveryBlockIo2Ppi support

Feng, Could you please refine the code to merge the UpdateBlocksAndVolumes() and UpdateBlocksAndVolumes2() to one function? They are almost identical. I recommend to change NotifyDescriptor to NotifyDescriptor[2] instead of adding a new field NotifyDescriptor2 to the structure PEI_FAT_PRIVATE_DAT

Re: [edk2] Debug UEFI driver using EDKII

Thanks Ray Please find attached udk-debugger-trace.log, .. WELCOME TO EFI WORLD! Send INIT break packet and try to connect the HOST (Intel(R) UDK Debugger Tool v1.4) ... Received data [ fe 3f 06 00 59 ba ] Request = 0 m_WaitingAckForReset is 0 when INIT_BRE

[edk2] [PATCH] MdeModulePkg: Fix potential buffer overflow issues

Fix potential buffer overflow issues. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Eric Dong mailto:eric.d...@intel.com>> Index: Universal/DisplayEngineDxe/FormDisplay.h === --- Universal/DisplayEngine

[edk2] [PATCH] MdeModulePkg: Should enumarate all string packages in one driver

For current logic, it will directly return fail if it not found the keyword in this string package. This logic has potential issue, it may skip the true package which has the keyword. This patch fixed this issue. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Eric Don

[edk2] [Patch] Edk2: Update Edk2Setup.bat

Fix the issue when configure X64 NT32, replace NT32_X64 by NT32_64 env. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Liming Gao --- Edk2Setup.bat | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/Edk2Setup.bat b/Edk2Setup.bat index cadc271..75

Re: [edk2] [Patch 2/2] Replace tab with space and remove the space at the end of lines.

Sure. Thanks for reminder. Will have a check whether it could be replaced when doing cleanup. Thanks, Guo -Original Message- From: Ma, Maurice Sent: Tuesday, May 19, 2015 1:16 PM To: Dong, Guo; Justen, Jordan L Cc: edk2-devel@lists.sourceforge.net Subject: RE: [edk2] [Patch 2/2] Replace

Re: [edk2] Debug UEFI driver using EDKII

Kan, Please edit SoftDebugger.ini to set [Debug]/Trace = 0x1f. Then send out the C:\Users\\udk-debugger-trace.log. Thanks, Ray From: Kan Qiu [mailto:kan...@osbase.com] Sent: Monday, May 18, 2015 11:49 AM To: edk2-devel@lists.sourceforge.net Subject: Re: [edk2] Debug UEFI driver using EDKII Hi Ru

[edk2] [Patch] MdeModulePkg: Fix PciBus hang issue

LocatePciExpressCapabilityRegBlock () doesn't check the return status of Pci.Read(). Certain platform's PciRootBridge.Pci.Read() doesn't support PCIE access causing the CapabilityEntry not updated. If the uninitialized CapabilityEntry equals to a big enough initial value, the while-loop will nev

Re: [edk2] [Patch 2/2] Replace tab with space and remove the space at the end of lines.

Hi, Guo, The CalculateSum16() function in BaseLib might not have the identical functionality as the CbCheckSum16(). Please check it. Regards, Maurice -Original Message- From: Dong, Guo Sent: Monday, May 18, 2015 10:07 PM To: Justen, Jordan L; edk2-devel@lists.sourceforge.net; Ma, Mauri

Re: [edk2] [Patch 2/2] Replace tab with space and remove the space at the end of lines.

OK. I will create another patch to clean up the code for EDKII coding style after this fix check in. And will replace CbCheckSum16() using the CalculateSum16() in BaseLib, etc. Thanks, Guo -Original Message- From: Justen, Jordan L Sent: Tuesday, May 19, 2015 12:47 PM To: edk2-devel@list

Re: [edk2] question about size of OMVF.fd

Why you don't you want to use this? OvmfPkg/build.sh -n 20 This will build with -b DEBUG, and build a 2MB image. Mostly I'm not sure why you don't want a DEBUG build. You want the slightly different settings that a RELEASE build otherwise provides? -Jordan On 2015-05-18 20:07:17, lidonglin wro

Re: [edk2] [Patch 2/2] Replace tab with space and remove the space at the end of lines.

By the way, thank you for fixing this! Parts of the code were difficult to read with tabs. One more patch idea is below. On 2015-05-18 08:29:34, Guo Dong wrote: > Signed-off-by: Guo Dong > --- > CorebootModulePkg/Library/CbParseLib/CbParseLib.c | 498 > +++--- > 1 file changed,

Re: [edk2] [edk] [patch] IntelFspPkg - FspSecCore add AsmGetFspBaseAddressNoStack and AsmGetFspInfoHeaderNoStack

On 2015-05-18 17:40:10, Yao, Jiewen wrote: >IntelFspPkg - FspSecCore add AsmGetFspBaseAddressNoStack and > AsmGetFspInfoHeaderNoStack Line is 81 columns. It should also be "IntelFspPkg/FspSecCore:" rather than "IntelFspPkg - FspSecCore" https://github.com/tianocore/tianocore.github.io/wiki/C

Re: [edk2] Basetools update for CLAN support

On 2015-05-18 19:12:49, Liu, Yingke D wrote: > Hello, > > Attached patch implemented BUILDRULEORDER feature. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Yingke Liu Dennis, Can you send this as a new patch separate from this thread? I think the commit message s

[edk2] [Patch] * Coding style change in UefiPxeBcDxe.inf

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: jiaxinwu --- NetworkPkg/UefiPxeBcDxe/UefiPxeBcDxe.inf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/NetworkPkg/UefiPxeBcDxe/UefiPxeBcDxe.inf b/NetworkPkg/UefiPxeBcDxe/UefiPxeBcDxe.inf index 6e4c1fc..ea08

Re: [edk2] question about size of OMVF.fd

Thanks, Jordan. I change OvmfPkgX64.dsc file as below: [BuildOptions] # GCC:*_UNIXGCC_*_CC_FLAGS = -DMDEPKG_NDEBUG # GCC:RELEASE_*_*_CC_FLAGS = -DMDEPKG_NDEBUG INTEL:RELEASE_*_*_CC_FLAGS = /D MDEPKG_NDEBUG MSFT:RELEASE_*_*_CC_FLAGS= /D MDEPKG_NDE

[edk2] [Patch 0/2] Update coding style

Update coding style & fix potential NULL memory copy Zhang, Chao B (2): MdePkg: Update coding style MdeModulePkg: Update coding style MdeModulePkg/Universal/EsrtDxe/EsrtDxe.c | 25 +- MdeModulePkg/Universal/EsrtDxe/EsrtDxe.inf | 5 +++-- MdeModulePkg/Un

[edk2] [Patch 1/2] MdePkg: Update coding style

Update to follow Tiano Coding style. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Chao Zhang --- MdePkg/Include/IndustryStandard/WindowsUxCapsule.h | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/MdePkg/Include/IndustryStandard/WindowsUxCapsul

[edk2] [Patch 2/2] MdeModulePkg: Update coding style

Update to follow Tiano Coding style. Fix potential NULL memory copy Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Chao Zhang --- MdeModulePkg/Universal/EsrtDxe/EsrtDxe.c | 25 - MdeModulePkg/Universal/EsrtDxe/EsrtDxe.inf | 5 +++-- MdeModulePkg

[edk2] [PATCH] ArmPkg: Expand AArch64 address width to 48 bits

The VA address space has a maximum address width of 48 bits in AArch64 state; 48 bits address width limit will provide better compatibility than 40 bits for future CPU. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Heyi Guo --- ArmPkg/Include/Chipset/AArch64Mmu.h | 4 ++-

Re: [edk2] Basetools update for CLAN support

Hello, Attached patch implemented BUILDRULEORDER feature. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Yingke Liu Dennis -Original Message- From: Kinney, Michael D [mailto:michael.d.kin...@intel.com] Sent: Wednesday, May 13, 2015 8:48 AM To: edk2-devel@lists.

[edk2] [PATCH] Fix Ebl dumpgcd bug with memory type and IO type

1. Data type for GcdMemoryType and GcdIoType is enumeration type rather than bit field, so we need to use strict equation "==" instead of bit-and "&"; 2. Testing for GcdIoType should use EfiGcdIoType*** constants rather than EfiGcdMemoryType***; 3. As we are going to use strict equation, it is clea

[edk2] [edk] [patch] IntelFspPkg - FspSecCore add AsmGetFspBaseAddressNoStack and AsmGetFspInfoHeaderNoStack

IntelFspPkg - FspSecCore add AsmGetFspBaseAddressNoStack and AsmGetFspInfoHeaderNoStack Fix GCC issue on FspInfoHeaderRelativeOff. Clean up comments for platform ID matching on Microcode and PcdFspBootFirmwareVolumeBase Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: "Yao

Re: [edk2] [Patch 0/2] *** SUBJECT HERE ***

Jordan, Thanks for the details comments on how to submit the patch. I will regenerate this patch and send it out again by your comments. Thanks, Guo -Original Message- From: Justen, Jordan L Sent: Tuesday, May 19, 2015 4:26 AM To: edk2-devel@lists.sourceforge.net; Dong, Guo; Ma, Mauri

Re: [edk2] [Patch 0/2] *** SUBJECT HERE ***

Hi, Jordan, Thank you for these recommendations. Guo, Could you please follow Jordan's instructions to send these patches again? Thanks Maurice -Original Message- From: Justen, Jordan L Sent: Monday, May 18, 2015 1:26 PM To: edk2-devel@lists.sourceforge.net; Dong, Guo; Ma, Maurice Cc: e

Re: [edk2] [Patch 0/2] *** SUBJECT HERE ***

Can you please use git send-email *.patch from the git bash command line, rather than TortoiseGit when sending the email? TortoiseGit does not send the emails in a single email thread. While you are at it, you might as well just use git format-patch to generate the patch files. If you use a cover

Re: [edk2] question about size of OMVF.fd

On 2015-05-18 07:15:02, lidonglin wrote: > Thanks. And I want DEBUG() (which calls DebugPrint function) to work > in debug version, DEBUG() does work in the debug version. It does not work in the release version. > so I chang MdePkg/Include/Library/DebugLib.h : as > below: > Origin: > #if !define

Re: [edk2] [Patch 1/2] The latest coreboot use IMD (In Memory Database) to report Tables. This patch adds IMD support in UEFI payload.

Hi, Guo, Thank you for providing the fixes to support IMD for CorebootModulePkg. Could you please add the function/parameter/return status descriptions for the function FindCbMemTable() inside CbParseLib.c ? Also according to the EKD II Coding Standards spec, "A comparison of any pointer to z

[edk2] [Patch 2/2] Replace tab with space and remove the space at the end of lines.

Signed-off-by: Guo Dong --- CorebootModulePkg/Library/CbParseLib/CbParseLib.c | 498 +++--- 1 file changed, 249 insertions(+), 249 deletions(-) diff --git a/CorebootModulePkg/Library/CbParseLib/CbParseLib.c b/CorebootModulePkg/Library/CbParseLib/CbParseLib.c index 0f82b01..bb182

[edk2] [Patch 1/2] The latest coreboot use IMD (In Memory Database) to report Tables. This patch adds IMD support in UEFI payload.

Signed-off-by: Guo Dong --- CorebootModulePkg/Include/Coreboot.h | 19 CorebootModulePkg/Library/CbParseLib/CbParseLib.c | 38 ++- 2 files changed, 49 insertions(+), 8 deletions(-) diff --git a/CorebootModulePkg/Include/Coreboot.h b/CorebootModulePk

[edk2] [Patch 0/2] *** SUBJECT HERE ***

*** BLURB HERE *** Guo Dong (2): The latest coreboot use IMD (In Memory Database) to report Tables. This patch adds IMD support in UEFI payload. Replace tab with space and remove the space at the end of lines. CorebootModulePkg/Include/Coreboot.h | 19 + CorebootModulePkg/L

Re: [edk2] [PATCH] CorebootPayloadPkg: Replace PciHostBridge driver with PciRootBridgeNoEnumeration

Hi, Ray, First of all, I think the PciBus driver should check the return status of PciIoDevice->PciIo.Pci.Read () regardsless. It is to ensure CapabilityEntry is valid before we consume it later on. Regarding to the reason why it fails with Pci.Read(), it is not caused by the actual hardwa

Re: [edk2] question about size of OMVF.fd

Thanks. And I want DEBUG() (which calls DebugPrint function) to work in debug version, so I chang MdePkg/Include/Library/DebugLib.h : as below: Origin: #if !defined(MDEPKG_NDEBUG) #define DEBUG(Expression)\ do { \ if (DebugPrintEnabled ()) { \

Re: [edk2] [PATCH 1/2] MdeModulePkg Variable: Prevent BS variable update in legacy OS runtime.

Reviewed-by: Liming Gao -Original Message- From: Zeng, Star Sent: Monday, May 18, 2015 2:48 PM To: edk2-devel@lists.sourceforge.net Cc: Yao, Jiewen; Gao, Liming Subject: [PATCH 1/2] MdeModulePkg Variable: Prevent BS variable update in legacy OS runtime. Cc: Jiewen Yao Cc: Liming Gao

Re: [edk2] question about size of OMVF.fd

On 05/18/15 08:50, lidonglin wrote: > First thanks. And I ask another question. Which function can I call to > print information to serial port or IO port(default 0x402) when I build > RELEASE OVMF ? - The only function that currently enables someone to print to ioport 0x402 (PcdDebugIoPort), and

Re: [edk2] [PATCH 2/2] SecurityPkg Variable: Prevent BS variable update in legacy OS runtime.

Looks good. Thanks! -Original Message- From: Zeng, Star Sent: Monday, May 18, 2015 2:48 PM To: edk2-devel@lists.sourceforge.net Cc: Yao, Jiewen; Gao, Liming Subject: [PATCH 2/2] SecurityPkg Variable: Prevent BS variable update in legacy OS runtime. Cc: Jiewen Yao Cc: Liming Gao Contri