[edk2] MemoryError exceptions when trying to build OVMF on Windows

2015-07-10 Thread Bruce Cran
I'm having some problems building OVMF (latest trunk code) on Windows: the build system keeps throwing MemoryError exceptions. The machine has 16GB RAM and is running Windows Server 2012 R2. I'm running the following (I've also seen the error with VS2010x86 and VS2012x86 toolsets): build -a X64

Re: [edk2] [PATCH] Avoid "variable set but not used" warning from GCC.

2015-07-10 Thread Scott Duplichan
Bill Paul [mailto:wp...@windriver.com] wrote: ]Sent: Friday, July 10, 2015 05:55 PM ]To: Jordan Justen ]Cc: edk2-devel@lists.sourceforge.net ]Subject: Re: [edk2] [PATCH] Avoid "variable set but not used" warning from GCC. ] ]Of all the gin joints in all the towns in all the world, Jordan Justen ha

Re: [edk2] [PATCH] Avoid "variable set but not used" warning from GCC.

2015-07-10 Thread Bill Paul
Of all the gin joints in all the towns in all the world, Jordan Justen had to walk into mine at 11:40:01 on Friday 10 July 2015 and say: > > Be aware too that not every project uses the exact same rules for patch > > submissions, so don't be surprised if new (or infrequent) contributors > > can't

Re: [edk2] [PATCH] Avoid "variable set but not used" warning from GCC.

2015-07-10 Thread Jordan Justen
On 2015-07-10 10:46:19, Bill Paul wrote: > Of all the gin joints in all the towns in all the world, Jordan Justen had to > walk into mine at 00:53:23 on Friday 10 July 2015 and say: > > > On 2015-07-10 00:18:15, Laszlo Ersek wrote: > > > Ooops :) > > > > > > Apparently I was too quick to commit

Re: [edk2] [PATCH] Avoid "variable set but not used" warning from GCC.

2015-07-10 Thread Bill Paul
Of all the gin joints in all the towns in all the world, Jordan Justen had to walk into mine at 00:53:23 on Friday 10 July 2015 and say: > On 2015-07-10 00:18:15, Laszlo Ersek wrote: > > Ooops :) > > > > Apparently I was too quick to commit this, without waiting for your > > review. Anyway, some

Re: [edk2] [PATCH v3 3/7] EmulatorPkg: Remove Ip4ConfigDxe module from EmulatorPkg

2015-07-10 Thread Laszlo Ersek
On 07/10/15 18:36, Jordan Justen wrote: > On 2015-07-10 04:29:11, Laszlo Ersek wrote: >> On 07/10/15 10:40, Wu, Jiaxin wrote: >>> Yes, edk2-devel will strip it. You can check version2 for those >>> series patches, I had added someone with cc tag to the commit >>> message, but it haven't actually cc

Re: [edk2] [PATCH v3 3/7] EmulatorPkg: Remove Ip4ConfigDxe module from EmulatorPkg

2015-07-10 Thread Laszlo Ersek
On 07/10/15 17:56, Wu, Jiaxin wrote: > Hi Laszlo, > Thank you for your wonderful explanation. > > You explained before you *did* get a personal copy of the v2. I > *thought* you got a personal v2 copy *maybe* by setting the specific > mail filtering rule. > > Also as you said it's a "terrible pra

Re: [edk2] [PATCH v3 3/7] EmulatorPkg: Remove Ip4ConfigDxe module from EmulatorPkg

2015-07-10 Thread Jordan Justen
On 2015-07-10 04:29:11, Laszlo Ersek wrote: > On 07/10/15 10:40, Wu, Jiaxin wrote: > > Yes, edk2-devel will strip it. You can check version2 for those > > series patches, I had added someone with cc tag to the commit > > message, but it haven't actually cc to those people. > > (3) Laszlo will get

Re: [edk2] [PATCH] BaseTools/GenFw: Added AArch64 page-relative relocations

2015-07-10 Thread Ard Biesheuvel
On 10 July 2015 at 18:13, Olivier Martin wrote: > > >> -Original Message- >> From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] >> Sent: 08 July 2015 18:50 >> To: Olivier Martin >> Cc: Leif Lindholm; edk2-devel@lists.sourceforge.net; Harry Liebel >> Subject: Re: [PATCH] BaseTools/GenF

Re: [edk2] [PATCH] BaseTools/GenFw: Added AArch64 page-relative relocations

2015-07-10 Thread Olivier Martin
> -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: 08 July 2015 18:50 > To: Olivier Martin > Cc: Leif Lindholm; edk2-devel@lists.sourceforge.net; Harry Liebel > Subject: Re: [PATCH] BaseTools/GenFw: Added AArch64 page-relative > relocations > > On 8 Jul

Re: [edk2] How can I get an efi version of acpidump ?

2015-07-10 Thread Shubha Ramani
Hi, I'm circling back.lv.zh...@intel.com got it done. Here is information. Anyone wish to port an EDK2 version ? Hi, Currently acpidump EFI version can be compiled using the following command:# make OS=efiIt is currently based on GNU EFI, for different distributions, the GNU EFI related CFLAGS/L

Re: [edk2] [Patch 1/2] NetworkPkg: Code logic optimization for DnsDxe and HttpDxe driver

2015-07-10 Thread Leif Lindholm
On Fri, Jul 10, 2015 at 04:19:08PM +0800, Wang Fan wrote: > Revise some errors which may lead NULL pointer be dereferenced: > * DnsDhcp.c: Paralist may be used without any initialized > * DnsHeader and RcvString may be null but be dereferenced > * HttpDriver.c: revise an if judgment > * HttpImpl.c:

Re: [edk2] [PATCH] OvmfPkg/VirtioLib: Ensure VirtioFlush() is not blocked

2015-07-10 Thread Laszlo Ersek
On 07/10/15 17:22, Olivier Martin wrote: > Thanks Lazlo, I had this issue with the ARM FVP Models and its Virtio > support (see: > http://infocenter.arm.com/help/topic/com.arm.doc.dui0834a/Chunk446462681.html). > I do not remember which model version. I am happy to abandon this > patch until I trac

Re: [edk2] [PATCH v3 3/7] EmulatorPkg: Remove Ip4ConfigDxe module from EmulatorPkg

2015-07-10 Thread Wu, Jiaxin
Hi Laszlo, Thank you for your wonderful explanation. You explained before you *did* get a personal copy of the v2. I *thought* you got a personal v2 copy *maybe* by setting the specific mail filtering rule. Also as you said it's a "terrible practice" for edk2-mailing list's "crazy setting", "be

Re: [edk2] [PATCH] OvmfPkg/VirtioLib: Ensure VirtioFlush() is not blocked

2015-07-10 Thread Olivier Martin
Thanks Lazlo, I had this issue with the ARM FVP Models and its Virtio support (see: http://infocenter.arm.com/help/topic/com.arm.doc.dui0834a/Chunk446462681.html). I do not remember which model version. I am happy to abandon this patch until I track down the model version and an action is taken

Re: [edk2] [PATCH 1/3] ArmPlatformPkg/ArmVExpressPkg: add ArmPlatformSysConfigLib for runtime

2015-07-10 Thread Ard Biesheuvel
On 10 July 2015 at 17:13, Olivier Martin wrote: > Thanks for confirming the explanation. > > I was initially thinking to ask you for a new patchset to fix the coding > style. But the original version (ie: > ArmPlatformPkg/ArmVExpressPkg/Library/ArmVExpressSysConfigLib) has the same > coding sty

Re: [edk2] [PATCH 1/3] ArmPlatformPkg/ArmVExpressPkg: add ArmPlatformSysConfigLib for runtime

2015-07-10 Thread Olivier Martin
Thanks for confirming the explanation. I was initially thinking to ask you for a new patchset to fix the coding style. But the original version (ie: ArmPlatformPkg/ArmVExpressPkg/Library/ArmVExpressSysConfigLib) has the same coding style issue. Reviewed-By: Olivier Martin I pushed the patchs

Re: [edk2] [RFC PATCH] MdeModulePkg: account for disjoint code and data regions in runtime relocations

2015-07-10 Thread Ard Biesheuvel
On 10 July 2015 at 16:14, Matt Fleming wrote: > On Fri, 10 Jul, at 03:57:52PM, Ard Biesheuvel wrote: >> >> Are you sure it is the .reloc section itself? It could well be the >> target of a relocation fixup that is inside a code region, which >> cannot be applied due to the page permissions. > > Oh

Re: [edk2] [RFC PATCH] MdeModulePkg: account for disjoint code and data regions in runtime relocations

2015-07-10 Thread Matt Fleming
On Fri, 10 Jul, at 03:57:52PM, Ard Biesheuvel wrote: > > Are you sure it is the .reloc section itself? It could well be the > target of a relocation fixup that is inside a code region, which > cannot be applied due to the page permissions. Oh yes, that would make more sense. I was under the impre

Re: [edk2] [RFC PATCH] MdeModulePkg: account for disjoint code and data regions in runtime relocations

2015-07-10 Thread Ard Biesheuvel
On 10 July 2015 at 15:53, Matt Fleming wrote: > On Thu, 09 Jul, at 05:58:36PM, Ard Biesheuvel wrote: >> >> Sure. In the meantime, I have cooked up a slightly more elaborate >> series that also fixes the >> EFI_IMAGE_REL_BASED_LOW/EFI_IMAGE_REL_BASED_HIGH issues (even though >> they don't seem to b

Re: [edk2] [RFC PATCH] MdeModulePkg: account for disjoint code and data regions in runtime relocations

2015-07-10 Thread Matt Fleming
On Thu, 09 Jul, at 05:58:36PM, Ard Biesheuvel wrote: > > Sure. In the meantime, I have cooked up a slightly more elaborate > series that also fixes the > EFI_IMAGE_REL_BASED_LOW/EFI_IMAGE_REL_BASED_HIGH issues (even though > they don't seem to be used widely) and does some cleanups. This is > unli

[edk2] [PATCH] MdePkg: ensure SafeString length functions don't access beyond MaxSize

2015-07-10 Thread Leif Lindholm
The StrnLenS and AsciiStrnLenS functions, when presented with a string with no terminating NULL in the first MaxSize characters will check the character at String[MaxSize] before checking if Length < MaxSize. (They return the correct value, but have accessed beyond the stated limit in the process.)

Re: [edk2] [PATCH v3 3/7] EmulatorPkg: Remove Ip4ConfigDxe module from EmulatorPkg

2015-07-10 Thread Bruce Cran
On Fri, Jul 10, 2015 at 01:29:11PM +0200, Laszlo Ersek wrote: > > - Then you format the patch with "git format-patch", and send it with > "git send-email" to "edk2-devel" (To:). You can also skip the format-patch step and pass a revset spec directly to send-email - e.g. "git send-email -1". --

[edk2] [PATCH 0/2] Reduce reserved memory consumption by page table buffer for S3

2015-07-10 Thread Star Zeng
Going to reduce reserved memory consumption by page table buffer, then OS can have more available memory to use. Take PhysicalAddressBits = 48 and 2MB page granularity as example, 1:1 Virtual to Physical identity mapping page table buffer needs to be ((512 + 1) * 512 + 1) * 4096 = 1075843072 bytes

Re: [edk2] [PATCH] Fix some type errors in Vlv2TbltDevicePkg

2015-07-10 Thread Bruce Cran
On Tue, Jul 07, 2015 at 03:44:06AM -0600, Bruce Cran wrote: > On Tue, Jul 07, 2015 at 08:13:30AM +, He, Tim wrote: > > Bruce, the patch is also failed to apply, it shows " Patch format detection > > failed.", could you please re-send the patch for review? thanks.. > > Hmm, not sure what went

[edk2] [PATCH 1/2] MdeModulePkg BootScriptExecutorDxe: Reduce reserved memory consumption.

2015-07-10 Thread Star Zeng
We are going to reduce reserved memory consumption by page table buffer, then OS can have more available memory to use. Take PhysicalAddressBits = 48 and 2MB page granularity as example, 1:1 Virtual to Physical identity mapping page table buffer needs to be ((512 + 1) * 512 + 1) * 4096 = 1075843072

[edk2] [PATCH 2/2] IntelFrameworkModulePkg AcpiS3SaveDxe: Reduce reserved memory consumption.

2015-07-10 Thread Star Zeng
Reduce reserved memory consumption by page table buffer, then OS can have more available memory to use. Take PhysicalAddressBits = 48 and 2MB page granularity as example, 1:1 Virtual to Physical identity mapping page table buffer needs to be ((512 + 1) * 512 + 1) * 4096 = 1075843072 bytes = 0x40201

Re: [edk2] [PATCH v3 3/7] EmulatorPkg: Remove Ip4ConfigDxe module from EmulatorPkg

2015-07-10 Thread Laszlo Ersek
On 07/10/15 10:40, Wu, Jiaxin wrote: > Yes, edk2-devel will strip it. You can check version2 for those > series patches, I had added someone with cc tag to the commit > message, but it haven't actually cc to those people. Yes, you did! I *did* get a personal copy of the v2 patches from you! (And

Re: [edk2] [Patch 2/2] MdeModulePkg: Code logic optimization for Ip4Dxe driver

2015-07-10 Thread Ard Biesheuvel
On 10 July 2015 at 10:19, Wang Fan wrote: > Move null check before set value to address to avoid null address > dereferenced. > Preventing a NULL pointer from being dereferenced is hardly an optimization, so perhaps you should change the patch description? > Contributed-under: TianoCore Contrib

Re: [edk2] [Patch 1/2] NetworkPkg: Code logic optimization for DnsDxe and HttpDxe driver

2015-07-10 Thread Ard Biesheuvel
On 10 July 2015 at 10:19, Wang Fan wrote: > Revise some errors which may lead NULL pointer be dereferenced: > * DnsDhcp.c: Paralist may be used without any initialized > * DnsHeader and RcvString may be null but be dereferenced > * HttpDriver.c: revise an if judgment > * HttpImpl.c: add a judgment

Re: [edk2] [PATCH] CryptoPkg: update OpenSSL dependency to version 1.0.2d

2015-07-10 Thread Ard Biesheuvel
On 10 July 2015 at 09:53, Ye, Ting wrote: > Looks good to me. > Reviewed-by: Ye Ting > @Qin: are you ok with this patch? I would like to get it submitted asap to fix our automated build (it is broken because 1.0.2c is no longer available for download) Thanks, Ard. > -Original Message-

Re: [edk2] [Patch 1/2] NetworkPkg: Code logic optimization for DnsDxe and HttpDxe driver

2015-07-10 Thread Wu, Jiaxin
Reviewed-by: Jiaxin Wu -Original Message- From: Wang, Fan Sent: Friday, July 10, 2015 4:19 PM To: Wu, Jiaxin; Fu, Siyuan; edk2-devel@lists.sourceforge.net Cc: Wang, Fan Subject: [Patch 1/2] NetworkPkg: Code logic optimization for DnsDxe and HttpDxe driver Revise some errors which may l

Re: [edk2] [Patch 2/2] MdeModulePkg: Code logic optimization for Ip4Dxe driver

2015-07-10 Thread Wu, Jiaxin
Reviewed-by: Jiaxin Wu -Original Message- From: Wang, Fan Sent: Friday, July 10, 2015 4:19 PM To: Wu, Jiaxin; Fu, Siyuan; edk2-devel@lists.sourceforge.net Cc: Wang, Fan Subject: [Patch 2/2] MdeModulePkg: Code logic optimization for Ip4Dxe driver Move null check before set value to addre

Re: [edk2] [PATCH v3 3/7] EmulatorPkg: Remove Ip4ConfigDxe module from EmulatorPkg

2015-07-10 Thread Wu, Jiaxin
Yes, edk2-devel will strip it. You can check version2 for those series patches, I had added someone with cc tag to the commit message, but it haven't actually cc to those people. For the git script format, I know it support both linux shell and windows CMD(CMD is my choice). *Firstly, we must a

Re: [edk2] [Patch 2/2] MdeModulePkg: Code logic optimization for Ip4Dxe driver

2015-07-10 Thread Ye, Ting
Looks good. Reviewed-by: Ye Ting -Original Message- From: Wang Fan [mailto:fan.w...@intel.com] Sent: Friday, July 10, 2015 4:19 PM To: Wu, Jiaxin; Fu, Siyuan; edk2-devel@lists.sourceforge.net Subject: [edk2] [Patch 2/2] MdeModulePkg: Code logic optimization for Ip4Dxe driver Move null

Re: [edk2] [Patch 1/2] NetworkPkg: Code logic optimization for DnsDxe and HttpDxe driver

2015-07-10 Thread Ye, Ting
Looks good. Reviewed-by: Ye Ting -Original Message- From: Wang Fan [mailto:fan.w...@intel.com] Sent: Friday, July 10, 2015 4:19 PM To: Wu, Jiaxin; Fu, Siyuan; edk2-devel@lists.sourceforge.net Subject: [edk2] [Patch 1/2] NetworkPkg: Code logic optimization for DnsDxe and HttpDxe driver

[edk2] [Patch 1/2] NetworkPkg: Code logic optimization for DnsDxe and HttpDxe driver

2015-07-10 Thread Wang Fan
Revise some errors which may lead NULL pointer be dereferenced: * DnsDhcp.c: Paralist may be used without any initialized * DnsHeader and RcvString may be null but be dereferenced * HttpDriver.c: revise an if judgment * HttpImpl.c: add a judgment to avoid null dereferenced Contributed-under: Tiano

[edk2] [Patch 2/2] MdeModulePkg: Code logic optimization for Ip4Dxe driver

2015-07-10 Thread Wang Fan
Move null check before set value to address to avoid null address dereferenced. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: fanwang2 --- MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Config2Nv.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Mde

[edk2] [Patch 0/2] Code logic optimization for some drivers

2015-07-10 Thread Wang Fan
This patch is used to do some code logic optimizations. fanwang2 (2): NetworkPkg: Code logic optimization for DnsDxe and HttpDxe driver MdeModulePkg: Code logic optimization for Ip4Dxe driver MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Config2Nv.c | 8 NetworkPkg/DnsDxe/DnsDhcp.c

Re: [edk2] [PATCH v3 3/7] EmulatorPkg: Remove Ip4ConfigDxe module from EmulatorPkg

2015-07-10 Thread Jordan Justen
On 2015-07-10 00:29:18, Wu, Jiaxin wrote: > I agree your suggested format absolutely. Sorry for my missing any attention. > > I'm not "Cc" any maintainer manually. We should know that the Cc > part maintainers in commit message will be ignored by edk2-devel if > the maintainers already in edk2-dev

Re: [edk2] [PATCH] Avoid "variable set but not used" warning from GCC.

2015-07-10 Thread Jordan Justen
On 2015-07-10 00:18:15, Laszlo Ersek wrote: > Ooops :) > > Apparently I was too quick to commit this, without waiting for your > review. Anyway, some comments: > > On 07/10/15 09:05, Jordan Justen wrote: > > Patch subject doesn't contain a package/module prefix. I suggest: > > > > OvmfPkg/QemuFw

Re: [edk2] [PATCH] CryptoPkg: update OpenSSL dependency to version 1.0.2d

2015-07-10 Thread Ye, Ting
Looks good to me. Reviewed-by: Ye Ting -Original Message- From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] Sent: Friday, July 10, 2015 2:54 PM To: edk2-devel@lists.sourceforge.net; Long, Qin; Dong, Guo; Ye, Ting Cc: Justen, Jordan L; Gao, Liming; Ard Biesheuvel Subject: [PATCH] C

Re: [edk2] [PATCH v2] NetworkPkg: Fix a bug that return type differs from the left one when assigned

2015-07-10 Thread Wu, Jiaxin
Reviewed-by: Jiaxin Wu -Original Message- From: Zhang, Lubo Sent: Friday, July 10, 2015 2:11 PM To: edk2-devel@lists.sourceforge.net; Fu, Siyuan; Qiu, Shumin; Wu, Jiaxin Subject: [PATCH v2] NetworkPkg: Fix a bug that return type differs from the left one when assigned Version v2 incl

Re: [edk2] [PATCH v2] MdeModulePkg: Fix a error that return type differs from the left one when assigned

2015-07-10 Thread Wu, Jiaxin
Reviewed-by: Jiaxin Wu -Original Message- From: Zhang, Lubo Sent: Friday, July 10, 2015 2:11 PM To: edk2-devel@lists.sourceforge.net; Fu, Siyuan; Qiu, Shumin; Wu, Jiaxin Subject: [PATCH v2] MdeModulePkg: Fix a error that return type differs from the left one when assigned Message-ID:

Re: [edk2] [PATCH v3 3/7] EmulatorPkg: Remove Ip4ConfigDxe module from EmulatorPkg

2015-07-10 Thread Wu, Jiaxin
I agree your suggested format absolutely. Sorry for my missing any attention. I'm not "Cc" any maintainer manually. We should know that the Cc part maintainers in commit message will be ignored by edk2-devel if the maintainers already in edk2-devel mailing list. So, if we want to send out the p

Re: [edk2] [PATCH] CryptoPkg: update OpenSSL dependency to version 1.0.2d

2015-07-10 Thread Laszlo Ersek
On 07/10/15 08:54, Ard Biesheuvel wrote: > Upstream OpenSSL version 1.0.2c contained a fatal flaw > [CVE-2015-1793] and is no longer available from the openssl.org > download servers. So upgrade to its replacement, version 1.0.2d. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signe

Re: [edk2] [PATCH] BaseTools/GCC: allow unused but set variables

2015-07-10 Thread Jordan Justen
On 2015-07-08 19:31:09, Scott Duplichan wrote: > Bruce Cran [mailto:br...@cran.org.uk] wrote: > > ]Sent: Wednesday, July 08, 2015 05:12 PM > ]To: edk2-devel@lists.sourceforge.net > ]Subject: Re: [edk2] [PATCH] BaseTools/GCC: allow unused but set variables > ] > ]On Wed, Jul 08, 2015 at 10:43:38PM

Re: [edk2] [PATCH] Avoid "variable set but not used" warning from GCC.

2015-07-10 Thread Laszlo Ersek
Ooops :) Apparently I was too quick to commit this, without waiting for your review. Anyway, some comments: On 07/10/15 09:05, Jordan Justen wrote: > Patch subject doesn't contain a package/module prefix. I suggest: > > OvmfPkg/QemuFwCfgLib: Avoid "variable set but not used" warning from GCC I

Re: [edk2] [PATCH] Avoid "variable set but not used" warning from GCC.

2015-07-10 Thread Jordan Justen
Patch subject doesn't contain a package/module prefix. I suggest: OvmfPkg/QemuFwCfgLib: Avoid "variable set but not used" warning from GCC https://github.com/tianocore/tianocore.github.io/wiki/Commit-Message-Format On 2015-07-09 17:09:20, Bill Paul wrote: > The FileReserved variable in QemuFwCfg