[edk2] Bug in EFI_ACPI_5_1_GTDT_SBSA_GENERIC_WATCHDOG_STRUCTURE

EFI_ACPI_5_1_GTDT_SBSA_GENERIC_WATCHDOG_STRUCTURE declaration in \edk2\MdePkg\Include\IndustryStandard\Acpi51.h has wrong field lengths: /// /// SBSA Generic Watchdog Structure /// typedef struct { UINT8 Type; UINT8 Length; UINT16 Reserved; ... This should be typedef str

[edk2] Removal of DEBUG_CODE in RELEASE Builds

Hi All, The description of DEBUG_CODE_BEGIN() and DEBUG_CODE_END() macros in edk2\MdePkg\Include\Library\DebugLib.h reads: /** Macro that marks the beginning of debug source code. If the DEBUG_PROPERTY_DEBUG_CODE_ENABLED bit of PcdDebugProperyMask is set, then this macro marks the beginnin

Re: [edk2] Bug in TerminalDxe UnicodeFiFoRemoveOneKey()

Hi Elvin, I've checked Terminal.h, TerminalConIn.c files & they both still contain "@retval FLASE" typos. Alexei. >Date: Tue, 11 Feb 2014 00:17:11 + >From: "Li, Elvin" mailto:elvin...@intel.com>> >Subject: Re: [edk2] Bug in TerminalDxe UnicodeFiFoRemoveOneKey() function >To: "edk2-deve

[edk2] InitializeDebugPortDriver() & DebugPortSupported() always return EFI_SUCCESS

Hi, Please look @the issues below: \edk2\MdeModulePkg\Universal\DebugPortDxe\DebugPort.c, 1) InitializeDebugPortDriver() line #143: ASSERT_EFI_ERROR (Status); return EFI_SUCCESS; This should be ASSERT_EFI_ERROR (Status); return Status; 2) DebugPortSupported() line #244

Re: [edk2] Bug in TerminalDxe UnicodeFiFoRemoveOneKey() function

Liming, I didn't hit any issue with that code, but have been trying to work out the reason of the compilation error. As UnicodeFiFoRemoveOneKey() is called only when FIFO buffer is not empty, should the obsolete code be removed & the function's return type changed to VOID? Do you plan to impleme

[edk2] Bug in TerminalDxe UnicodeFiFoRemoveOneKey() function

I'm getting the following error for TerminalDxe when compiling with -O3 option: q:\edk2\MdeModulePkg\Universal\Console\TerminalDxe\TerminalConIn.c: In function 'UnicodeToEfiKey': q:\edk2\MdeModulePkg\Universal\Console\TerminalDxe\TerminalConIn.c:1571:8: error: 'UnicodeChar' may be used uninitial

Re: [edk2] Printing UINTN numbers in X64 (David F.)

dows-1252" >> DEBUG ((EFI_D_INFO, "BlockIo (MMIO) ReadBlocks: lba=0x%lx, size=0x%x\n", Lba, BufferSize)); Shouldn't that be %llx and not %lx On Fri, Sep 6, 2013 at 3:45 AM, Alexei Fedorov wrote: > According to \edk2\MdePkg\Include\X64\ProcessorBind.h > >

[edk2] Printing UINTN numbers in X64

According to \edk2\MdePkg\Include\X64\ProcessorBind.h for X64 'UINTN' type has a length of 8 bytes: typedef UINT64 UINTN; and 'int' is 32-bit value: typedef unsigned intUINT32; , so debug macros like in CpuConvertPagesToUncachedVirtualAddress() function (\edk2\OvmfPkg\BlockMmioToBloc

[edk2] InternalShellProtocolDebugPrintMessage() returns un-initialised Status

1. InternalShellProtocolDebugPrintMessage() function in \edk2\ShellPkg\Application\Shell\ShellProtocol.c returns un-initialised Status variable: EFI_STATUS EFIAPI InternalShellProtocolDebugPrintMessage ( IN CONST CHAR16 *Mapping, IN CONST EFI_DEVICE_PATH_PROTOCOL *DevicePath

Re: [edk2] [PATCH] ShellPkg: Fixed build with ARM toolchain (Olivier Martin) (edk2-devel Digest, Vol 42, Issue 13)

Still to resolve following RELEASE build warnings: \edk2\ShellPkg\Library\UefiSortLib\UefiSortLib.c(209,29) : warning #550-D: variable "Status" was set but never used \edk2\ShellPkg\Library\UefiSortLib\UefiSortLib.c(289,29) : warning #550-D: variable "Status" was set but never used \edk2\S

[edk2] Issues with BaseSerialPortLibNull: reply to Andrew Fish

Andrew thanks for your explanation. What's about the 2nd item? 2. SerialPortWrite() function returns 0, which makes SerialWrite() finction in SerialIo.c return EFI_TIMEOUT error causing UEFI image to hang. This might be fixed by changing return value to NumberOfBytes. Alexei. -- IMPORTANT NOTICE

[edk2] Issues with BaseSerialPortLibNull

1. \MdePkg\Library\BaseSerialPortLibNull\ BaseSerialPortLibNull.c is missing the following functions: - SerialPortGetControl() - SerialPortSetControl() - SerialPortSetAttributes() Which leads to compilation errors for \EmbeddedPkg\SerialDxe\SerialIo.c. 2. SerialPortWrite() function returns 0, w

[edk2] Replay to message #5 of edk2-devel Digest, Vol 36, Issue 22

Hi Elvin, It happens in both variants with Consplitter included & not. Regards. Alexei. >Message: 5 >Date: Thu, 13 Dec 2012 00:53:26 + >From: "Li, Elvin" >Subject: Re: [edk2] Graphics Console produces no output in RELEASE > build >To: "edk2-devel@lists.sourceforge.net" >

[edk2] BdsEntry() does not set CRC32 to 0 before CalculateCrc32() call

\edk2\IntelFrameworkModulePkg\Universal\BdsDxe\BdsEntry.c @line #489 is missing gST->Hdr.CRC32 = 0; before call to // // Fixup Tasble CRC after we updated Firmware Vendor and Revision // gBS->CalculateCrc32 ((VOID *)gST, sizeof(EFI_SYSTEM_TABLE), &gST->Hdr.CRC32); -- IMPORTANT

[edk2] Graphics Console produces no output in RELEASE build

Hi, I found an issue with graphics console code in GraphicsConsoleControllerDriverStart() in \edk2\MdeModulePkg\Universal\Console\GraphicsConsoleDxe\GraphicsConsole.c DEBUG_CODE_BEGIN (); Status = GraphicsConsoleConOutSetMode (&Private->SimpleTextOutput, 0); if (EFI_ERROR (Status)) {