Re: [edk2] [Patch] MdePkg: Add EFI_LOAD_OPTION definition.

2015-05-08 Thread Felix Poludov
Sent: Friday, May 08, 2015 2:58 AM To: Kinney, Michael D; Felix Poludov; edk2-devel@lists.sourceforge.net; Andrew Fish Subject: RE: [edk2] [Patch] MdePkg: Add EFI_LOAD_OPTION definition. Mike, How about the below comments? +// +// EFI Load Option +// NOTE: Some of the variable length structure f

Re: [edk2] [Patch] MdePkg: Add EFI_LOAD_OPTION definition.

2015-05-07 Thread Felix Poludov
The EFI_LOAD_OPTION was not defined in the UEFI specification, but it is now (starting from UEFI 2.5). The situation with EFI_LOAD_OPTION was somewhat confusing. The type was mentioned in the specification, but was not explicitly defined. I think having the type explicitly defined has some value.

[edk2] [PATCH] [MdePkg ] NvmExpressPassThru and SmartCardReader protocol headers

2015-04-23 Thread Felix Poludov
Dear MdePkg maintainer, The attached patch contains definitions for two new protocols introduced in UEFI 2.5: NvmExpressPassThru.h - NVM Express Pass Through Protocol defined in section 12.14. SmartCardReader.h - Smart Card Reader Protocol defined in section 35.7.1. The patch also modifies MdePk

[edk2] [PATCH] [MdePkg ] Missing GUID variable in DiskInfo.h

2015-03-30 Thread Felix Poludov
Dear MdePkg maintainer, The DiskInfo.h defines EFI_DISK_INFO_NVME_INTERFACE_GUID, but does not declare a corresponding EFI_GUID variable. The attached patch adds "extern" statement for the variable in DiskInfo.h. It also adds variable definition to MdePkg.dec. Contributed-under: TianoCore Contr

[edk2] DXE Services: SetMemorySpaceCapabilities is missing

2014-10-30 Thread Felix Poludov
SetMemorySpaceCapabilities is a GCD extension introduced in PI 1.3. It is not in the code base even though PiDxeCis.h states PI 1.3 compliancy. The information contained in this message may be confidential and proprietary to American Megatrends, Inc. This communication is intended to be read on

Re: [edk2] INF/DEC file updates to EDK II packages

2014-08-07 Thread Felix Poludov
Mike, Why localized module name and localized module abstract/description are in two separate UNI files? Thanks Felix From: Kinney, Michael D [mailto:michael.d.kin...@intel.com] Sent: Wednesday, August 06, 2014 9:22 PM To: edk2-devel@lists.sourceforge.net Subject: Re: [edk2] INF/DEC file updat

[edk2] ShellPkg bug: wrong system table field is used to locate simple text pointer interface

2014-06-09 Thread Felix Poludov
There is a code in Edit and HexEdit that tries to locate simple text pointer splitter using the following call: Status = gBS->HandleProtocol ( gST->ConIn, &gEfiSimplePointerProtocolGuid, (VOID**)&MainEditor.MouseInterface ); The fir

[edk2] CoreExitBootServices implementation

2013-12-16 Thread Felix Poludov
I think there is a couple of issues with the current implementation of CoreExitBootServices: 1 . According to ExitBootServices() description, events of type EVT_SIGNAL_EXIT_BOOT_SERVICES, must be signaled once even if ExitBootServices() is called multiple times. Current implementation signals e

Re: [edk2] How to align auto variables?

2013-02-19 Thread Felix Poludov
you do not think there are alignment requirements for HiiString->SetString(). Maybe I am missing an exception statement in the UEFI Specification? Thanks, Mike -Original Message- From: Felix Poludov [mailto:fel...@ami.com] Sent: Thursday, February 14, 2013 3:38 PM T

Re: [edk2] How to align auto variables?

2013-02-14 Thread Felix Poludov
That's not necessarily, the end of the story. There is a change that sooner or later that string will get passed to one of the HII functions such as HiiString->SetString. This will cause an ASSERT in the platform firmware, because guess which function the HII driver is using to get the string len