Signed-off-by: Heyi Guo heyi@linaro.org
In the commit message, you can Cc Andrew and I in the EmulatorPkg
patch here, and git send-email will automatically add the Cc when
sending the email.
You can add Reviewed-by: Jordan Justen jordan.l.jus...@intel.com to
the separate EmulatorPkg patch
://support.office.com/en-za/article/Change-the-message-format-to-HTML-Rich-Text-or-plain-text-d92bba10-7ed4-4413-a031-7a1559112d90#__toc269980630
To sign up for the new list, visit:
https://lists.01.org/mailman/listinfo/edk2-devel
-Jordan
On 2015-07-14 15:25:01, Jordan Justen wrote:
Just to pick
: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
Jordan Justen
Sent: Wednesday, July 15, 2015 4:21 PM
To: edk2-devel; edk2-de...@lists.01.org
Subject: [edk2-devel] 1 day until new edk2-devel email list transition
There is about 1 day until the transition to the new
On 2015-07-14 14:29:11, Laszlo Ersek wrote:
On 07/14/15 23:15, Paolo Bonzini wrote:
The long delay that Alex reported (for the case when all guest memory
was set to UC up-front) is due to the fact that the SEC phase of OVMF
decompresses an approximately 1712 KB sized, LZMA-compressed blob,
.
-Jordan
Forwarded message from Jordan Justen (2015-07-06 11:48:48):
On 2015-07-04 15:56:05, B Cran wrote:
On May 4, 2015, at 2:21 PM, Peterson, Joe joe.peter...@intel.com
wrote:
Due to community feedback, a new mailing list is being set up to replace
this one. The new list will be hosted
@@ InitializePciHostBridge (
// alive.
//
for (RootBridgeNumber = 1;
- RootBridgeNumber 256;
+ RootBridgeNumber 256 ExtraRootBridgesLeft 0;
this condition here will prevent the loop body from executing even once.
Ok. Yeah, that looks good.
20-21 Reviewed-by: Jordan
Reviewed-by: Jordan Justen jordan.l.jus...@intel.com
On 2015-07-07 08:09:25, Laszlo Ersek wrote:
The OFW device path that QEMU exports in the bootorder fw_cfg file, for
a device that is plugged into the main PCI root bus, is:
/pci@i0cf8/...
Whereas the same device plugged into the N'th
Reviewed-by: Jordan Justen jordan.l.jus...@intel.com
On 2015-07-07 08:09:24, Laszlo Ersek wrote:
SeaBIOS requires the OpenFirmware device paths exported in the bootorder
fw-cfg file to refer to extra (PXB) root buses by their relative positions
(in increasing bus number order) rather than
Your subject line is too long. (86 characters)
NetworkPkg/Contributions.txt
https://github.com/tianocore/tianocore.github.io/wiki/Commit-Message-Format
On 2015-07-11 07:51:24, Samer El-Haj-Mahmoud wrote:
From: Sriram Subramanian srira...@hp.com
Modified the logic in Ip4Dxe and Ip6Dxe to not
Your subject line is too long. (151 characters)
BaseTools/Contributions.txt
https://github.com/tianocore/tianocore.github.io/wiki/Commit-Message-Format
Should this be 2 patches? ('Also added...')
On 2015-07-11 07:00:48, Samer El-Haj-Mahmoud wrote:
From: Cecil Sheng cecil.sh...@hp.com
On 2015-07-08 12:02:10, Laszlo Ersek wrote:
It seems to follow that Intel should operate such a build
farm. Based on how long we've been whining about this, I don't think
it's going to happen any time soon.
Intel has had such a build farm for years. It does usually catch these
issues... after
...@intel.com
I guess you Cc'd Andrew and I manually?
If you add Cc: Jordan Justen jordan.l.jus...@intel.com to the
commit message, then git send-email will automatically add the Cc's
when sending the email. It can save a lot of time when you have
multiple versions of the patch series.
Anyway, I
is never used, but this is
intentional. This patch adds a do-nothing reference to silence the
warning.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Bill Paul wp...@windriver.com
You should add Cc's here (package owners are in Maintainers.txt):
Cc: Jordan Justen
: Jordan Justen jordan.l.jus...@intel.com to the commit
message, then git send-email will automatically add the Cc's when sending the
email. It can save a lot of time when you have multiple versions of the patch
series.
Anyway, I guess with the long commit message lines fixed, then patches
On 2015-07-08 19:31:09, Scott Duplichan wrote:
Bruce Cran [mailto:br...@cran.org.uk] wrote:
]Sent: Wednesday, July 08, 2015 05:12 PM
]To: edk2-devel@lists.sourceforge.net
]Subject: Re: [edk2] [PATCH] BaseTools/GCC: allow unused but set variables
]
]On Wed, Jul 08, 2015 at 10:43:38PM +0200,
On 2015-07-10 00:18:15, Laszlo Ersek wrote:
Ooops :)
Apparently I was too quick to commit this, without waiting for your
review. Anyway, some comments:
On 07/10/15 09:05, Jordan Justen wrote:
Patch subject doesn't contain a package/module prefix. I suggest:
OvmfPkg/QemuFwCfgLib
On 2015-07-10 10:46:19, Bill Paul wrote:
Of all the gin joints in all the towns in all the world, Jordan Justen had to
walk into mine at 00:53:23 on Friday 10 July 2015 and say:
On 2015-07-10 00:18:15, Laszlo Ersek wrote:
Ooops :)
Apparently I was too quick to commit this, without
On 2015-07-10 04:29:11, Laszlo Ersek wrote:
On 07/10/15 10:40, Wu, Jiaxin wrote:
Yes, edk2-devel will strip it. You can check version2 for those
series patches, I had added someone with cc tag to the commit
message, but it haven't actually cc to those people.
(3) Laszlo will get a copy
Fork a new thread from the BaseTools/GCC: allow unused but set
variables thread...
Forwarded message from Laszlo Ersek (2015-07-08 21:56:36):
On 07/09/15 01:42, Jordan Justen wrote:
What about a lower bar for committing build break fixes? What if we
said that compiler warning fixes could
On 2015-07-08 00:09:40, Bruce Cran wrote:
On Tue, Jul 07, 2015 at 09:32:39PM -0700, Jordan Justen wrote:
Reviewed-by: Jordan Justen jordan.l.jus...@intel.com
Could it be committed to the UDK2014.SP1 branch as well as master, please?
Bruce,
I'm not sure of the update process for that branch
I think the period (.) at the end of the commit message just wastes a
valuable subject line character. :) Your subject line is 87
characters, and I think the recommendation is for 70 characters or
less.
https://github.com/tianocore/tianocore.github.io/wiki/Commit-Message-Format
On 2015-07-07
Regarding the commit message, how about:
===
SecurityPkg/Pkcs7VerifyDxe: Cleanup P7CheckTrust function comments
The comments for P7CheckTrust described Content and ContentSize
parameters, but they don't exist.
===
With the updated commit message:
Reviewed-by: Jordan Justen jordan.l.jus
On 2015-07-08 08:58:04, Laszlo Ersek wrote:
On 07/08/15 17:02, Ard Biesheuvel wrote:
On 8 July 2015 at 16:59, Olivier Martin olivier.mar...@arm.com wrote:
For ARM architectures, I only disable this flag for RELEASE build:
OK, I hadn't noticed that. This means my patch would be only for
[0x8000_, 0x_] and [0x0, 0x] ranges, respectively.
Cc: Jordan Justen jordan.l.jus...@intel.com
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek ler...@redhat.com
Regression-tested-by: Gabriel Somlo so...@cmu.edu
---
OvmfPkg/PciHostBridgeDxe
To: Laszlo Ersek; Ni, Ruiyu
Cc: edk2-devel@lists.sourceforge.net; Kinney, Michael D; Gerd Hoffmann
Subject: Re: [edk2] [PATCH v2 02/24] PcAtChipsetPkg: remove
PciHostBridgeDxe
On 2015-07-06 15:10:45, Laszlo Ersek wrote:
On 06/28/15 01:36, Jordan Justen wrote:
On 2015-06-25 21:26
1-19 Reviewed-by: Jordan Justen jordan.l.jus...@intel.com
On 2015-07-07 08:09:21, Laszlo Ersek wrote:
This field was supposed to store the number of root buses created; however
we don't need to keep that count persistently. After the entry point returns,
nothing reads this field.
Cc: Jordan
seabios scan up to 255 if the fw_cfg entry is not found?
-Jordan
little-endian UINT64 value that exposes the number of extra root buses. We
can use this value to terminate the scan as soon as we find the last extra
root bus.
Cc: Jordan Justen jordan.l.jus...@intel.com
Contributed-under
I think maybe the subject could be improved. I prefer to describe the
problem instead.
IntelFrameworkPkg FrameworkUefiLib: Fix ASSERT in CatVSPrint
Then, I think you can mention the r17740 regression in the main body
of the commit message.
I also have a suggestion below.
On 2015-07-07
Reviewed-by: Jordan Justen jordan.l.jus...@intel.com
On 2015-07-07 18:02:16, Bruce Cran wrote:
The bash binary can be in various locations depending on the system: on Linux
it's in /bin while on BSD it's normally in /usr/local/bin. However, the
env binary is almost always in /usr/bin and so
To: Laszlo Ersek; Ni, Ruiyu
Cc: edk2-devel@lists.sourceforge.net; Kinney, Michael D; Gerd Hoffmann
Subject: Re: [edk2] [PATCH v2 02/24] PcAtChipsetPkg: remove
PciHostBridgeDxe
On 2015-07-06 15:10:45, Laszlo Ersek wrote:
On 06/28/15 01:36, Jordan Justen wrote:
On 2015-06-25
On 2015-07-04 15:56:05, B Cran wrote:
On May 4, 2015, at 2:21 PM, Peterson, Joe joe.peter...@intel.com
wrote:
Due to community feedback, a new mailing list is being set up to replace
this one. The new list will be hosted on Lists.01.org and should be more
stable and consistent than this
On 2015-07-06 15:10:45, Laszlo Ersek wrote:
On 06/28/15 01:36, Jordan Justen wrote:
On 2015-06-25 21:26:20, Ni, Ruiyu wrote:
Jordan,
Simply using PCD to split the code is very straightforward. Another
approach is to introduce a new library class with carefully defined
library APIs so
On 2015-07-01 23:51:19, Ard Biesheuvel wrote:
On 2 July 2015 at 08:38, Ard Biesheuvel ard.biesheu...@linaro.org wrote:
Liming, Jordan, Jiewen.
I appeared to have screwed up something performing the push
Could you please rewind SVN to r17801 ?
Apologies for sounding a bit panicky,
aligned GNU ld
linker script
On 2 July 2015 at 02:54, Jordan Justen jordan.l.jus...@intel.com wrote:
On 2015-07-01 17:41:11, Gao, Liming wrote:
Jordan:
Agree. We will follow this rule, apply the patch and push it
without any modification.
My point is that if there is a mistake, we
On 2015-07-02 00:10:40, Jordan Justen wrote:
On 2015-07-01 23:51:19, Ard Biesheuvel wrote:
On 2 July 2015 at 08:38, Ard Biesheuvel ard.biesheu...@linaro.org wrote:
Liming, Jordan, Jiewen.
I appeared to have screwed up something performing the push
Could you please rewind SVN
-by: Jordan Justen jordan.l.jus...@intel.com
I didn't actually give my r-b for patch 8 or 9. (I wanted to see how
the commit message was re-worded first.)
But, if you fix the subject line of these patches to be more like
patch 10, then you can keep my r-b on them.
Oh ... I see you already
merged variable driver.
And I also added notes in cover letter of V3 patchset According to
the feedback from Laszlo Ersek ler...@redhat.com, Ard Biesheuvel
ard.biesheu...@linaro.org and Jordan Justen
jordan.l.jus...@intel.com, update the patches for ArmVirtPkg and
update some commit messages
In the future, can you use git bash with 'git send-email *.patch' so
all the emails in your patch series will be sent as a single email
thread?
The TortoiseGit GUI can't do this correctly. I think that you'll also
find that 'git send-email *.patch' is faster.
Thanks,
-Jordan
On 2015-06-25
On 2015-07-01 01:34:56, Liu, Yingke D wrote:
Hi Ard,
Thanks for the comments, I have updated the log message.
For future reference, I think you should not bother to update the log
message. It is a bad practice, and the git archive will not see the
updated log message anyhow. It should also be
On 2015-07-01 17:41:11, Gao, Liming wrote:
Jordan:
Agree. We will follow this rule, apply the patch and push it
without any modification.
My point is that if there is a mistake, we should not bother to update
the log message to fix that mistake. Hopefully we can just be more
careful with
message similar to that, you can add my
Reviewed-by: Jordan Justen jordan.l.jus...@intel.com
to the patch you attached.
Thanks,
-Jordan
-Original Message-
From: Zeng, Star [mailto:star.z...@intel.com]
Sent: Monday, June 29, 2015 1:07 PM
To: Justen, Jordan L; edk2-devel
suggestion?
Nt32Pkg: Use the merged Variable driver.
OvmfPkg: Use the merged Variable driver.
The period (.) seems unnecessary at the end of the subject line.
For these two, you can add
Reviewed-by: Jordan Justen jordan.l.jus...@intel.com
-Jordan
On 2015-06-26 01:37:47, Star Zeng wrote:
Link AuthVariableLibNull and TpmMeasurementLibNull in MdeModulePkg.
Cc: Jordan Justen jordan.l.jus...@intel.com
Cc: Andrew Fish af...@apple.com
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng star.z...@intel.com
Patches 1-4 7-9: Reviewed-by: Jordan Justen jordan.l.jus...@intel.com
For Patches 5 6, I would like to ask if the 'end-of-dxe' signal
could be added as separate patches. (Inserted before 5/6, I assume.)
Would that be possible, or would the S3 interdependencies prevent it?
It seems like
Jordan, Ray,
On 06/25/15 19:14, Jordan Justen wrote:
On 2015-06-24 19:10:01, Ni, Ruiyu wrote:
Jordan,
I prefer to share the code across multiple platforms as well, if
that's possible.
In real world, DUET's PciHostBridgeDxe driver does something
additionally: it gathers
a chance to look at this though.
Acked-by: Jordan Justen jordan.l.jus...@intel.com
--
Monitor 25 network devices or servers for free with OpManager!
OpManager is web-based network management software that monitors
network
maoming.maom...@huawei.com
Reviewed-by: Jordan Justen jordan.l.jus...@intel.com
---
Notes:
v2:
- update comments [Jordan]
- calculate the size of the low 384 KB uncacheable hole as Jordan
suggested
OvmfPkg/PlatformPei/MemDetect.c | 46 ++--
1 file
)
+ASSERT_EFI_ERROR (Status);
+
How about a comment: Set MMIO just below 4GB to uncacheable
+Status = MtrrSetMemoryAttribute (LowerMemorySize,
+ SIZE_4GB - LowerMemorySize, CacheUncacheable);
+ASSERT_EFI_ERROR (Status);
Patches 2-4:
Reviewed-by: Jordan Justen jordan.l.jus...@intel.com
On 2015-06-22 12:22:54, Brian J. Johnson wrote:
I stuck those calculations in gnumeric (assuming Page1GSupport==FALSE)
and got this:
PABits Pml4Pdp TotPgs MB
-- --- -- --
36 1 64 66 0.258
37 1 128 130 0.508
38 1
On 2015-06-16 10:05:24, Laszlo Ersek wrote:
We'll soon increase the maximum guest-physical RAM size supported by OVMF.
For more RAM, the DXE IPL is going to build more page tables, and for that
it's going to need a bigger chunk from the permanent PEI RAM.
Otherwise
On 2015-06-22 12:07:05, Laszlo Ersek wrote:
On 06/22/15 20:34, Jordan Justen wrote:
What if you make a calculation of how big the tables should be and
then add 64 MB to it?
Any calculation I could come up with (ie. how much RAM *I* would need
for identity mapping the address sapce) would
a reasonable fall-back default.
I wonder if someone wants to do something similar for Xen?
Reviewed-by: Jordan Justen jordan.l.jus...@intel.com
those are limited to 2.x (both in the guest kernel firmware driver, and in
the dmidecode utility).
The v2.1.0+ machine types of QEMU generate SMBIOS payload
On 2015-06-12 04:19:09, qlong wrote:
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Long, Qin qin.l...@intel.com
Signed-off-by: qlong qin.l...@intel.com
Your commit message doesn't match the recommended format:
-Original Message-
From: Justen, Jordan L
Sent: Tuesday, June 9, 2015 12:56 AM
To: Gao, Liming; edk2-devel@lists.sourceforge.net
Subject: RE: [edk2] [Patch] BaseTools: Update nasmb build rule
On 2014-11-21 10:16:47, Jordan Justen wrote:
On 2014-11-20 22:12:42, Gao, Liming wrote
Series Reviewed-by: Jordan Justen jordan.l.jus...@intel.com
and committed. Thanks for the contribution!
On 2015-06-08 17:16:14, Paulo Alcantara wrote:
This patch initialises root complex register block BAR in order to
support TCO watchdog emulation features (e.g. reboot upon NO_REBOOT bit
10:16:47, Jordan Justen wrote:
On 2014-11-20 22:12:42, Gao, Liming wrote:
Jordan:
NASMB is replacement of ASM16.
I see .nasmb as an alternative, but not a replacement. (.asm16 is
still supported by EDK II.)
I do hope that long term it replaces all uses of .asm16 though
On 2015-06-08 00:51:27, Laszlo Ersek wrote:
On 06/07/15 06:51, Jordan Justen wrote:
On 2015-06-05 16:47:40, Laszlo Ersek wrote:
The first 9 patches are uninteresting (although they certainly decimated
my grey matter):
- Patch #1 copies PciHostBridgeDxe from PcAtChipsetPkg to OvmfPkg
On 2015-06-08 02:06:40, Laszlo Ersek wrote:
On 06/06/15 21:10, Paulo Alcantara wrote:
diff --git a/OvmfPkg/OvmfPkg.dec b/OvmfPkg/OvmfPkg.dec
index 4cb70dc..a6586f3 100644
--- a/OvmfPkg/OvmfPkg.dec
+++ b/OvmfPkg/OvmfPkg.dec
@@ -78,6 +78,10 @@
# to PIIX4 function 3 offset 0x40-0x43
... and make mHostBridgeDevId a global var, and then conditionally add
the memory io HOB?
I don't think it is critical, but with that
Reviewed-by: Jordan Justen jordan.l.jus...@intel.com
-Jordan
+// 0xFED2gap 896 KB
// 0xFEE0LAPIC
On 2014-11-21 10:16:47, Jordan Justen wrote:
On 2014-11-20 22:12:42, Gao, Liming wrote:
Jordan:
NASMB is replacement of ASM16.
I see .nasmb as an alternative, but not a replacement. (.asm16 is
still supported by EDK II.)
I do hope that long term it replaces all uses of .asm16 though
On 2015-06-04 10:47:37, Laszlo Ersek wrote:
Jiewen,
On 06/04/15 16:34, Yao, Jiewen wrote: Hi
Here is patch to support UEFI2.5, chapter 4, section 4.6 Properties
Table feature.
MdePkg \u2013 add Properties table definition.
MdeModulePkg \u2013 add properties table support in DXE
On 2015-06-07 20:44:16, Kinney, Michael D wrote:
+
+TheUcs2Codec = Ucs2Codec()
This is creating a global object in this module for the USC-2 codec.
Needs a comment to describe this.
Ok.
How about:
## Instance of Ucs2Codec class
#
# This object is used to support a codec for UCS-2 encoding
On 2015-06-05 16:47:40, Laszlo Ersek wrote:
The first 9 patches are uninteresting (although they certainly decimated
my grey matter):
- Patch #1 copies PciHostBridgeDxe from PcAtChipsetPkg to OvmfPkg.
Arg. After I have bugged the DuetPkg and CorebootPayloadPkg package
owners to try to fixup
On 2015-06-06 12:10:03, Paulo Alcantara wrote:
This patch initialises root complex register block BAR in order to
support TCO watchdog emulation features (e.g. reboot upon NO_REBOOT bit
not set) on QEMU.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Paulo Alcantara
On 2015-05-13 16:53:58, Roy Franz wrote:
This patch adds new terminal type, LinuxTerm, to TerminalDxe. This terminal
type provides a place to add support for various Linux terminals that don't
behave like standard VT terminals.
Signed-off-by: Roy Franz roy.fr...@linaro.org
points because they are reserved for the surrogate pair usage in
UTF-16 files.
This test was fixed by the previous commit:
BaseTools/UniClassObject: Verify valid UCS-2 chars in UTF-16 .uni files
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jordan Justen jordan.l.jus
, UTF-16)
string data. If the UTF-16 LE or BE BOM is found, then the file is
read as UTF-16. Otherwise, it is treated as UTF-8.
Jordan Justen (10):
BaseTools/Tests: Always add BaseTools source to import path
BaseTools/EdkLogger: Support unit tests with a SILENT log level
BaseTools/Tests: Add unit
This verifies that a UTF-16 data (with BOM) .uni file is successfully
read.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jordan Justen jordan.l.jus...@intel.com
Cc: Yingke D Liu yingke.d@intel.com
---
BaseTools/Tests/CheckUnicodeSourceFiles.py | 88
'
commit
v3:
* Restrict the entire file's characters (including comments) to the
UCS-2 range in addition to string data. (mdkinney)
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jordan Justen jordan.l.jus...@intel.com
Cc: Yingke D Liu yingke.d@intel.com
Cc: Michael D
-by: Jordan Justen jordan.l.jus...@intel.com
Cc: Yingke D Liu yingke.d@intel.com
---
BaseTools/Tests/CheckUnicodeSourceFiles.py | 25 +
1 file changed, 25 insertions(+)
diff --git a/BaseTools/Tests/CheckUnicodeSourceFiles.py
b/BaseTools/Tests/CheckUnicodeSourceFiles.py
characters.
v4:
* Reject code points in 0xd800-0xdfff range since they are reserved
for UTF-16 surrogate pairs. (lersek)
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jordan Justen jordan.l.jus...@intel.com
Cc: Yingke D Liu yingke.d@intel.com
Cc: Michael D Kinney
This allows the unit tests to run without the errors logging to the
screen.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jordan Justen jordan.l.jus...@intel.com
Cc: Yingke D Liu yingke.d@intel.com
---
BaseTools/Source/Python/Common/EdkLogger.py | 9 -
1 file
We test a simple case of UTF-8 with and without the UTF-8 BOM.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jordan Justen jordan.l.jus...@intel.com
Cc: Yingke D Liu yingke.d@intel.com
Cc: Michael D Kinney michael.d.kin...@intel.com
Cc: Laszlo Ersek ler...@redhat.com
running the unit test files individually which can
be faster for developing the new unit test cases.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jordan Justen jordan.l.jus...@intel.com
Cc: Yingke D Liu yingke.d@intel.com
---
BaseTools/Tests/RunTests.py | 2
This command was used to convert the file:
iconv -f UTF-16 -t UTF-8 \
-o OvmfPkg/PlatformDxe/Platform.uni \
OvmfPkg/PlatformDxe/Platform.uni
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jordan Justen jordan.l.jus...@intel.com
Reviewed-by: Laszlo Ersek ler
they are reserved for the surrogate pair usage in
UTF-16 files.
We test that this case is rejected for UTF-8 with and without the
UTF-8 BOM.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jordan Justen jordan.l.jus...@intel.com
Cc: Yingke D Liu yingke.d@intel.com
Cc: Michael
On 2015-06-03 12:01:58, Andrew Fish wrote:
On Jun 3, 2015, at 7:50 AM, Brian J. Johnson bjohn...@sgi.com wrote:
I fully agree with others' reluctance to use git submodules, and the
reasons they have expressed: git submodules are a major pain for
developers, and the concerns Liming listed
On 2015-06-03 18:17:26, Andrew Fish wrote:
On Jun 3, 2015, at 5:59 PM, Roy Franz roy.fr...@linaro.org wrote:
Honestly if the choice comes down to an EDK2 upstream being git with
40 submodules, or
a single SVN repository (with a git mirror), I'd rather have the
single
On 2015-06-03 13:00:30, Jordan Justen wrote:
But, even if you try to consider alternatives to submodules for
composing platform trees, things get complicated.
One idea, is to fork the EDK II master tree, and add submodules for
your platform specific modules. To me this ends up with the worst
This allows the unit tests to run without the errors logging to the
screen.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jordan Justen jordan.l.jus...@intel.com
Cc: Yingke D Liu yingke.d@intel.com
---
BaseTools/Source/Python/Common/EdkLogger.py | 9 -
1 file
This verifies that a UTF-16 data (with BOM) .uni file is successfully
read.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jordan Justen jordan.l.jus...@intel.com
Cc: Yingke D Liu yingke.d@intel.com
---
BaseTools/Tests/CheckUnicodeSourceFiles.py | 88
characters.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jordan Justen jordan.l.jus...@intel.com
Cc: Yingke D Liu yingke.d@intel.com
Cc: Michael D Kinney michael.d.kin...@intel.com
Cc: Laszlo Ersek ler...@redhat.com
---
BaseTools/Source/Python/AutoGen/UniClassObject.py | 84
This command was used to convert the file:
iconv -f UTF-16 -t UTF-8 \
-o OvmfPkg/PlatformDxe/Platform.uni \
OvmfPkg/PlatformDxe/Platform.uni
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jordan Justen jordan.l.jus...@intel.com
Reviewed-by: Laszlo Ersek ler
editors
This series allows .uni files to contain UTF-8 (or, as before, UTF-16)
string data. If the UTF-16 LE or BE BOM is found, then the file is
read as UTF-16. Otherwise, it is treated as UTF-8.
Jordan Justen (8):
BaseTools/Tests: Always add BaseTools source to import path
BaseTools/EdkLogger
: Verify valid UCS-2 chars in UTF-16 .uni files
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jordan Justen jordan.l.jus...@intel.com
Cc: Yingke D Liu yingke.d@intel.com
Cc: Michael D Kinney michael.d.kin...@intel.com
Cc: Laszlo Ersek ler...@redhat.com
---
BaseTools
'
commit
v3:
* Restrict the entire file's characters (including comments) to the
UCS-2 range in addition to string data. (mdkinney)
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jordan Justen jordan.l.jus...@intel.com
Cc: Yingke D Liu yingke.d@intel.com
Cc: Michael D
running the unit test files individually which can
be faster for developing the new unit test cases.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jordan Justen jordan.l.jus...@intel.com
Cc: Yingke D Liu yingke.d@intel.com
---
BaseTools/Tests/RunTests.py | 2
-by: Jordan Justen jordan.l.jus...@intel.com
Cc: Yingke D Liu yingke.d@intel.com
---
BaseTools/Tests/CheckUnicodeSourceFiles.py | 25 +
1 file changed, 25 insertions(+)
diff --git a/BaseTools/Tests/CheckUnicodeSourceFiles.py
b/BaseTools/Tests/CheckUnicodeSourceFiles.py
On 2015-06-01 02:46:53, Laszlo Ersek wrote:
On 06/01/15 09:31, Jordan Justen wrote:
Supplementary Plane characters can exist in UTF-16 files,
but they are not valid UCS-2 characters.
For example, refer to this python interpreter code:
import codecs
codecs.encode(u'\U00010300', 'utf
On 2015-05-29 09:07:19, Laszlo Ersek wrote:
On 05/29/15 17:46, Bruce Cran wrote:
I have some fixes to Vlv2TbltDevicePkg/PlatformSetupDxe/VfrStrings.uni
such as changing Congfiguration to Configuration, but since it's
UTF-16 git treats it as binary.
How should we send patches for such
For your attached patch:
Reviewed-by: Jordan Justen jordan.l.jus...@intel.com
On 2015-05-28 03:26:13, Zeng, Star wrote:
Olivier,
Thanks, see the attached patch.
Star
-Original Message-
From: Olivier Martin [mailto:olivier.mar...@arm.com]
Sent: Thursday, May 28, 2015 5:40 PM
For *.asm and *.s, there have been cases of *.Asm and *.S files, but
since the nasm extensions are new, we don't need to support the upper
case extensions.
In other words, remove .Nasm and .NASM.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jordan Justen jordan.l.jus
this adds is that they can add 1.Nasm to the .inf
so long as they also check in 1.Nasm. I don't think this is too
useful.
-Jordan
-Original Message-
From: Jordan Justen [mailto:jordan.l.jus...@intel.com]
Sent: Thursday, May 28, 2015 8:14 AM
To: edk2-devel@lists.sourceforge.net
Subject: [edk2
On 2015-05-27 10:20:09, Laszlo Ersek wrote:
On 05/27/15 18:06, Andrew Fish wrote:
On May 27, 2015, at 1:52 AM, Laszlo Ersek ler...@redhat.com
mailto:ler...@redhat.com wrote:
Access on the web looks like a step forward (eg. it provides syntax
highlighting), but it's actually a small
);
The code style would want a space after the cast close parens, right?
Reviewed-by: Jordan Justen jordan.l.jus...@intel.com
} else {
return MemoryType;
}
--
2.1.1
On 2015-05-20 14:08:40, Jonathan Doman wrote:
+STATIC
+EFI_STATUS
+PosixExtendedMatch (
+ IN CHAR16 *String,
+ IN CHAR16 *Pattern,
+ OUT BOOLEAN *Result,
+ OUT EFI_REGEX_CAPTURE **Captures, OPTIONAL
+ OUT UINTN *CapturesCount
On 2015-05-27 13:45:45, El-Haj-Mahmoud, Samer wrote:
Eric,
I do not see how system firmware can reliably support multiple RegEx
implementations using a single Regular_Expression_Protocol instance.
That was definitely not the intention of, nor was it called for in
the UEFI 2.5 specification.
On 2015-05-22 09:27:47, Doman, Jonathan wrote:
Hi Ray, thanks for the feedback.
1. As you noticed, a valid handle is always returned whenever
possible so that an error message can be retrieved. But this does
complicate things, since RegExFree must then be called on all paths.
I suppose a
On 2015-05-26 08:22:22, Doman, Jonathan wrote:
But regarding the protocol, EFI_REGULAR_EXPRESSION_PROTOCOL is
already defined in MdePkg as part of UEFI 2.5 implementation. I
think providing a sample implementation in MdeModulePkg is
reasonable.
Yep, you are right. I missed that one. I have a
On 2015-05-20 14:08:40, Jonathan Doman wrote:
Add RegularExpressionDxe driver. Add RegExLib library header and sample
implementation SlreRegExLib, based on open-source SLRE library (old
version with permissive license).
I think you should mention THE BEER-WARE LICENSE (Revision 42) here.
But,
1 - 100 of 986 matches
Mail list logo
