Reviewed-by: Qin Long
> -Original Message-
> From: Zhang, Chao B
> Sent: Tuesday, July 28, 2015 10:08 AM
> To: edk2-devel@lists.sourceforge.net
> Cc: Long, Qin; Zhang, Chao B
> Subject: [PATCH] SecurityPkg: Change TPM MMIO range attribute
>
> For TCG spec com
That's great. If so, we can remove the install script then.
Best Regards & Thanks,
LONG, Qin
-Original Message-
From: David Woodhouse [mailto:dw...@infradead.org]
Sent: Friday, July 24, 2015 3:49 PM
To: Long, Qin; Andrew Fish
Cc: edk2-devel@lists.sourceforge.net
Subject:
irectly in Windows. That's why we need one install script before to
make sure all header files were in place.
Best Regards & Thanks,
LONG, Qin
-Original Message-
From: David Woodhouse [mailto:dw...@infradead.org]
Sent: Friday, July 24, 2015 4:49 AM
To: Andrew
The patch is good.
Reviewed-by: Qin Long
Best Regards & Thanks,
LONG, Qin
-Original Message-
From: Zhang, Chao B
Sent: Wednesday, July 15, 2015 8:43 AM
To: edk2-devel@lists.sourceforge.net
Cc: Long, Qin; Zhang, Chao B
Subject: [PATCH] SecurityPkg: Fix DBX Variable Read Erro
The patch looks good.
And I prefer to update the commit log:
"Correct the variable measurement behavior to include whole EFI_VARIABLE_DATA
structure, for the latest specification compliance."
Reviewed-by: Qin Long
Best Regards & Thanks,
LONG, Qin
-Original Message-
Fro
Reviewed-by: Qin Long
(Bruce, thanks for catching this, And sorry for late feedback due to my recent
leave)
Best Regards & Thanks,
LONG, Qin
-Original Message-
From: Bruce Cran [mailto:br...@cran.org.uk]
Sent: Wednesday, July 8, 2015 1:15 AM
To: Long, Qin; edk2-d
Shumin,
And please update the commit log for better explanation per Leif's suggestion.
Best Regards & Thanks,
LONG, Qin
-Original Message-----
From: Long, Qin [mailto:qin.l...@intel.com]
Sent: Monday, July 13, 2015 4:49 PM
To: Qiu, Shumin; edk2-devel@lists.sourceforge.net
Su
Reviewed-by: Qin Long < qin.l...@intel.com>
Best Regards & Thanks,
LONG, Qin
-Original Message-
From: Qiu, Shumin
Sent: Tuesday, July 7, 2015 4:42 PM
To: edk2-devel@lists.sourceforge.net
Cc: Qiu, Shumin; Long, Qin
Subject: [edk2][PATCH 2/2] CryptoPkg: Refine the functio
Reviewed-by: Qin Long < qin.l...@intel.com>
Best Regards & Thanks,
LONG, Qin
-Original Message-
From: Qiu, Shumin
Sent: Tuesday, July 7, 2015 4:42 PM
To: edk2-devel@lists.sourceforge.net
Cc: Qiu, Shumin; Long, Qin
Subject: [edk2][PATCH 1/2] SecurityPkg: Refine the functio
Ard,
This looks good to me. (And thanks for doing this. I was out of office this
week, so sorry for late response.)
Reviewed-by: Qin Long
Best Regards & Thanks,
LONG, Qin
-Original Message-
From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
Sent: Friday, July 10, 2015 5:2
ch in
trusted store (by comparing memory). I guess the issue in your side may be
caused by some inaccuracy when converting certificate format (e.g. PEM <->
DER).
Best Regards & Thanks,
LONG, Qin
-Original Message-
From: Gary Ching-Pang Lin [mailto:g...@suse.com]
Sent:
about this
X509_V_ERR_DEPTH_ZERO_SELF_SIGNED_CERT check may bring extra risk.
Best Regards & Thanks,
LONG, Qin
-Original Message-----
From: Long, Qin [mailto:qin.l...@intel.com]
Sent: Friday, July 03, 2015 2:06 PM
To: edk2-devel@lists.sourceforge.net
Subject: Re: [edk2] [PATCH] CryptoP
Regards & Thanks,
LONG, Qin
-Original Message-
From: Gary Ching-Pang Lin [mailto:g...@suse.com]
Sent: Friday, July 03, 2015 12:06 PM
To: edk2-devel@lists.sourceforge.net
Subject: Re: [edk2] [PATCH] CryptoPkg: Allow the depth zero self-signed
certificate
On Fri, Jul 03, 2015 at 11:37:22AM +
Reviewed-by: Qin Long
Best Regards & Thanks,
LONG, Qin
-Original Message-
From: Zhang, Chao B
Sent: Tuesday, June 23, 2015 10:26 PM
To: edk2-devel@lists.sourceforge.net
Cc: Long, Qin; Zhang, Chao B
Subject: [Patch] SecurityPkg: Provide correct file GUID for Pkcs7VerifyDxe
Pro
Reviewed-by: Qin Long
Best Regards & Thanks,
LONG, Qin
-Original Message-
From: Long, Qin [mailto:qin.l...@intel.com]
Sent: Tuesday, June 23, 2015 10:12 PM
To: Ard Biesheuvel; Laszlo Ersek
Cc: edk2-devel@lists.sourceforge.net
Subject: Re: [edk2] [PATCH] CryptoPkg: Openss
Laszlo,
Yes, the EFIAPI definition for ERR_add_error_data() was missed in this updated
patch file.
It's cool. Thanks for catching this.
Best Regards & Thanks,
LONG, Qin
-Original Message-
From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
Sent: Tuesday, June 23, 2015
Yeah, I think it's good. Move first, and fix later. :-)
Best Regards & Thanks,
LONG, Qin
-Original Message-
From: El-Haj-Mahmoud, Samer [mailto:samer.el-haj-mahm...@hp.com]
Sent: Tuesday, June 23, 2015 1:07 AM
To: edk2-devel@lists.sourceforge.net
Subject: Re: [edk2] [
e was also stripped from the P7 data);
The test result is passed.
So looks the basic image verification should be OK. We may need extra efforts
on root-cause. Will do more booting validations on my workstation later. :-)
Peter, any suggestion against this?
Best Regards & Thanks,
LONG, Qin
nough.
Best Regards & Thanks,
LONG, Qin
-Original Message-
From: Scott Duplichan [mailto:sc...@notabs.org]
Sent: Saturday, June 20, 2015 10:25 AM
To: edk2-devel@lists.sourceforge.net
Subject: Re: [edk2] [PATCH 1/2] SecurityPkg: Add RandLib from existing RngDxe
code
El-Haj-Mahmo
Regards & Thanks,
LONG, Qin
-Original Message-
From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
Sent: Saturday, June 20, 2015 9:01 PM
To: Laszlo Ersek
Cc: edk2-devel@lists.sourceforge.net
Subject: Re: [edk2] [patch 0/3] *** Update OpenSSL support to 1.0.2c release ***
On 20
This looks good.
Reviewed-by: Qin Long
Best Regards & Thanks,
LONG, Qin
-Original Message-
From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
Sent: Tuesday, June 16, 2015 8:58 PM
To: edk2-devel@lists.sourceforge.net; Long, Qin
Cc: ler...@redhat.com; Ard Biesheuvel
Sub
me to correct the patch format
per Jordon's comments directly.
Ard & Ting, this update for 1.0.2c is almost same with 1.0.2b-patch, except
letter changes ("b"->"c"). :-)
Best Regards & Thanks,
LONG, Qin
-Original Message-
From: Long, Qin [mailto:qin.l.
This patch updates the INF file, installation scripts and HOWTO file
in OpensslLib for openssl-1.0.2c support.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Long, Qin
---
CryptoPkg/Library/OpensslLib/Install.cmd | 146 ---
CryptoPkg/Library/OpensslLib/Install.sh
This patch updates some support header and wrapper files to support
openssl-1.0.2c build, and correct some openssl API usages and
boundary check.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Long, Qin
---
CryptoPkg/Include/OpenSslSupport.h| 8
This patch adds a patch file for openssl-1.0.2c, and removes
the patch file for openssl-0.9.8zf.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Long, Qin
---
.../Library/OpensslLib/EDKII_openssl-0.9.8zf.patch | 279 -
.../Library/OpensslLib/EDKII_openssl
r 2015. This patch updates the EDKII openssl support to the
latest 1.0.2 branch.
Long, Qin (3):
CryptoPkg: Update openssl patch file from 0.9.8zf to 1.0.2c
CryptoPkg: Update OpensslLib module files for openssl-1.0.2c support
CryptoPkg: Wrapper files updates to support openssl-1.0.2c
Cry
Copy that. Will update those when committing the patch.
Thanks, Jordan.
Best Regards & Thanks,
LONG, Qin
-Original Message-
From: Justen, Jordan L
Sent: Saturday, June 13, 2015 5:50 AM
To: edk2-devel@lists.sourceforge.net; Long, Qin; Ye, Ting;
ard.biesheu...@linaro.org
Cc: edk2-d
That's great, Thanks, Ard.
(I still re-create one patch based on the just-cloned tree, with the patch name
fix. :-)).
Best Regards & Thanks,
LONG, Qin
-Original Message-
From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
Sent: Friday, June 12, 2015 4:58 PM
To: Long, Q
It's strange, the patch was created based on one clean tree.
The following should have only two spaces, there one space for "+" / "-"
region.
>DebugLib
There are 3 spaces before DebugLib, but there are only 2 in the original
file
Best Regards &
Sorry, it's one typo. Will re-send one to fix this.
-Original Message-
From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
Sent: Friday, June 12, 2015 4:52 PM
To: Long, Qin
Cc: Ye, Ting; edk2-devel@lists.sourceforge.net
Subject: Re: [patch 1/3] [CryptoPkg] Remove the old patch
E_PEM_write_fp_const definition if OPENSSL_NO_FP_API was
used in pem.h
Wrong memory allocation for paramid in x509_vpm.c
..
At least, there should be valuable to upstream these changes, and we will have
smaller patch in future. :-)
Best Regards & Thanks,
LONG, Qin
-Or
I agree. Thanks, Ard.
Sorry for the obfuscation caused by this. :-)
Best Regards & Thanks,
LONG, Qin
-Original Message-
From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
Sent: Wednesday, June 10, 2015 6:21 PM
To: Long, Qin
Cc: Ye, Ting; edk2-devel@lists.sourceforge.net
Sub
patch those __FILE__ macro
then. :-(
I keep this for all later updates.
Best Regards & Thanks,
LONG, Qin
-Original Message-
From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
Sent: Wednesday, June 10, 2015 7:55 PM
To: Long, Qin
Cc: Ye, Ting; edk2-devel@lists.sourceforge.net
Su
The fix looks good.
Reviewed-by: Long, Qin
-Original Message-
From: Zhang, Chao B
Sent: Tuesday, June 09, 2015 10:11 AM
To: Long, Qin
Cc: edk2-devel@lists.sourceforge.net; Zhang, Chao B
Subject: [Patch] SecurityPkg: Fix wrong cert data measurement in DBX path
Fix wrong cert data
Copy that. Thanks biesheuvel.
I will double-check the GCC building.
Best Regards & Thanks,
LONG, Qin
-Original Message-
From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
Sent: Friday, June 5, 2015 5:20 PM
To: edk2-devel@lists.sourceforge.net
Subject: Re: [edk2] [patch
to get the signer’s certificate from the signedData;
-> Use X509GetSubjectName() to retrieve the name string from the signer’s X509
certificate;
The subject names (e.g. XYZ company name and ABC company name) could be used to
distinguish a particular image here.
Best Regards & Thanks,
LO
This looks good.
Reviewed-by: Long, Qin
Best Regards & Thanks,
LONG, Qin
-Original Message-
From: Tian, Feng
Sent: Friday, May 08, 2015 3:37 PM
To: edk2-devel@lists.sourceforge.net
Cc: Long, Qin; Tian, Feng
Subject: [patch] MdePkg: Add missing GUID variables in SmartCardEd
#x27;2', 'S')
I prefer to use the same-case letter for signature: ('H', 'S', '2', 'S')
Reviewed-by: Long, Qin (qin.l...@intel.com)
Best Regards & Thanks,
LONG, Qin
-Original Message-
From: Yao, Jiewen [mailto:jiewen@int
ding the result Authenticode signature. So need
some time to double-check this.
Best Regards & Thanks,
LONG, Qin
-Original Message-
From: James Bottomley [mailto:james.bottom...@hansenpartnership.com]
Sent: Friday, January 23, 2015 10:19 AM
To: edk2-devel@lists.sourceforge.net
Subject: Re
dware/jj923068.aspx
(Measuring UEFI Configuration into PCR[7])
Best Regards & Thanks,
LONG, Qin
From: Anbazhagan, Baraneedharan [mailto:anbazha...@hp.com]
Sent: Sunday, December 14, 2014 10:53 PM
To: edk2-devel@lists.sourceforge.net
Subject: [edk2] Inconsistent TPM PCR7
Hi,
MeasureVariabl
Laszlo, thanks for catching this. This is one serious parentheses-matching
issue.
The patch is good. And I also did one quick validation. Please help to check-in
this fix.
Reviewed-by: Qin Long
Best Regards & Thanks,
LONG, Qin
-Original Message-
From: Laszlo Ersek [mailto
> Qin Long, can you please look at the CryptoPkg patches? They are
> simple, and it's not possible to build OVMF with Secure Boot support without
> them.
Reviewed-by: Qin Long
Laszlo, thanks for catching this build issue.
Best Regards & Thanks,
LONG, Qin
-Original
Of cause.
Best Regards & Thanks,
LONG, Qin
-Original Message-
From: Justen, Jordan L
Sent: Thursday, November 06, 2014 9:23 AM
To: Long, Qin
Cc: Ye, Ting; edk2-devel@lists.sourceforge.net
Subject: RE: [PATCH 0/5] Convert CryptoPkg GNU assembly to NASM
On 2014-11-05 16:58:33,
eful
when some new features were enabled.)
Best Regards & Thanks,
LONG, Qin
-Original Message-
From: Justen, Jordan L
Sent: Thursday, November 06, 2014 2:36 AM
To: Long, Qin
Cc: Ye, Ting; edk2-devel@lists.sourceforge.net
Subject: Re: [PATCH 0/5] Convert CryptoPkg GNU assembly to
Hi, Ard,
The patch has been synced into EDK2 @16165.
Thanks for the updates.
Best Regards & Thanks,
LONG, Qin
-Original Message-
From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
Sent: Friday, September 19, 2014 5:33 AM
To: edk2-devel@lists.sourceforge.net
Subject: [
The patch also looks good to me. Thanks for the updates.
Best Regards & Thanks,
LONG, Qin
-Original Message-
From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
Sent: Friday, September 19, 2014 5:33 AM
To: edk2-devel@lists.sourceforge.net
Subject: [edk2] [PATCH v2] CryptoPkg:
Hi, Martin,
Thanks for the updates.
I will help to follow the process to check-in this patchset.
Best Regards & Thanks,
LONG, Qin
-Original Message-
From: Olivier Martin [mailto:olivier.mar...@arm.com]
Sent: Thursday, August 21, 2014 6:48 PM
To: Ye, Ting
Cc: ronald.c...@arm.com;
Hi, Eugene,
The new patch was checked in @revision 15767 for CryptoPkg (I did some minor
updates for source alignment).
Thanks again for the updates.
Best Regards & Thanks,
LONG, Qin
From: Cohen, Eugene [mailto:eug...@hp.com]
Sent: Thursday, August 07, 2014 4:11 AM
To: edk2-d
Copy that. Thanks, Eugene.
Best Regards & Thanks,
LONG, Qin
From: Cohen, Eugene [mailto:eug...@hp.com]
Sent: Tuesday, August 05, 2014 11:29 PM
To: edk2-devel@lists.sourceforge.net
Subject: Re: [edk2] [PATCH] CryptoPkg: Fix OpenSslLib build for ARM
I agree with Olivier's comments, it&
Thanks, Martin & Eugene.
Eugene, would you like to update your patch to add this kind of correlation
description about the warning number & messages as Martin's comments?
Best Regards & Thanks,
LONG, Qin
From: Olivier Martin [mailto:olivier.mar...@arm.com]
Sent: Monday, Augu
s you mentioned later.
Best Regards & Thanks,
LONG, Qin
From: Andrew Fish [mailto:af...@apple.com]
Sent: Wednesday, July 23, 2014 9:29 AM
To: edk2-devel@lists.sourceforge.net
Subject: [edk2] [CryptoPkg][StdLib] Ia32 calling convention question
CryptoPkg & StdLib maintainers,
It looks to me
Hi, Andrew,
Thanks for the updates.
We will follow the process and check-in this patch later. .
Best Regards & Thanks,
LONG, Qin
From: Andrew Fish [mailto:af...@apple.com]
Sent: Thursday, June 12, 2014 11:38 PM
To: edk2-devel@lists.sourceforge.net
Subject: [edk2] Patches needed to com
(&tcg, (UINT8*)&image_content, len, sha1, &tcgLogData, NULL,
&LastEntry);
Best Regards & Thanks,
LONG, Qin
From: Eric Viseur [mailto:eric.vis...@gmail.com]
Sent: Friday, March 14, 2014 5:02 PM
To: edk2-devel@lists.sourceforge.net
Subject: Re: [edk2] Using the TCG protocol
I&#x
double-check on this.
Best Regards & Thanks,
LONG, Qin
From: Eric Viseur [mailto:eric.vis...@gmail.com]
Sent: Friday, March 14, 2014 3:20 PM
To: edk2-devel@lists.sourceforge.net
Subject: Re: [edk2] Using the TCG protocol
The function returns EFI_SUCCESS (0), which is very strange. I call it with
ee was not patched correctly.
Best Regards & Thanks,
LONG, Qin
From: s.v.krishna reddy [mailto:svkr...@gmail.com]
Sent: Friday, December 13, 2013 2:19 PM
To: edk2-devel@lists.sourceforge.net
Subject: [edk2] OpenSSL Lib compilation error
Hello everyone,
I have followed the instructions menti
FALSE to tell the result.
"Cryptest" application in CryptoPkg can be one reference about the API and
parameter. And NT32 emulator is also one convenient debug environment for your
app bug tracing. :)
Best Regards & Thanks,
LONG, Qin
From: cruxpot [mailto:crux...@gmail.com]
Sent: T
The patch is good. Thanks.
And we helped to commit this change into EDKII project at r14392.
Best Regards & Thanks,
LONG, Qin
-Original Message-
From: Gary Ching-Pang Lin [mailto:g...@suse.com]
Sent: Wednesday, May 29, 2013 11:47 AM
To: edk2-devel@lists.sourceforge.net
Subject: [
return TRUE;
}
return FALSE;
Best Regards & Thanks,
LONG, Qin
-Original Message-
From: Gary Ching-Pang Lin [mailto:g...@suse.com]
Sent: Tuesday, May 28, 2013 5:31 PM
To: edk2-devel@lists.sourceforge.net
Subject: [edk2] [PATCH v2] CryptoPkg/Rand: Return the status of rando
+ return !!RAND_status();;
Best Regards & Thanks,
LONG, Qin
-Original Message-
From: Gary Ching-Pang Lin [mailto:g...@suse.com]
Sent: Friday, May 24, 2013 4:50 PM
To: edk2-devel@lists.sourceforge.net
Subject: [edk2] [PATCH] CryptoPkg/CryptRand.c: Return the status of random
number
Weimer,
Thanks for your feedback.
We will check & evaluate the relative routines.
Best Regards & Thanks,
LONG, Qin
-Original Message-
From: Florian Weimer [mailto:fwei...@redhat.com]
Sent: Thursday, October 25, 2012 3:37 PM
To: edk2-devel@lists.sourceforge.net
Subject: R
d one security vulnerability issue in OpenSSL ASN1 BIO
(http://www.openssl.org/news/secadv_20120419.txt), and that's why EDKII OpenSSL
version was updated to 0.9.8w.
Best Regards & Thanks,
LONG, Qin
-Original Message-
From: Florian Weimer [mailto:fwei...@redhat.com]
S
Sathya,
You can also refer to
https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2/SecurityPkg/Library/DxeImageVerificationLib/DxeImageVerificationLib.c.
Some signature checking logic can be found at function
DxeImageVerificationHandler().
Best Regards & Thanks,
LONG, Qin
-Orig
62 matches
Mail list logo
