Re: [edk2] [PATCH 1/2] ArmPlatformPkg: fix two instances of FreePool () on NULL value

2015-03-27 Thread Ronald Cron
Hi Ard, in the case of the ArmPlatformPkg/Library/PlatformIntelBdsLib/IntelBdsPlatform.c file, it seems that the closing curly bracket is not well aligned. Apart from that, you can add "Reviewed by: Ronald Cron ". Best regards, Ronald. -Original Message- From: Ard

Re: [edk2] [PATCH] MdePkg: fix ARM version of InternalMathSwapBytes64 ()

2015-03-20 Thread Ronald Cron
Reviewed-by: Ronald Cron -Original Message- From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] Sent: 04 March 2015 14:30 To: edk2-devel@lists.sourceforge.net; liming@intel.com Subject: [edk2] [PATCH] MdePkg: fix ARM version of InternalMathSwapBytes64 () The ARM asm

Re: [edk2] [PATCH] MdePkg: fix ARM version of InternalMathSwapBytes64 ()

2015-03-20 Thread Ronald Cron
Hi Ard, I have one question about this patch. Why do you still save r7 into the stack as it is not modified anymore by the routine ? Regards, Ronald. -Original Message- From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] Sent: 04 March 2015 14:30 To: edk2-devel@lists.sourceforge.net;

Re: [edk2] Two Node ARM64 SoC Memory Corruption

2015-03-11 Thread Ronald Cron
more but I am not sure to have much time in the coming days. Regards, Ronald Cron. From: Narinder Dhillon [mailto:ndhillo...@gmail.com] Sent: 06 March 2015 18:54 To: edk2-devel@lists.sourceforge.net Subject: [edk2] Two Node ARM64 SoC Memory Corruption Hi All, I am trying to find out what is