[edk2] [patch] NetworkPkg: Fix bios bootup hang issue when enable network.

2015-07-14 Thread Zhang Lubo
Add three PCD access method types for module to use the PcdDhcp6UidType value to fix the issue. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Zhang Lubo Reviewed-by: Fu Siyuan --- NetworkPkg/NetworkPkg.dec | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[edk2] [PATCH v2] NetworkPkg: Fix an error that the call function declared implicitly.

2015-07-13 Thread Zhang Lubo
Agreement 1.0 Signed-off-by: Zhang Lubo Reviewed-by: Fu Siyuan Reviewed-by: jiaxinwu --- NetworkPkg/DnsDxe/DnsImpl.c| 16 NetworkPkg/HttpBootDxe/HttpBootDhcp4.h | 2 ++ 2 files changed, 10 insertions(+), 8 deletions(-) diff --git a/NetworkPkg/DnsDxe/DnsImpl.c b

Re: [edk2] [patch] NetworkPkg: Fix an error that the call function declared implicitly.

2015-07-13 Thread Zhang, Lubo
Got it ! -Original Message- From: Wu, Jiaxin Sent: Tuesday, July 14, 2015 10:14 AM To: Fu, Siyuan; Zhang, Lubo; Ye, Ting; edk2-devel@lists.sourceforge.net Subject: RE: [patch] NetworkPkg: Fix an error that the call function declared implicitly. Siyuan, you are right, That is a good

[edk2] [patch] NetworkPkg: Fix an error that the call function declared implicitly.

2015-07-13 Thread Zhang Lubo
DnsDxe.inf is effective to different Arch. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Zhang Lubo --- NetworkPkg/DnsDxe/DnsImpl.c | 23 ++- NetworkPkg/NetworkPkg.dsc | 2 +- 2 files changed, 23 insertions(+), 2 deletions(-) diff --git a/NetworkPkg

[edk2] [PATCH v2] MdeModulePkg: Fix a error that return type differs from the left one when assigned

2015-07-09 Thread Zhang Lubo
return status. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Zhang Lubo --- .../Universal/Network/Mtftp4Dxe/Mtftp4Support.c| 61 +- 1 file changed, 37 insertions(+), 24 deletions(-) diff --git a/MdeModulePkg/Universal/Network/Mtftp4Dxe/Mtftp4Suppor

[edk2] [PATCH v2] NetworkPkg: Fix a bug that return type differs from the left one when assigned

2015-07-09 Thread Zhang Lubo
Version v2 includes using local variable to save intermediate variable to make codes easier readable. Using ASSERT_EFI_ERROR instead of check the return status. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Zhang Lubo --- NetworkPkg/Application/IfConfig6/IfConfig6.c

[edk2] [patch] MdeModulePkg: Fix a bug that return type differs from the left one when assigned.

2015-07-09 Thread Zhang Lubo
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Zhang Lubo --- .../Universal/Network/Mtftp4Dxe/Mtftp4Support.c| 45 +- 1 file changed, 36 insertions(+), 9 deletions(-) diff --git a/MdeModulePkg/Universal/Network/Mtftp4Dxe/Mtftp4Support.c b

[edk2] [patch] NetworkPkg: Fix a bug that return type differs from the left one when assigned, another is redefinition when checking whether the string is null.

2015-07-09 Thread Zhang Lubo
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Zhang Lubo --- NetworkPkg/Application/IfConfig6/IfConfig6.c | 2 +- NetworkPkg/Mtftp6Dxe/Mtftp6Support.c | 47 ++-- 2 files changed, 39 insertions(+), 10 deletions(-) diff --git a/NetworkPkg

[edk2] [patch] MdemodulePkg: fix the problem that data type conversion may loss data

2015-07-08 Thread Zhang Lubo
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Zhang Lubo --- MdeModulePkg/Universal/Network/Mtftp4Dxe/Mtftp4Support.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MdeModulePkg/Universal/Network/Mtftp4Dxe/Mtftp4Support.c b/MdeModulePkg

[edk2] [PATCH v4] SecurityPkg:Replace unsafe string functions.

2015-07-07 Thread Zhang Lubo
Use local variable to store the DestMax to make codes more readable. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Zhang Lubo Reviewed-by: Fu Siyuan Reviewed-by: Qiu Shumin Reviewed-by: Jaben Carsey --- .../DxeTcgPhysicalPresenceLib.c| 90

[edk2] [patch v3] SecurityPkg:Replace unsafe string functions.

2015-07-05 Thread Zhang Lubo
om max free buffer size to max size. Update Copyright year. Replace unsafe string functions with new added safe string functions. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Zhang Lubo Reviewed-by: Fu Siyuan Reviewed-by: Qiu Shumin Reviewed-by: Jaben

[edk2] [patch v3] NetworkPkg:Replace unsafe string functions.

2015-07-05 Thread Zhang Lubo
d. Use macro definition instead of constant number. Use non-n version of safe string copy function in some cases. Update Copyright year. Replace unsafe string functions with new added safe string functions. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Zhang Lubo Reviewed-

[edk2] [patch v3] MdeModulePkg: Replace unsafe string functions.

2015-07-05 Thread Zhang Lubo
function from max free buffer size to max size in some cases. Update Copyright year. Replace unsafe string functions with new added safe string functions. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Zhang Lubo Reviewed-by: Fu Siyuan Reviewed-by: Qiu Shumin Reviewed

[edk2] [patch] SecurityPkg: Calculate the length of the String.

2015-07-02 Thread Zhang Lubo
From: "Zhang, Lubo" When the two concatenated strings are both not null, the total length in bytes of them should calculate the character '\0' once. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Zhang Lubo --- .../UserIdentification/U

Re: [edk2] [PATCH v2] SecurityPkg:Replace unsafe string functions.

2015-07-02 Thread Zhang, Lubo
. Thanks, Star > -Original Message- > From: Zhang Lubo [mailto:lubo.zh...@intel.com] > Sent: Thursday, July 2, 2015 4:57 PM > To: edk2-devel@lists.sourceforge.net > Subject: [edk2] [PATCH v2] SecurityPkg:Replace unsafe string functions. > > Replace unsafe string fun

[edk2] [PATCH v2] MdeModulePkg: Replace unsafe string functions.

2015-07-02 Thread Zhang Lubo
Replace unsafe string functions with new added safe string functions. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Zhang Lubo --- MdeModulePkg/Library/DxeNetLib/DxeNetLib.c | 7 +++ .../Universal/Network/IScsiDxe/IScsiConfig.c | 4

[edk2] [PATCH v2] SecurityPkg:Replace unsafe string functions.

2015-07-02 Thread Zhang Lubo
Replace unsafe string functions with new added safe string functions. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Zhang Lubo --- .../DxeTcgPhysicalPresenceLib.c| 90 +++--- .../DxeTrEEPhysicalPresenceLib.c | 18

[edk2] [PATCH v2] NetworkPkg:Replace unsafe string functions.

2015-07-02 Thread Zhang Lubo
Replace unsafe string functions with new added safe string functions. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Zhang Lubo --- NetworkPkg/Application/IfConfig6/IfConfig6.c | 13 ++ NetworkPkg/Application/IpsecConfig/Indexer.c | 4 +- .../Application

Re: [edk2] [patch 2/2] NetworkPkg:Replace unsafe string functions.

2015-06-30 Thread Zhang, Lubo
. You have the number 128 added in lots of places. Where is this number from? Should you use a #define or a PCD or something? If the string was made longer, this would be painful to update so many locations. Inline comments also. >-Original Message- >From: Zhang Lubo [mailto:l

Re: [edk2] [patch 2/2] NetworkPkg:Replace unsafe string functions.

2015-06-30 Thread Zhang, Lubo
hing? If the string was made longer, this would be painful to update so many locations. Inline comments also. >-----Original Message- >From: Zhang Lubo [mailto:lubo.zh...@intel.com] >Sent: Tuesday, June 30, 2015 1:26 AM >To: edk2-devel@lists.sourceforge.net >Subject: [edk2]

[edk2] [patch 1/2] MdeModulePkg: Replace unsafe string functions.

2015-06-30 Thread Zhang Lubo
Replace unsafe string functions with new added safe string functions. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Zhang Lubo --- MdeModulePkg/Library/DxeNetLib/DxeNetLib.c | 4 ++-- MdeModulePkg/Universal/Network/IScsiDxe/IScsiConfig.c | 2

[edk2] [patch 0/2] Replace unsafe string functions.

2015-06-30 Thread Zhang Lubo
Replace unsafe string functions with new added safe string functions. Zhang Lubo (2): MdeModulePkg: Replace unsafe string functions. NetworkPkg:Replace unsafe string functions. MdeModulePkg/Library/DxeNetLib/DxeNetLib.c | 4 +-- .../Universal/Network/IScsiDxe/IScsiConfig.c

[edk2] [patch 2/2] NetworkPkg:Replace unsafe string functions.

2015-06-30 Thread Zhang Lubo
Replace unsafe string functions with new added safe string functions. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Zhang Lubo --- NetworkPkg/Application/IfConfig6/IfConfig6.c | 6 ++-- NetworkPkg/Application/IpsecConfig/Indexer.c | 2 +- .../Application

[edk2] [patch] SecurityPkg:Replace unsafe string functions.

2015-06-30 Thread Zhang Lubo
Replace unsafe string functions with new added safe string functions. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Zhang Lubo --- .../DxeTcgPhysicalPresenceLib.c| 90 +++--- .../DxeTrEEPhysicalPresenceLib.c | 18

[edk2] [patch] SecurityPkg: Calculate the length of the String.

2015-06-29 Thread Zhang Lubo
When the two concatenated strings are both not null, the total length in bytes of them should calculate the character '\0' once. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Zhang Lubo --- .../UserIdentification/UserProfileManagerDxe/UserProfileModify.c

[edk2] [patch] SecurityPkg:Replace unsafe string functions.

2015-06-29 Thread Zhang Lubo
Replace unsafe string functions with new added safe string functions. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Zhang Lubo --- .../DxeTcgPhysicalPresenceLib.c| 90 +++--- .../DxeTrEEPhysicalPresenceLib.c | 18

[edk2] [patch 1/2] MdeModulePkg: Replace unsafe string functions.

2015-06-29 Thread Zhang Lubo
Replace unsafe string functions with new added safe string functions. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Zhang Lubo --- MdeModulePkg/Library/DxeNetLib/DxeNetLib.c | 4 ++-- MdeModulePkg/Universal/Network/IScsiDxe/IScsiConfig.c | 2

[edk2] [patch 0/2] Replace unsafe string functions.

2015-06-29 Thread Zhang Lubo
Replace unsafe string functions with new added safe string functions. Zhang, Lubo (2): MdeModulePkg: Replace unsafe string functions. NetworkPkg:Replace unsafe string functions. MdeModulePkg/Library/DxeNetLib/DxeNetLib.c | 4 +-- .../Universal/Network/IScsiDxe/IScsiConfig.c

[edk2] [patch 2/2] NetworkPkg:Replace unsafe string functions.

2015-06-29 Thread Zhang Lubo
Replace unsafe string functions with new added safe string functions. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Zhang Lubo --- NetworkPkg/Application/IfConfig6/IfConfig6.c | 6 ++-- NetworkPkg/Application/IpsecConfig/Indexer.c | 2 +- .../Application

Re: [edk2] [patch 1/2] NetworkPkg: Check whether the iSCSI initiator name is null.

2015-06-26 Thread Zhang, Lubo
warning if iSCSI initiator name is null before attempt configure. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Zhang Lubo Signed-off-by: Zhang, Lubo --- NetworkPkg/IScsiDxe/IScsiConfig.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/NetworkPkg

[edk2] [patch 1/2] NetworkPkg: Check whether the iSCSI initiator name is null.

2015-06-26 Thread Zhang , Lubo
Popup a warning if iSCSI initiator name is null before attempt configure. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Zhang Lubo Signed-off-by: Zhang, Lubo --- NetworkPkg/IScsiDxe/IScsiConfig.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a