Star:
Your patch is good. Reviewed-by: Gao, Liming
Thanks
Liming
From: Zeng, Star [mailto:star.z...@intel.com]
Sent: Monday, July 14, 2014 9:34 AM
To: edk2-devel@lists.sourceforge.net
Subject: Re: [edk2] [BUG] Wrong StrLen usage in UnicodeStrToAsciiStr()
Hi Sergey,
For "During
sakov [mailto:isakov...@bk.ru]
Sent: Saturday, July 12, 2014 12:55 PM
To: edk2-devel@lists.sourceforge.net
Subject: Re: [edk2] [BUG] Wrong StrLen usage in UnicodeStrToAsciiStr()
Hi Star,
Comments inline
Regards,
Sergey
Hi Sergey,
My comments added below.
Thanks,
Star
From: Sergey Isakov [mailto
e) * sizeof (CHAR16)))” will be
> not triggered, the function’s behavior is incorrect. In the patch the code is
> updated to cover the bug.
>
>
> Thanks,
> Star
> From: Tian, Feng [mailto:feng.t...@intel.com]
> Sent: Monday, July 07, 2014 1:36 PM
> To: edk2-devel@l
Hi Sergey,
My comments added below.
Thanks,
Star
From: Sergey Isakov [mailto:isakov...@bk.ru]
Sent: Friday, July 11, 2014 7:05 PM
To: edk2-devel@lists.sourceforge.net
Subject: Re: [edk2] [BUG] Wrong StrLen usage in UnicodeStrToAsciiStr()
Hi Star,
Did you want to correct second line?
ASSERT
s,
> Star
> From: Tian, Feng [mailto:feng.t...@intel.com]
> Sent: Monday, July 07, 2014 1:36 PM
> To: edk2-devel@lists.sourceforge.net
> Subject: Re: [edk2] [BUG] Wrong StrLen usage in UnicodeStrToAsciiStr()
>
> Hi, Isakov
>
> Thanks for raising this issue. We will w
he function's behavior is incorrect. In the patch the code is
updated to cover the bug.
Thanks,
Star
From: Tian, Feng [mailto:feng.t...@intel.com]
Sent: Monday, July 07, 2014 1:36 PM
To: edk2-devel@lists.sourceforge.net
Subject: Re: [edk2] [BUG] Wrong StrLen usage in UnicodeStrToAsciiStr()
Hi,
Hi, Isakov
Thanks for raising this issue. We will work on it.
Thanks
Feng
From: Sergey Isakov [mailto:isakov...@bk.ru]
Sent: Friday, July 04, 2014 18:13
To: edk2-devel@lists.sourceforge.net
Subject: [edk2] [BUG] Wrong StrLen usage in UnicodeStrToAsciiStr()
Hi,
In function UnicodeStrToAsciiStr
Hi,
In function UnicodeStrToAsciiStr there is a comparison
-
//
// Source and Destination should not overlap
//
ASSERT ((UINTN) ((CHAR16 *) Destination - Source) > StrLen (Source));
ASSERT ((UINTN) ((CHAR8 *) Source - Destination) > StrLen (Source));
-
This is wrong beca
