> -Original Message-
> From: Justen, Jordan L
> Sent: Wednesday, July 08, 2015 11:14 AM
> To: edk2-devel@lists.sourceforge.net; Wu, Hao A; edk2-
> de...@lists.sourceforge.net; Gao, Liming
> Subject: Re: [edk2] [PATCH] IntelFrameworkPkg FrameworkUefiLib: Resolve
> is
I think maybe the subject could be improved. I prefer to describe the
problem instead.
IntelFrameworkPkg FrameworkUefiLib: Fix ASSERT in CatVSPrint
Then, I think you can mention the r17740 regression in the main body
of the commit message.
I also have a suggestion below.
On 2015-07-07 17:46:35,
BufferToReturn = AllocateCopyPool(SizeRequired, String);
The above using of AllocateCopyPool() will cause ASSERT if 'String' is
NULL. Therefore, proper check for 'String' is needed.
The above using of AllocateCopyPool() will read contents out of the scope
of 'String'. Potential risk for 'String'
