Re: [edk2] [PATCH] ShellPkg\Application\Shell: Refine the code style.

2015-06-19 Thread Scott Duplichan
Daryl McDaniel [mailto:edk2-li...@mc2research.org] wrote: ]Sent: Friday, June 19, 2015 08:26 AM ]To: edk2-devel@lists.sourceforge.net ]Subject: Re: [edk2] [PATCH] ShellPkg\Application\Shell: Refine the code style. ] ]I think you misinterpreted the Coding Standard. ]It says that while comparisons

Re: [edk2] [PATCH] ShellPkg\Application\Shell: Refine the code style.

2015-06-19 Thread Carsey, Jaben
Reviewed-by: Jaben Carsey >-Original Message- >From: Qiu, Shumin >Sent: Friday, June 19, 2015 1:43 AM >To: edk2-devel@lists.sourceforge.net >Cc: Carsey, Jaben >Subject: [PATCH] ShellPkg\Application\Shell: Refine the code style. >Importance: High > >BOOLEAN variable should not use explici

Re: [edk2] [PATCH] ShellPkg\Application\Shell: Refine the code style.

2015-06-19 Thread Daryl McDaniel
t: Friday, June 19, 2015 1:43 AM To: edk2-devel@lists.sourceforge.net Subject: [edk2] [PATCH] ShellPkg\Application\Shell: Refine the code style. BOOLEAN variable should not use explicit comparisons to TRUE or FALSE. To follow EDKII code style. Contributed-under: TianoCore Contribution Agreement 1.

[edk2] [PATCH] ShellPkg\Application\Shell: Refine the code style.

2015-06-19 Thread Qiu Shumin
BOOLEAN variable should not use explicit comparisons to TRUE or FALSE. To follow EDKII code style. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qiu Shumin --- ShellPkg/Application/Shell/ConsoleLogger.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a