Re: [edk2] [PATCH 2/2] OvmfPkg/SMBIOS: Add QEMU support to OVMF SMBIOS driver

2014-05-14 Thread Jordan Justen
On Wed, May 14, 2014 at 10:02 AM, Gabriel L. Somlo wrote: > On Wed, May 14, 2014 at 09:24:03AM -0700, Jordan Justen wrote: >> On Tue, May 13, 2014 at 3:13 PM, Gabriel L. Somlo wrote: >> > Contributed-under: TianoCore Contribution Agreement 1.0 >> > Signed-off-by: Gabriel Somlo >> >> Can you sync

Re: [edk2] [PATCH 2/2] OvmfPkg/SMBIOS: Add QEMU support to OVMF SMBIOS driver

2014-05-14 Thread Gabriel L. Somlo
On Wed, May 14, 2014 at 09:24:03AM -0700, Jordan Justen wrote: > On Tue, May 13, 2014 at 3:13 PM, Gabriel L. Somlo wrote: > > Contributed-under: TianoCore Contribution Agreement 1.0 > > Signed-off-by: Gabriel Somlo > > Can you sync this up with the address the patch is being sent from? I will t

Re: [edk2] [PATCH 2/2] OvmfPkg/SMBIOS: Add QEMU support to OVMF SMBIOS driver

2014-05-14 Thread Jordan Justen
On Tue, May 13, 2014 at 3:13 PM, Gabriel L. Somlo wrote: > Locate QEMU SMBIOS data in fw_cfg and install it via the > SMBIOS protocol. > > Starting with qemu-2.1, on pc/x86 machines of type >= 2.1, full > SMBIOS tables are generated and inserted into fw_cfg (i.e., no > per-field patching of locall

Re: [edk2] [PATCH 2/2] OvmfPkg/SMBIOS: Add QEMU support to OVMF SMBIOS driver

2014-05-14 Thread Laszlo Ersek
one irrelevant style comment in the middle On 05/14/14 00:13, Gabriel L. Somlo wrote: > Locate QEMU SMBIOS data in fw_cfg and install it via the > SMBIOS protocol. > > Starting with qemu-2.1, on pc/x86 machines of type >= 2.1, full > SMBIOS tables are generated and inserted into fw_cfg (i.e., no

[edk2] [PATCH 2/2] OvmfPkg/SMBIOS: Add QEMU support to OVMF SMBIOS driver

2014-05-13 Thread Gabriel L. Somlo
Locate QEMU SMBIOS data in fw_cfg and install it via the SMBIOS protocol. Starting with qemu-2.1, on pc/x86 machines of type >= 2.1, full SMBIOS tables are generated and inserted into fw_cfg (i.e., no per-field patching of locally generated structures is required). Aside from new code to extract