Re: [edk2] [PATCH v2 6/6] OvmfPkg XenBusDxe: Convert X64/TestAndClearBit.asm to NASM

2014-11-13 Thread Anthony PERARD
On Thu, Nov 13, 2014 at 07:00:18PM +0100, Laszlo Ersek wrote: > On 11/13/14 18:55, Anthony PERARD wrote: > > On Thu, Nov 13, 2014 at 12:13:23PM +0100, Laszlo Ersek wrote: > > >> But nasm emits the same warning. Any ideas? > > > > Yes, put lock and btr on the same line ... > > ASM_PFX(TestAndClea

Re: [edk2] [PATCH v2 6/6] OvmfPkg XenBusDxe: Convert X64/TestAndClearBit.asm to NASM

2014-11-13 Thread Laszlo Ersek
On 11/13/14 18:55, Anthony PERARD wrote: > On Thu, Nov 13, 2014 at 12:13:23PM +0100, Laszlo Ersek wrote: >> But nasm emits the same warning. Any ideas? > > Yes, put lock and btr on the same line ... > ASM_PFX(TestAndClearBit): > - lock > - btr [rdx], ecx > + lock btr [rdx], ecx > sbb e

Re: [edk2] [PATCH v2 6/6] OvmfPkg XenBusDxe: Convert X64/TestAndClearBit.asm to NASM

2014-11-13 Thread Anthony PERARD
On Thu, Nov 13, 2014 at 12:13:23PM +0100, Laszlo Ersek wrote: > Anthony, > > On 11/06/14 12:24, Anthony PERARD wrote: > > The BaseTools/Scripts/ConvertMasmToNasm.py script was used to convert > > X64/TestAndClearBit.asm to X64/TestAndClearBit.nasm > > > > Contributed-under: TianoCore Contribution

Re: [edk2] [PATCH v2 6/6] OvmfPkg XenBusDxe: Convert X64/TestAndClearBit.asm to NASM

2014-11-13 Thread Laszlo Ersek
Anthony, On 11/06/14 12:24, Anthony PERARD wrote: > The BaseTools/Scripts/ConvertMasmToNasm.py script was used to convert > X64/TestAndClearBit.asm to X64/TestAndClearBit.nasm > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Anthony PERARD > --- > OvmfPkg/XenBusDxe/X

[edk2] [PATCH v2 6/6] OvmfPkg XenBusDxe: Convert X64/TestAndClearBit.asm to NASM

2014-11-06 Thread Anthony PERARD
The BaseTools/Scripts/ConvertMasmToNasm.py script was used to convert X64/TestAndClearBit.asm to X64/TestAndClearBit.nasm Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Anthony PERARD --- OvmfPkg/XenBusDxe/X64/TestAndClearBit.S | 12 .../