Re: [edk2] [PATCH v3 3/7] EmulatorPkg: Remove Ip4ConfigDxe module from EmulatorPkg

2015-07-10 Thread Laszlo Ersek
On 07/10/15 18:36, Jordan Justen wrote: > On 2015-07-10 04:29:11, Laszlo Ersek wrote: >> On 07/10/15 10:40, Wu, Jiaxin wrote: >>> Yes, edk2-devel will strip it. You can check version2 for those >>> series patches, I had added someone with cc tag to the commit >>> message, but it haven't actually cc

Re: [edk2] [PATCH v3 3/7] EmulatorPkg: Remove Ip4ConfigDxe module from EmulatorPkg

2015-07-10 Thread Laszlo Ersek
ve to the new mailing list. Thank you! Laszlo > > Thanks again. > Jiaxin > > > -----Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Friday, July 10, 2015 7:29 PM > To: Wu, Jiaxin > Cc: Justen, Jordan L; edk2-devel@lists.sourceforge.n

Re: [edk2] [PATCH v3 3/7] EmulatorPkg: Remove Ip4ConfigDxe module from EmulatorPkg

2015-07-10 Thread Jordan Justen
On 2015-07-10 04:29:11, Laszlo Ersek wrote: > On 07/10/15 10:40, Wu, Jiaxin wrote: > > Yes, edk2-devel will strip it. You can check version2 for those > > series patches, I had added someone with cc tag to the commit > > message, but it haven't actually cc to those people. > > (3) Laszlo will get

Re: [edk2] [PATCH v3 3/7] EmulatorPkg: Remove Ip4ConfigDxe module from EmulatorPkg

2015-07-10 Thread Wu, Jiaxin
k [mailto:ler...@redhat.com] Sent: Friday, July 10, 2015 7:29 PM To: Wu, Jiaxin Cc: Justen, Jordan L; edk2-devel@lists.sourceforge.net; af...@apple.com Subject: Re: [edk2] [PATCH v3 3/7] EmulatorPkg: Remove Ip4ConfigDxe module from EmulatorPkg On 07/10/15 10:40, Wu, Jiaxin wrote: > Yes, edk

Re: [edk2] [PATCH v3 3/7] EmulatorPkg: Remove Ip4ConfigDxe module from EmulatorPkg

2015-07-10 Thread Bruce Cran
On Fri, Jul 10, 2015 at 01:29:11PM +0200, Laszlo Ersek wrote: > > - Then you format the patch with "git format-patch", and send it with > "git send-email" to "edk2-devel" (To:). You can also skip the format-patch step and pass a revset spec directly to send-email - e.g. "git send-email -1". --

Re: [edk2] [PATCH v3 3/7] EmulatorPkg: Remove Ip4ConfigDxe module from EmulatorPkg

2015-07-10 Thread Laszlo Ersek
On 07/10/15 10:40, Wu, Jiaxin wrote: > Yes, edk2-devel will strip it. You can check version2 for those > series patches, I had added someone with cc tag to the commit > message, but it haven't actually cc to those people. Yes, you did! I *did* get a personal copy of the v2 patches from you! (And

Re: [edk2] [PATCH v3 3/7] EmulatorPkg: Remove Ip4ConfigDxe module from EmulatorPkg

2015-07-10 Thread Wu, Jiaxin
Yes, edk2-devel will strip it. You can check version2 for those series patches, I had added someone with cc tag to the commit message, but it haven't actually cc to those people. For the git script format, I know it support both linux shell and windows CMD(CMD is my choice). *Firstly, we must a

Re: [edk2] [PATCH v3 3/7] EmulatorPkg: Remove Ip4ConfigDxe module from EmulatorPkg

2015-07-10 Thread Jordan Justen
On 2015-07-10 00:29:18, Wu, Jiaxin wrote: > I agree your suggested format absolutely. Sorry for my missing any attention. > > I'm not "Cc" any maintainer manually. We should know that the Cc > part maintainers in commit message will be ignored by edk2-devel if > the maintainers already in edk2-dev

Re: [edk2] [PATCH v3 3/7] EmulatorPkg: Remove Ip4ConfigDxe module from EmulatorPkg

2015-07-10 Thread Wu, Jiaxin
I agree your suggested format absolutely. Sorry for my missing any attention. I'm not "Cc" any maintainer manually. We should know that the Cc part maintainers in commit message will be ignored by edk2-devel if the maintainers already in edk2-devel mailing list. So, if we want to send out the p

Re: [edk2] [PATCH v3 3/7] EmulatorPkg: Remove Ip4ConfigDxe module from EmulatorPkg

2015-07-09 Thread Jordan Justen
When you send new versions of the patch series, can you not reply to the previous version? Then discussions for each version of the series can happen separately. (It also makes v3 get a little hidden in the old v1/v2 emails.) On 2015-07-09 00:24:34, Jiaxin Wu wrote: > Version3 continue to update w

Re: [edk2] [PATCH v3 3/7] EmulatorPkg: Remove Ip4ConfigDxe module from EmulatorPkg

2015-07-09 Thread Ye, Ting
Reviewed-by: Ye Ting -Original Message- From: Jiaxin Wu [mailto:jiaxin...@intel.com] Sent: Thursday, July 09, 2015 3:25 PM To: edk2-devel@lists.sourceforge.net; Justen, Jordan L; af...@apple.com Subject: [edk2] [PATCH v3 3/7] EmulatorPkg: Remove Ip4ConfigDxe module from EmulatorPkg

[edk2] [PATCH v3 3/7] EmulatorPkg: Remove Ip4ConfigDxe module from EmulatorPkg

2015-07-09 Thread Jiaxin Wu
Version3 continue to update with a proper commit message. Ip4ConfigDxe driver is deprecated in UEFI 2.5, so we will not support original Ip4Config Protocol, which is replace by Ip4Config2 Protocol integrated in Ip4Dxe driver(git commit 1f6729ff (SVN r17853)).Therefore we can remove Ip4ConfigDxe