Jordan,
Yes. With that one comment added, the entire series looks good to me..
Reviewed-by: Michael Kinney
Mike
-Original Message-
From: Justen, Jordan L
Sent: Sunday, June 07, 2015 11:13 PM
To: Kinney, Michael D; edk2-devel@lists.sourceforge.net
Cc: Liu, Yingke D; Laszlo Ersek
Subj
On 2015-06-07 20:44:16, Kinney, Michael D wrote:
> +
> +TheUcs2Codec = Ucs2Codec()
>
> This is creating a global object in this module for the USC-2 codec.
> Needs a comment to describe this.
Ok.
How about:
## Instance of Ucs2Codec class
#
# This object is used to support a codec for UCS-2 enco
Jordan,
The functionality of the patch set looks good. Just a few comments below about
needing some better comments.
Reviewed-by: Michael Kinney
We also discussed the need for an extra tool that can scan a workspace or a
package for UNI files and convert them to UTF-16LE. This tool may be
On 2015-06-01 02:46:53, Laszlo Ersek wrote:
> On 06/01/15 09:31, Jordan Justen wrote:
> > Supplementary Plane characters can exist in UTF-16 files,
> > but they are not valid UCS-2 characters.
> >
> > For example, refer to this python interpreter code:
> import codecs
> codecs.encode(u'\
On 06/01/15 09:31, Jordan Justen wrote:
> Supplementary Plane characters can exist in UTF-16 files,
> but they are not valid UCS-2 characters.
>
> For example, refer to this python interpreter code:
import codecs
codecs.encode(u'\U00010300', 'utf-16')
> '\xff\xfe\x00\xd8\x00\xdf'
>
> Th
Supplementary Plane characters can exist in UTF-16 files,
but they are not valid UCS-2 characters.
For example, refer to this python interpreter code:
>>> import codecs
>>> codecs.encode(u'\U00010300', 'utf-16')
'\xff\xfe\x00\xd8\x00\xdf'
Therefore the UCS-4 0x00010300 character is encoded as two
