Re: [edk2] [PATCH v4 6/6] OvmfPkg: PlatformBdsLib: Platform dependent PCI/IRQ initialization

2014-11-10 Thread Laszlo Ersek
On 11/07/14 17:40, Gabriel Somlo wrote: > On Mon, Nov 03, 2014 at 08:59:34PM +0100, Laszlo Ersek wrote: >>> Additionally, initialize PCI_INTERRUPT_LINE registers for the typical >>> set of PCI devices included by QEMU with the Q35 machine type. The >>> corresponding PIIX4 initialization of PCI_INTE

Re: [edk2] [PATCH v4 6/6] OvmfPkg: PlatformBdsLib: Platform dependent PCI/IRQ initialization

2014-11-10 Thread Gerd Hoffmann
Hi, > From what I have been able to see, "pci->parent" is always NULL from > the very beginning, so the IRQ is computed based only on the "pin" and > the device number ("pci_bdf_to_dev(pci->bdf)"), and by that I mean > the *original* pci->bdf, not the result of walking up the parent link. On a

Re: [edk2] [PATCH v4 6/6] OvmfPkg: PlatformBdsLib: Platform dependent PCI/IRQ initialization

2014-11-07 Thread Paolo Bonzini
On 07/11/2014 18:31, Gabriel Somlo wrote: > I don't care about non-root ports at all, personally. But if I'm doing > this for my own ulterior motives (below), I feel I should do it in the > best way the surrounding infrastructure permits it. I'm definitely NOT > signing up to ADD non-root port supp

Re: [edk2] [PATCH v4 6/6] OvmfPkg: PlatformBdsLib: Platform dependent PCI/IRQ initialization

2014-11-07 Thread Gabriel Somlo
On Fri, Nov 07, 2014 at 05:55:59PM +0100, Paolo Bonzini wrote: > On 07/11/2014 17:40, Gabriel Somlo wrote: > > > > I don't know how I could bring a bus number into the mix (I just > > assume the bus number is 0 and stop after the first device path node, > > which happens to match the SeaBIOS (pci-

Re: [edk2] [PATCH v4 6/6] OvmfPkg: PlatformBdsLib: Platform dependent PCI/IRQ initialization

2014-11-07 Thread Paolo Bonzini
On 07/11/2014 17:40, Gabriel Somlo wrote: > > I don't know how I could bring a bus number into the mix (I just > assume the bus number is 0 and stop after the first device path node, > which happens to match the SeaBIOS (pci->parent == NULL) case. > > But how would I (and should I even try) to po

Re: [edk2] [PATCH v4 6/6] OvmfPkg: PlatformBdsLib: Platform dependent PCI/IRQ initialization

2014-11-07 Thread Gabriel Somlo
On Mon, Nov 03, 2014 at 08:59:34PM +0100, Laszlo Ersek wrote: > > Additionally, initialize PCI_INTERRUPT_LINE registers for the typical > > set of PCI devices included by QEMU with the Q35 machine type. The > > corresponding PIIX4 initialization of PCI_INTERRUPT_LINE registers is > > cleaned up and

Re: [edk2] [PATCH v4 6/6] OvmfPkg: PlatformBdsLib: Platform dependent PCI/IRQ initialization

2014-11-03 Thread Laszlo Ersek
On 11/01/14 23:21, Gabriel L. Somlo wrote: > Merge PciInitialization() and AcpiInitialization() into a single > function, PciAcpiInitialization(), and use a PCD set during PEI to > detect the underlying platform type (PIIX4 or Q35/MCH) and therefore > the addresses of the registers to be initialize

[edk2] [PATCH v4 6/6] OvmfPkg: PlatformBdsLib: Platform dependent PCI/IRQ initialization

2014-11-01 Thread Gabriel L. Somlo
Merge PciInitialization() and AcpiInitialization() into a single function, PciAcpiInitialization(), and use a PCD set during PEI to detect the underlying platform type (PIIX4 or Q35/MCH) and therefore the addresses of the registers to be initialized. Add LNK[A-H] routing target initialization for