Re: [edk2] [PATCH v5 2/9] OvmfPkg: PlatformPei: Platform specific ACPI power management setup

2014-11-13 Thread Andrew Fish
Sent from my iPhone > On Nov 13, 2014, at 11:14 AM, Jordan Justen wrote: > >> On 2014-11-13 09:46:29, Laszlo Ersek wrote: >>> On 11/13/14 18:40, Gabriel Somlo wrote: On Thu, 13 Nov 2014 09:27:09 -0600, Scott Duplichan wrote: Gabriel Somlo [mailto:gso...@gmail.com] wrote: ]On Sun

Re: [edk2] [PATCH v5 2/9] OvmfPkg: PlatformPei: Platform specific ACPI power management setup

2014-11-13 Thread Jordan Justen
On 2014-11-13 09:46:29, Laszlo Ersek wrote: > On 11/13/14 18:40, Gabriel Somlo wrote: > > On Thu, 13 Nov 2014 09:27:09 -0600, Scott Duplichan wrote: > >> Gabriel Somlo [mailto:gso...@gmail.com] wrote: > >> ]On Sun, Nov 09, 2014 at 05:00:38PM -0800, Jordan Justen wrote: > >> ]> On 2014-11-08 14:01:5

Re: [edk2] [PATCH v5 2/9] OvmfPkg: PlatformPei: Platform specific ACPI power management setup

2014-11-13 Thread Laszlo Ersek
On 11/13/14 18:40, Gabriel Somlo wrote: > On Thu, 13 Nov 2014 09:27:09 -0600, Scott Duplichan wrote: >> Gabriel Somlo [mailto:gso...@gmail.com] wrote: >> ]On Sun, Nov 09, 2014 at 05:00:38PM -0800, Jordan Justen wrote: >> ]> On 2014-11-08 14:01:56, Gabriel L. Somlo wrote: >> ]> > @@ -228,6 +229,11 @

Re: [edk2] [PATCH v5 2/9] OvmfPkg: PlatformPei: Platform specific ACPI power management setup

2014-11-13 Thread Gabriel Somlo
On Thu, 13 Nov 2014 09:27:09 -0600, Scott Duplichan wrote: > Gabriel Somlo [mailto:gso...@gmail.com] wrote: > ]On Sun, Nov 09, 2014 at 05:00:38PM -0800, Jordan Justen wrote: > ]> On 2014-11-08 14:01:56, Gabriel L. Somlo wrote: > ]> > @@ -228,6 +229,11 @@ MiscInitialization ( > ]> >VOID > ]> >

Re: [edk2] [PATCH v5 2/9] OvmfPkg: PlatformPei: Platform specific ACPI power management setup

2014-11-13 Thread Scott Duplichan
Gabriel Somlo [mailto:gso...@gmail.com] wrote: ]On Sun, Nov 09, 2014 at 05:00:38PM -0800, Jordan Justen wrote: ]> On 2014-11-08 14:01:56, Gabriel L. Somlo wrote: ]> > @@ -228,6 +229,11 @@ MiscInitialization ( ]> >VOID ]> >) ]> > { ]> > + UINT16 HostBridgeDevId; ]> > + UINTN PmCmd; ]> >

Re: [edk2] [PATCH v5 2/9] OvmfPkg: PlatformPei: Platform specific ACPI power management setup

2014-11-13 Thread Anthony PERARD
On Wed, Nov 12, 2014 at 11:41:54AM -0800, Jordan Justen wrote: > On 2014-11-12 05:38:28, Gabriel Somlo wrote: > > On Tue, Nov 11, 2014 at 07:54:30PM -0800, Jordan Justen wrote: > > > > > When I build IA32 (OvmfPkg/build.sh -a IA32) I get warnings about > > > > > possibly uninitialized variables. >

Re: [edk2] [PATCH v5 2/9] OvmfPkg: PlatformPei: Platform specific ACPI power management setup

2014-11-12 Thread Jordan Justen
On 2014-11-12 05:38:28, Gabriel Somlo wrote: > On Tue, Nov 11, 2014 at 07:54:30PM -0800, Jordan Justen wrote: > > > > When I build IA32 (OvmfPkg/build.sh -a IA32) I get warnings about > > > > possibly uninitialized variables. > > > > > > > > It seems to happen basically everwhere that you switch o

Re: [edk2] [PATCH v5 2/9] OvmfPkg: PlatformPei: Platform specific ACPI power management setup

2014-11-12 Thread Gabriel Somlo
On Tue, Nov 11, 2014 at 07:54:30PM -0800, Jordan Justen wrote: > > > When I build IA32 (OvmfPkg/build.sh -a IA32) I get warnings about > > > possibly uninitialized variables. > > > > > > It seems to happen basically everwhere that you switch on > > > HostBridgeDevId. > > > > I wonder why it's onl

Re: [edk2] [PATCH v5 2/9] OvmfPkg: PlatformPei: Platform specific ACPI power management setup

2014-11-11 Thread Jordan Justen
On 2014-11-11 19:10:20, Gabriel Somlo wrote: > On Sun, Nov 09, 2014 at 05:00:38PM -0800, Jordan Justen wrote: > > On 2014-11-08 14:01:56, Gabriel L. Somlo wrote: > > > @@ -228,6 +229,11 @@ MiscInitialization ( > > >VOID > > >) > > > { > > > + UINT16 HostBridgeDevId; > > > + UINTN PmCmd;

Re: [edk2] [PATCH v5 2/9] OvmfPkg: PlatformPei: Platform specific ACPI power management setup

2014-11-11 Thread Gabriel Somlo
On Sun, Nov 09, 2014 at 05:00:38PM -0800, Jordan Justen wrote: > On 2014-11-08 14:01:56, Gabriel L. Somlo wrote: > > @@ -228,6 +229,11 @@ MiscInitialization ( > >VOID > >) > > { > > + UINT16 HostBridgeDevId; > > + UINTN PmCmd; > > + UINTN Pmba; > > + UINTN PmRegMisc; > > + > >//

Re: [edk2] [PATCH v5 2/9] OvmfPkg: PlatformPei: Platform specific ACPI power management setup

2014-11-09 Thread Jordan Justen
On 2014-11-08 14:01:56, Gabriel L. Somlo wrote: > Set up ACPI power management using registers determined based on > the underlying (PIIX4 or Q35/MCH) platform type. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Gabriel Somlo > Reviewed-by: Paolo Bonzini > Reviewed

[edk2] [PATCH v5 2/9] OvmfPkg: PlatformPei: Platform specific ACPI power management setup

2014-11-08 Thread Gabriel L. Somlo
Set up ACPI power management using registers determined based on the underlying (PIIX4 or Q35/MCH) platform type. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Gabriel Somlo Reviewed-by: Paolo Bonzini Reviewed-by: Jordan Justen Reviewed-by: Gerd Hoffmann Reviewed-by: L