Re: [edk2] [Patch] CorebootModulePkg: Coding style update

2015-05-20 Thread Dong, Guo
20, 2015 12:00 AM To: Dong, Guo Cc: edk2-devel@lists.sourceforge.net Subject: RE: [edk2] [Patch] CorebootModulePkg: Coding style update Hi, Guo, Please remember to CC the package owners in future. Could you please update the Copyright information in the file accordingly? Everything else looks

Re: [edk2] [Patch] CorebootModulePkg: Coding style update

2015-05-19 Thread Ma, Maurice
: Tuesday, May 19, 2015 5:09 AM To: edk2-devel@lists.sourceforge.net Subject: [edk2] [Patch] CorebootModulePkg: Coding style update This patch update file CbParseLib.c to make it consistent with EDKII coding style: 1) Add function comments. 2) Add {} for if statement. 3) Compare with NULL for pointer and

[edk2] [Patch] CorebootModulePkg: Coding style update

2015-05-19 Thread Guo Dong
This patch update file CbParseLib.c to make it consistent with EDKII coding style: 1) Add function comments. 2) Add {} for if statement. 3) Compare with NULL for pointer and compare with 0 for integer instead of using them like a BOOLEAN. 4) For debug information only, use EFI_D_INFO instead of E