Re: [edk2] [Patch 1/2] NetworkPkg: Code logic optimization for DnsDxe and HttpDxe driver

2015-07-10 Thread Leif Lindholm
On Fri, Jul 10, 2015 at 04:19:08PM +0800, Wang Fan wrote: > Revise some errors which may lead NULL pointer be dereferenced: > * DnsDhcp.c: Paralist may be used without any initialized > * DnsHeader and RcvString may be null but be dereferenced > * HttpDriver.c: revise an if judgment > * HttpImpl.c:

Re: [edk2] [Patch 1/2] NetworkPkg: Code logic optimization for DnsDxe and HttpDxe driver

2015-07-10 Thread Ard Biesheuvel
On 10 July 2015 at 10:19, Wang Fan wrote: > Revise some errors which may lead NULL pointer be dereferenced: > * DnsDhcp.c: Paralist may be used without any initialized > * DnsHeader and RcvString may be null but be dereferenced > * HttpDriver.c: revise an if judgment > * HttpImpl.c: add a judgment

Re: [edk2] [Patch 1/2] NetworkPkg: Code logic optimization for DnsDxe and HttpDxe driver

2015-07-10 Thread Wu, Jiaxin
Reviewed-by: Jiaxin Wu -Original Message- From: Wang, Fan Sent: Friday, July 10, 2015 4:19 PM To: Wu, Jiaxin; Fu, Siyuan; edk2-devel@lists.sourceforge.net Cc: Wang, Fan Subject: [Patch 1/2] NetworkPkg: Code logic optimization for DnsDxe and HttpDxe driver Revise some errors which may l

Re: [edk2] [Patch 1/2] NetworkPkg: Code logic optimization for DnsDxe and HttpDxe driver

2015-07-10 Thread Ye, Ting
Looks good. Reviewed-by: Ye Ting -Original Message- From: Wang Fan [mailto:fan.w...@intel.com] Sent: Friday, July 10, 2015 4:19 PM To: Wu, Jiaxin; Fu, Siyuan; edk2-devel@lists.sourceforge.net Subject: [edk2] [Patch 1/2] NetworkPkg: Code logic optimization for DnsDxe and HttpDxe driver

[edk2] [Patch 1/2] NetworkPkg: Code logic optimization for DnsDxe and HttpDxe driver

2015-07-10 Thread Wang Fan
Revise some errors which may lead NULL pointer be dereferenced: * DnsDhcp.c: Paralist may be used without any initialized * DnsHeader and RcvString may be null but be dereferenced * HttpDriver.c: revise an if judgment * HttpImpl.c: add a judgment to avoid null dereferenced Contributed-under: Tiano