[edk2] [Patch 1/3] MdePkg: Add Microsoft UX capsule GUID & layout

2015-05-11 Thread Zhang, Chao B
Add Microsoft UX capsule GUID & layout into IndustryStandard Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Chao Zhang --- MdePkg/Include/IndustryStandard/WindowsUxCapsule.h | 46 ++ MdePkg/MdePkg.dec | 6 +++ 2 files

Re: [edk2] [Patch 1/3] MdePkg : Add Microsoft UX capsule GUID & layout

2015-05-05 Thread Kinney, Michael D
] [Patch 1/3] MdePkg : Add Microsoft UX capsule GUID & layout On 05/05/2015 01:24 PM, Kinney, Michael D wrote: > Laszlo, > > Yes. We have verified that this feature is supported by VS > toolchains, but we do have to disable warning 4200. I will prepare > that patch for review.

Re: [edk2] [Patch 1/3] MdePkg : Add Microsoft UX capsule GUID & layout

2015-05-05 Thread Blibbet
> The flexible array member is a C99 feature. Is it generally allowed for > edk2 code, as a universally supported extension to the otherwise > mandated C95? > > http://thread.gmane.org/gmane.comp.bios.tianocore.devel/2339/focus=2359 Microsoft C doesn't support C99. Microsoft C is needed for nearly

Re: [edk2] [Patch 1/3] MdePkg : Add Microsoft UX capsule GUID & layout

2015-05-05 Thread Brian J. Johnson
On 05/05/2015 01:24 PM, Kinney, Michael D wrote: > Laszlo, > > Yes. We have verified that this feature is supported by VS > toolchains, but we do have to disable warning 4200. I will prepare > that patch for review. How about the old WINDDK 3790.1830? It's still a supported toolchain, and is i

Re: [edk2] [Patch 1/3] MdePkg : Add Microsoft UX capsule GUID & layout

2015-05-05 Thread Kinney, Michael D
, Michael D Cc: edk2-devel@lists.sourceforge.net; Zhang, Chao B; Mcdaniel, Daryl Subject: Re: [edk2] [Patch 1/3] MdePkg : Add Microsoft UX capsule GUID & layout On 05/05/15 19:34, Kinney, Michael D wrote: > Laszlo, > > I agree with the general guidance from that thread. However, data

Re: [edk2] [Patch 1/3] MdePkg : Add Microsoft UX capsule GUID & layout

2015-05-05 Thread Laszlo Ersek
gt; > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Tuesday, May 05, 2015 8:53 AM > To: Kinney, Michael D > Cc: edk2-devel@lists.sourceforge.net; Zhang, Chao B; Mcdaniel, Daryl > Subject: Re: [edk2] [Patch 1/3] MdePkg : Add Microsoft UX capsule GUID

Re: [edk2] [Patch 1/3] MdePkg : Add Microsoft UX capsule GUID & layout

2015-05-05 Thread Kinney, Michael D
] Sent: Tuesday, May 05, 2015 8:53 AM To: Kinney, Michael D Cc: edk2-devel@lists.sourceforge.net; Zhang, Chao B; Mcdaniel, Daryl Subject: Re: [edk2] [Patch 1/3] MdePkg : Add Microsoft UX capsule GUID & layout Hello Mike, On 05/05/15 17:35, Kinney, Michael D wrote: > Forward reference decla

Re: [edk2] [Patch 1/3] MdePkg : Add Microsoft UX capsule GUID & layout

2015-05-05 Thread Laszlo Ersek
Hello Mike, On 05/05/15 17:35, Kinney, Michael D wrote: > Forward reference declarations are not required for this file and should be > removed. > > Also, the Image[1] field of the DISPLAY_DISPLAY_PAYLOAD structure > should be declared as Image[]. That is the recommended style for new > structu

Re: [edk2] [Patch 1/3] MdePkg : Add Microsoft UX capsule GUID & layout

2015-05-05 Thread Kinney, Michael D
in the structure. Mike -Original Message- From: Zhang, Chao B [mailto:chao.b.zh...@intel.com] Sent: Monday, May 04, 2015 11:08 PM To: edk2-devel@lists.sourceforge.net Cc: Zhang, Chao B Subject: [edk2] [Patch 1/3] MdePkg : Add Microsoft UX capsule GUID & layout Add Microsoft UX cap

[edk2] [Patch 1/3] MdePkg : Add Microsoft UX capsule GUID & layout

2015-05-04 Thread Zhang, Chao B
Add Microsoft UX capsule GUID & layout into IndustryStandard Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Chao Zhang --- MdePkg/Include/IndustryStandard/WindowsUxCapsule.h | 53 ++ MdePkg/MdePkg.dec | 5 ++ 2 files